From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ekHTd-0003C9-SY
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:49:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ekHTa-0003ab-PM
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:49:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:56198)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ekHTa-0003aU-Lm
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:49:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ekHTa-00036i-Dh
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:49:02 -0500
Subject: [bug#30404] [PATCH] Add cat-avatar-generator-service.
Resent-Message-ID: <handler.30404.B30404.151821652511917@debbugs.gnu.org>
Date: Fri, 9 Feb 2018 23:48:32 +0100
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20180209234832.6adb3206@lepiller.eu>
In-Reply-To: <87po5dx0uy.fsf@gnu.org>
References: <20180209214356.640edd8f@lepiller.eu>
	<87po5dx0uy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 30404@debbugs.gnu.org

Le Fri, 09 Feb 2018 23:19:17 +0100,
ludo@gnu.org (Ludovic Court=C3=A8s) a =C3=A9crit :

> Julien Lepiller <julien@lepiller.eu> skribis:
>=20
> > By the way, if you don't know the author of this package, he's
> > awesome: https://www.peppercarrot.com/ =20
>=20
> Looks very nice indeed!
>=20
> > From 5375bd9633cb37b3f26d16742fdc451f3296f723 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien@lepiller.eu>
> > Date: Fri, 12 Jan 2018 23:08:50 +0100
> > Subject: [PATCH 1/2] gnu: Add cat-avatar-generator.
> >
> > * gnu/packages/web.scm (cat-avatar-generator): New variable. =20
>=20
> LGTM.
>=20
> > From b5e362ac44bf3bd284ba14e886960311b67a4019 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien@lepiller.eu>
> > Date: Fri, 12 Jan 2018 23:14:14 +0100
> > Subject: [PATCH 2/2] gnu: Add cat-avatar-generator-service.
> >
> > * gnu/services/web.scm (cat-avatar-generator-service): New
> > variable. =20
>=20
> [...]
>=20
> > +(define* (cat-avatar-generator-service
> > +           #:key
> > +           (cache-dir "/var/cache/cat-avatar-generator")
> > +           (configuration (nginx-server-configuration)))
> > +  (simple-service 'cat-http-server nginx-service-type
> > +    (list (nginx-server-configuration =20
>=20
> Normally the 3rd argument would be aligned with the 1st here.
I don't understand that comment... What should be aligned exactly?

>=20
> You=E2=80=99ll hate me for asking that, but could you add a couple of lin=
es to
> the manual about this service?
Sure, I'll do that :)

>=20
> Otherwise LGTM!
>=20
> Thanks,
> Ludo=E2=80=99.