From: Leo Famulari <leo@famulari.name>
To: Alex Vong <alexvong1995@gmail.com>
Cc: 30378@debbugs.gnu.org
Subject: [bug#30378] [PATCH] gnu: mpv: Fix CVE-2018-6360.
Date: Wed, 7 Feb 2018 21:44:17 -0500 [thread overview]
Message-ID: <20180208024417.GB16980@jasmine.lan> (raw)
In-Reply-To: <87tvuts33b.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
On Wed, Feb 07, 2018 at 02:53:12PM +0800, Alex Vong wrote:
> Tags: security
>
> Hello,
>
> This patch fixes CVE-2018-6360, which is about mpv maybe get tricked
> into playing unsafe url returned by youtube-dl.
> From 2a6538067bdad659672f1d19811bad8a5b8d9d56 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Wed, 7 Feb 2018 14:39:40 +0800
> Subject: [PATCH] gnu: mpv: Fix CVE-2018-6360.
>
> * gnu/packages/patches/mpv-CVE-2018-6360-1.patch,
> gnu/packages/patches/mpv-CVE-2018-6360-2.patch,
> gnu/packages/patches/mpv-CVE-2018-6360-3.patch: New files.
> * gnu/local.mk (dist_patch_DATA): Add them.
> * gnu/packages/video.scm (mpv)[source]: Use them.
Thank you very much for putting this patch together!
I noticed that the person who fixed the bug upstream said that 4 commits
were needed [0], but this patch (and Debian's and Nix's) are missing the
first in that person's list, 828bd2963cd10.
I'm going to ask upstream to clarify but, in the meantime, do you know
why this patch is not included?
[0]
https://github.com/mpv-player/mpv/issues/5456#issuecomment-362442132
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-08 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 6:53 [bug#30378] [PATCH] gnu: mpv: Fix CVE-2018-6360 Alex Vong
2018-02-07 6:59 ` Alex Vong
2018-02-08 2:44 ` Leo Famulari [this message]
2018-02-08 5:53 ` Alex Vong
2018-02-08 19:16 ` Leo Famulari
2018-02-08 20:19 ` bug#30378: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208024417.GB16980@jasmine.lan \
--to=leo@famulari.name \
--cc=30378@debbugs.gnu.org \
--cc=alexvong1995@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).