From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejWZZ-0007Px-I2 for guix-patches@gnu.org; Wed, 07 Feb 2018 15:44:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejWZW-0007Qa-FX for guix-patches@gnu.org; Wed, 07 Feb 2018 15:44:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:53811) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejWZW-0007QM-BO for guix-patches@gnu.org; Wed, 07 Feb 2018 15:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ejWZV-0003FJ-Uy for guix-patches@gnu.org; Wed, 07 Feb 2018 15:44:01 -0500 Subject: [bug#30380] gnu: Add dolphin-emulator. Resent-Message-ID: Date: Wed, 7 Feb 2018 21:43:53 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20180207214353.36366a2c@alma-ubu> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/t5JAjH.UtdTbGS3=F+CkI3a"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: "Thompson, David" Cc: 30380@debbugs.gnu.org --Sig_/t5JAjH.UtdTbGS3=F+CkI3a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 7 Feb 2018 11:58:02 -0500 "Thompson, David" wrote: > Here a couple of patches that add the Dolphin emulator. I used a Git > snapshot because the project goes *years* between releasing official > source tarballs while at the same time directing users to use binaries > built from the latest commit in their Git repo, so I think packaging > the Git source aligns best with what a Dolphin user would expect. >=20 > - Dave Hi Dave, I haven't done a full review, here are some things I noticed: * License is GPLv2+, not only v2. * dolphin/Data/Sys/GC/font_*.bin: Licensed under ASL2.0. * The homepage states this package is only available for x86_64. If that is true, add a line like this to your package: (supported-systems '("x86_64-linux")) * dolphin/Installer/dxredist/ contains (Windows) binaries. Remove with a snippet. * Remove dolphin/Externals in a snippet. Or at least those that you have added as dependencies. * There are binaries in the distribution: dolphin/Data/Sys/GC/dsp_coef.bin and dsp_rom.bin The commit message says something like "based off of observed effects on the virtual machine", but still this is binaray. Or is there some way of building this from commented assembly? Here is the full commit message: https://github.com/dolphin-emu/dolphin/commit/e3531d17d700339828d7bab192c= 66fba5fcbac86 * Finally, doesn't this encourage people to use non-free software, i.e. the original manufacturers game discs? Or is there any free software implementation running on this emulator? Bj=C3=B6rn --Sig_/t5JAjH.UtdTbGS3=F+CkI3a Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlp7ZQoACgkQvyhstlk+X/0f6QCgiEtvZ2snCD0O/B8PMsna0qQe ZT4An28fto2D/4Fsh1vEsrjajWn5VJWz =++0N -----END PGP SIGNATURE----- --Sig_/t5JAjH.UtdTbGS3=F+CkI3a--