From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eijx4-00025H-IE
	for guix-patches@gnu.org; Mon, 05 Feb 2018 11:49:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eijx0-00070Q-LP
	for guix-patches@gnu.org; Mon, 05 Feb 2018 11:49:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:51060)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eijx0-0006zS-Fi
	for guix-patches@gnu.org; Mon, 05 Feb 2018 11:49:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eijx0-0005yD-6l
	for guix-patches@gnu.org; Mon, 05 Feb 2018 11:49:02 -0500
Subject: [bug#30358] [PATCH] gnu: Add gpxsee.
Resent-Message-ID: <handler.30358.B30358.151784928522878@debbugs.gnu.org>
Date: Mon, 5 Feb 2018 17:47:57 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180205174757.11e2c71a@scratchpost.org>
In-Reply-To: <20180205142108.22320-1-m.othacehe@gmail.com>
References: <20180205142108.22320-1-m.othacehe@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 30358@debbugs.gnu.org

Hi Mathieu,

On Mon,  5 Feb 2018 15:21:08 +0100
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> +             (for-each (lambda (file)
> +                         (system* "lrelease" file))
> +                       (find-files "lang" "\\.ts"))

Please add comment that that's for translation.

> +             (substitute* "src/config.h"
> +               (("/usr/share/gpxsee")
> +                (string-append
> +                 (assoc-ref outputs "out") "/share/gpxsee/")))

Why once with, once without slash at the end?

> +             (zero?
> +              (system* "qmake"
> +                       (string-append "PREFIX="
> +                                      (assoc-ref outputs "out"))))))

Please use "invoke".

> +    (synopsis "GPX file viewer and analyser")
> +    (description
> +     "GPXSee is a Qt-based GPS log file viewer and analyzer that supports GPX,
> +TCX, KML, FIT, IGC and NMEA files.")

"analyser" or "analyzer" ?

Otherwise LGTM!