[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

Hello Guix,

Licensecheck attempts to determine the license that applies to each file
passed to it, by searching the start of the file for text belonging to various
licenses.


Some notes while I've adopted `guix import cpan` produced packages:

- perl-b-hooks-op-check, perl-bareword-filehandles, perl-multidimensional had
  a perl-gtk-perl in native-inputs.

- perl-test-roo had a perl-bareword-filehandles in native-inputs.


An example of running licensecheck
--8<---------------cut here---------------start------------->8---
natsu@magnolia ~/src/guix-wip-licensecheck$ $(./pre-inst-env guix build licensecheck)/bin/licensecheck .
./.dir-locals.el: *No copyright* UNKNOWN
./.mailmap: *No copyright* UNKNOWN
./.version: *No copyright* UNKNOWN
./0000-cover-letter.patch: *No copyright* GENERATED FILE
./0001-gnu-Add-perl-test-filename.patch: UNKNOWN
./0002-gnu-Add-perl-path-iterator-rule.patch: UNKNOWN
./0003-gnu-Add-perl-pod-constants.patch: *No copyright* UNKNOWN
./0004-gnu-Add-perl-regexp-pattern.patch: *No copyright* UNKNOWN
./0005-gnu-Add-perl-regexp-pattern-license.patch: GPL
./0006-gnu-Add-perl-number-range.patch: *No copyright* UNKNOWN
./0007-gnu-Add-perl-string-copyright.patch: UNKNOWN
./0008-gnu-Add-perl-string-escape.patch: *No copyright* UNKNOWN
./0009-gnu-Add-perl-test-failwarnings.patch: *No copyright* UNKNOWN
./0010-gnu-Add-perl-data-section.patch: *No copyright* UNKNOWN
./0011-gnu-Add-perl-software-license.patch: UNKNOWN
./0012-gnu-Add-perl-extutils-depends.patch: *No copyright* UNKNOWN
./0013-gnu-Add-perl-b-hooks-op-check.patch: *No copyright* UNKNOWN
./0014-gnu-Add-perl-bareword-filehandles.patch: *No copyright* UNKNOWN
./0015-gnu-Add-perl-indirect.patch: *No copyright* UNKNOWN
./0016-gnu-Add-perl-lexical-sealrequirehints.patch: *No copyright* UNKNOWN
./0017-gnu-Add-perl-multidimensional.patch: *No copyright* UNKNOWN
./0018-gnu-Add-perl-test-roo.patch: *No copyright* UNKNOWN
./0019-gnu-Add-perl-universal-require.patch: *No copyright* UNKNOWN
./0020-gnu-Add-perl-strictures-2.patch: *No copyright* UNKNOWN
./0021-gnu-Add-licensecheck.patch: *No copyright* UNKNOWN
./ABOUT-NLS: *No copyright* UNKNOWN
./AUTHORS: *No copyright* GENERATED FILE
./CODE-OF-CONDUCT: *No copyright* UNKNOWN
./COPYING: UNKNOWN
./ChangeLog: *No copyright* UNKNOWN
./HACKING: FSF All Permissive
./INSTALL: FSF All Permissive
./Makefile: GPL (v3 or later) GENERATED FILE
./Makefile.am: GPL (v3 or later)
./Makefile.in: GPL (v3 or later) GENERATED FILE
./NEWS: FSF All Permissive
./README: *No copyright* UNKNOWN
./ROADMAP: FSF All Permissive
./THANKS: UNKNOWN
./TODO: FSF All Permissive
./aclocal.m4: GENERATED FILE
./berlin.guixsd.org.pub: *No copyright* UNKNOWN
./bootstrap: *No copyright* UNKNOWN
./config-daemon.ac: *No copyright* UNKNOWN
./config.log: *No copyright* GENERATED FILE
./config.status: *No copyright* GENERATED FILE
./configure: FSF Unlimited GENERATED FILE
./configure.ac: *No copyright* UNKNOWN
./d3.v3.js: BSD (3 clause)
./gnu.go: UNKNOWN
./gnu.scm: GPL (v3 or later)
./graph.js: GPL (v3 or later)
./guix-daemon: UNKNOWN
./guix-register: UNKNOWN
./guix.go: *No copyright* UNKNOWN
./guix.scm: GPL (v3 or later)
./hydra.gnu.org.pub: *No copyright* UNKNOWN
./libformat.a: UNKNOWN
./libstore.a: UNKNOWN
./libutil.a: UNKNOWN
./pre-inst-env: GPL (v3 or later)
./release.nix: GPL (v3 or later)
./test-env: GPL (v3 or later)
--8<---------------cut here---------------end--------------->8---

Oleg Pykhalov (21):
  gnu: Add perl-test-filename.
  gnu: Add perl-path-iterator-rule.
  gnu: Add perl-pod-constants.
  gnu: Add perl-regexp-pattern.
  gnu: Add perl-regexp-pattern-license.
  gnu: Add perl-number-range.
  gnu: Add perl-string-copyright.
  gnu: Add perl-string-escape.
  gnu: Add perl-test-failwarnings.
  gnu: Add perl-data-section.
  gnu: Add perl-software-license.
  gnu: Add perl-extutils-depends.
  gnu: Add perl-b-hooks-op-check.
  gnu: Add perl-bareword-filehandles.
  gnu: Add perl-indirect.
  gnu: Add perl-lexical-sealrequirehints.
  gnu: Add perl-multidimensional.
  gnu: Add perl-test-roo.
  gnu: Add perl-universal-require.
  gnu: Add perl-strictures-2.
  gnu: Add licensecheck.

 gnu/local.mk                |   1 +
 gnu/packages/license.scm    | 158 ++++++++++++++++++++
 gnu/packages/perl-check.scm |  73 ++++++++++
 gnu/packages/perl.scm       | 340 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 572 insertions(+)
 create mode 100644 gnu/packages/license.scm

-- 
2.15.1

[bug#30274] [PATCH 01/21] gnu: Add perl-test-filename.

[Oleg Pykhalov]

* gnu/packages/perl-check.scm (perl-test-filename): New public variable.
---
 gnu/packages/perl-check.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/perl-check.scm b/gnu/packages/perl-check.scm
index cbb2138a6..5a0fa6524 100644
--- a/gnu/packages/perl-check.scm
+++ b/gnu/packages/perl-check.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2017 Christopher Baines <mail@cbaines.net>
 ;;; Copyright © 2017 Petter <petter@mykolab.ch>
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Oleg Pykhalov <go.wigust@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -456,6 +457,28 @@ testing exception-throwing code with about the same amount of typing.")
 for testing.")
     (license perl-license)))
 
+(define-public perl-test-filename
+  (package
+    (name "perl-test-filename")
+    (version "0.03")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Test-Filename-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1gpw4mjw68gnby8s4cifvbz6g2923xsc189jkw9d27i8qv20qiba"))))
+    (build-system perl-build-system)
+    (propagated-inputs
+     `(("perl-path-tiny" ,perl-path-tiny)))
+    (home-page "http://search.cpan.org/dist/Test-Filename/")
+    (synopsis "Portable filename comparison")
+    (description "Test::Filename provides functions to convert all path
+separators automatically.")
+    (license asl2.0)))
+
 (define-public perl-test-files
   (package
     (name "perl-test-files")
-- 
2.15.1

[bug#30274] [PATCH 02/21] gnu: Add perl-path-iterator-rule.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-path-iterator-rule): New public variable.
---
 gnu/packages/perl.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index f79a11f76..0894144f9 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2017 Christopher Allan Webber <cwebber@dustycloud.org>
+;;; Copyright © 2018 Oleg Pykhalov <go.wigust@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8810,3 +8811,53 @@ till 5pm\" and \"on the second Tuesday of the month\" and \"between 4pm and
 4:15pm\" and \"in the first half of each minute\" and \"in January of
 1998\".")
     (license perl-license)))
+
+(define-public perl-path-iterator-rule
+  (package
+    (name "perl-path-iterator-rule")
+    (version "1.012")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Path-Iterator-Rule-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1z76avwvwgv4bw28kzx79mmb4449s5l345sn0wljq3dbf4wqigd1"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-file-pushd" ,perl-file-pushd)
+       ("perl-path-tiny" ,perl-path-tiny)
+       ("perl-test-deep" ,perl-test-deep)
+       ("perl-test-filename" ,perl-test-filename)))
+    (propagated-inputs
+     `(("perl-number-compare" ,perl-number-compare)
+       ("perl-text-glob" ,perl-text-glob)
+       ("perl-try-tiny" ,perl-try-tiny)))
+    (home-page "http://search.cpan.org/dist/Path-Iterator-Rule/")
+    (synopsis "Iterative, recursive file finder")
+    (description "Path::Iterator::Rule iterates over files and directories to
+identify ones matching a user-defined set of rules.  The API is based heavily
+on File::Find::Rule, but with more explicit distinction between matching rules
+and options that influence how directories are searched.  A
+Path::Iterator::Rule object is a collection of rules (match criteria) with
+methods to add additional criteria.  Options that control directory traversal
+are given as arguments to the method that generates an iterator.
+
+A summary of features for comparison to other file finding modules:
+
+@itemize
+@item provides many helper methods for specifying rules
+@item offers (lazy) iterator and flattened list interfaces
+@item custom rules implemented with callbacks
+@item breadth-first (default) or pre- or post-order depth-first searching
+@item follows symlinks (by default, but can be disabled)
+@item directories visited only once (no infinite loop; can be disabled)
+@item doesn't chdir during operation
+@item provides an API for extensions
+@end itemize
+
+As a convenience, the PIR module is an empty subclass of this one that is less
+arduous to type for one-liners.")
+    (license asl2.0)))
-- 
2.15.1

[bug#30274] [PATCH 03/21] gnu: Add perl-pod-constants.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-pod-constants): New public variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 0894144f9..b75dceb1c 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -8861,3 +8861,29 @@ A summary of features for comparison to other file finding modules:
 As a convenience, the PIR module is an empty subclass of this one that is less
 arduous to type for one-liners.")
     (license asl2.0)))
+
+(define-public perl-pod-constants
+  (package
+    (name "perl-pod-constants")
+    (version "0.19")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MG/MGV/Pod-Constants-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1njgr2zly9nrwvfrjhgk9dqq48as1pmbb2rs4bh3irvla75v7azg"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Pod-Constants/")
+    (synopsis "Include constants from POD")
+    (description "This module allows you to specify those constants that
+should be documented in your POD, and pull them out a run time in a fairly
+arbitrary fashion.
+
+Pod::Constants uses Pod::Parser to do the parsing of the source file. It has
+to open the source file it is called from, and does so directly either by
+lookup in %INC or by assuming it is $0 if the caller is @code{main}
+(or it can't find %INC{caller()}).")
+    (license artistic2.0)))
-- 
2.15.1

[bug#30274] [PATCH 04/21] gnu: Add perl-regexp-pattern.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-regexp-pattern): New public variable.
---
 gnu/packages/perl.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index b75dceb1c..e2d6a294b 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -8887,3 +8887,25 @@ to open the source file it is called from, and does so directly either by
 lookup in %INC or by assuming it is $0 if the caller is @code{main}
 (or it can't find %INC{caller()}).")
     (license artistic2.0)))
+
+(define-public perl-regexp-pattern
+  (package
+    (name "perl-regexp-pattern")
+    (version "0.1.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/P/PE/PERLANCAR/Regexp-Pattern-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0rwpl6dxd1yl2ng3d4jdy68jz3mggmdl35rphrw1x619sm1aa876"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-exception" ,perl-test-exception)))
+    (home-page "http://search.cpan.org/dist/Regexp-Pattern/")
+    (synopsis "Collection of regexp patterns")
+    (description "Regexp::Pattern is a convention for organizing reusable
+regexp patterns in modules.")
+    (license (package-license perl))))
-- 
2.15.1

[bug#30274] [PATCH 05/21] gnu: Add perl-regexp-pattern-license.

[Oleg Pykhalov]

* gnu/packages/license.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add this.
---
 gnu/local.mk             |  1 +
 gnu/packages/license.scm | 57 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 gnu/packages/license.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 80d6a8d4c..00025b317 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -248,6 +248,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/libffcall.scm			\
   %D%/packages/libffi.scm			\
   %D%/packages/libftdi.scm			\
+  %D%/packages/license.scm			\
   %D%/packages/calendar.scm			\
   %D%/packages/libidn.scm			\
   %D%/packages/libphidget.scm			\
diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
new file mode 100644
index 000000000..e5bbe9748
--- /dev/null
+++ b/gnu/packages/license.scm
@@ -0,0 +1,57 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2018 Oleg Pykhalov <go.wigust@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages license)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system perl)
+  #:use-module (gnu packages perl)
+  #:use-module (gnu packages perl-check))
+
+;;;
+;;; Please: Try to add new module packages in alphabetic order.
+;;;
+
+(define-public perl-regexp-pattern-license
+  (package
+    (name "perl-regexp-pattern-license")
+    (version "3.0.31")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/J/JO/JONASS/Regexp-Pattern-License-"
+             "v" version ".tar.gz"))
+       (sha256
+        (base32
+         "1cp96rf3256bdsm3rmw068ngy2b3zip2dz1znpbplnsnxh9rb2q6"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-regexp-pattern" ,perl-regexp-pattern)
+       ("perl-test-exception" ,perl-test-exception)))
+    (propagated-inputs
+     `(("perl-strictures" ,perl-strictures)))
+    (home-page "http://search.cpan.org/dist/Regexp-Pattern-License/")
+    (synopsis "Regular expressions for legal licenses")
+    (description "Regexp::Pattern::License provides a hash of regular
+expression patterns related to legal software licenses.
+
+Regexp::Pattern is a convention for organizing reusable regex patterns.")
+    (license gpl3+)))
-- 
2.15.1

[bug#30274] [PATCH 06/21] gnu: Add perl-number-range.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-number-range): New public variable.
---
 gnu/packages/perl.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index e2d6a294b..991fefe4f 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6026,6 +6026,26 @@ collector daemon in use at Etsy.com.")
 subroutine, which you can call with a value to be tested against.")
     (license (package-license perl))))
 
+(define-public perl-number-range
+  (package
+    (name "perl-number-range")
+    (version "0.12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/L/LA/LARRYSH/Number-Range-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0999xvs3w2xprs14q4shqndjf2m6mzvhzdljgr61ddjaqhd84gj3"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Number-Range/")
+    (synopsis "Perl extension defining ranges of numbers")
+    (description "Number::Range is an object-oriented interface to test if a
+number exists in a given range, and to be able to manipulate the range.")
+    (license (package-license perl))))
+
 (define-public perl-object-signature
   (package
     (name "perl-object-signature")
-- 
2.15.1

[bug#30274] [PATCH 07/21] gnu: Add perl-string-copyright.

[Oleg Pykhalov]

* gnu/packages/license.scm (perl-string-copyright): New public variable.
---
 gnu/packages/license.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
index e5bbe9748..d186ad7de 100644
--- a/gnu/packages/license.scm
+++ b/gnu/packages/license.scm
@@ -55,3 +55,27 @@ expression patterns related to legal software licenses.
 
 Regexp::Pattern is a convention for organizing reusable regex patterns.")
     (license gpl3+)))
+
+(define-public perl-string-copyright
+  (package
+    (name "perl-string-copyright")
+    (version "0.003005")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/J/JO/JONASS/String-Copyright-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "12c6x4c10gr46ryc3dpwgfi6wggmgy4a1ls2hwhcpdm3wvzy5619"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-number-range" ,perl-number-range)))
+    (propagated-inputs
+     `(("perl-exporter-tiny" ,perl-exporter-tiny)))
+    (home-page "http://search.cpan.org/dist/String-Copyright/")
+    (synopsis "Representation of text-based copyright statements")
+    (description "String::Copyright Parses common styles of copyright
+statements and serializes in normalized format.")
+    (license gpl3+)))
-- 
2.15.1

[bug#30274] [PATCH 08/21] gnu: Add perl-string-escape.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-string-escape): New public variable.
---
 gnu/packages/perl.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 991fefe4f..7fc435551 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6913,6 +6913,28 @@ run from within a source-controlled directory.")
 CamelCase and back again.")
     (license (package-license perl))))
 
+(define-public perl-string-escape
+  (package
+    (name "perl-string-escape")
+    (version "2010.002")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/E/EV/EVO/String-Escape-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "12ls7f7847i4qcikkp3skwraqvjphjiv2zxfhl5d49326f5myr7x"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/String-Escape/")
+    (synopsis "Backslash escapes, quoted phrase, word elision, etc.")
+    (description "This module provides a flexible calling interface to some
+frequently-performed string conversion functions, including applying and
+expanding standard C/Unix-style backslash escapes like \n and \t, wrapping and
+removing double-quotes, and truncating to fit within a desired length.")
+    (license (package-license perl))))
+
 (define-public perl-string-rewriteprefix
   (package
     (name "perl-string-rewriteprefix")
-- 
2.15.1

[bug#30274] [PATCH 09/21] gnu: Add perl-test-failwarnings.

[Oleg Pykhalov]

* gnu/packages/perl-check.scm (perl-test-failwarnings): New public variable.
---
 gnu/packages/perl-check.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/perl-check.scm b/gnu/packages/perl-check.scm
index 5a0fa6524..249997229 100644
--- a/gnu/packages/perl-check.scm
+++ b/gnu/packages/perl-check.scm
@@ -410,6 +410,28 @@ exception based code.  It is built with Test::Builder and plays happily with
 Test::More and friends.")
     (license perl-license)))
 
+(define-public perl-test-failwarnings
+  (package
+    (name "perl-test-failwarnings")
+    (version "0.008")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Test-FailWarnings-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0vx9chcp5x8m0chq574p9fnfckh5gl94j7904rh9v17n568fyd6s"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-capture-tiny" ,perl-capture-tiny)))
+    (home-page "http://search.cpan.org/dist/Test-FailWarnings/")
+    (synopsis "Add test failures if warnings are caught")
+    (description
+     "Test::FailWarnings adds test failures if warnings are caught.")
+    (license asl2.0)))
+
 (define-public perl-test-fatal
   (package
     (name "perl-test-fatal")
-- 
2.15.1

[bug#30274] [PATCH 10/21] gnu: Add perl-data-section.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-data-section): New public variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 7fc435551..49ef1e9a4 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -1813,6 +1813,32 @@ an \"unless\" regular expression.  If the text in question matches the
 like split on newlines unless newlines are embedded in quotes.")
     (license (package-license perl))))
 
+(define-public perl-data-section
+  (package
+    (name "perl-data-section")
+    (version "0.200007")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/R/RJ/RJBS/Data-Section-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "1pmlxca0a8sv2jjwvhwgqavq6iwys6kf457lby4anjp3f1dpx4yd"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-failwarnings" ,perl-test-failwarnings)))
+    (propagated-inputs
+     `(("perl-mro-compat" ,perl-mro-compat)
+       ("perl-sub-exporter" ,perl-sub-exporter)))
+    (home-page "http://search.cpan.org/dist/Data-Section/")
+    (synopsis "read multiple hunks of data out of your DATA section")
+    (description "This package provides a Perl library to read multiple hunks
+of data out of your DATA section.")
+    (license (package-license perl))))
+
 (define-public perl-data-stag
   (package
     (name "perl-data-stag")
-- 
2.15.1

[bug#30274] [PATCH 11/21] gnu: Add perl-software-license.

[Oleg Pykhalov]

* gnu/packages/license.scm (perl-software-license): New public variable.
---
 gnu/packages/license.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
index d186ad7de..37b5c7388 100644
--- a/gnu/packages/license.scm
+++ b/gnu/packages/license.scm
@@ -79,3 +79,27 @@ Regexp::Pattern is a convention for organizing reusable regex patterns.")
     (description "String::Copyright Parses common styles of copyright
 statements and serializes in normalized format.")
     (license gpl3+)))
+
+(define-public perl-software-license
+  (package
+    (name "perl-software-license")
+    (version "0.103013")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/L/LE/LEONT/Software-License-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1wqgh7vdlc966amlrq0b2szz18lnrl9rfh8wlf7v0hqg74vxjh96"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-try-tiny" ,perl-try-tiny)))
+    (propagated-inputs
+     `(("perl-data-section" ,perl-data-section)
+       ("perl-text-template" ,perl-text-template)))
+    (home-page "http://search.cpan.org/dist/Software-License/")
+    (synopsis "Templated software licenses")
+    (description "This package provides templated software licenses.")
+    (license (package-license perl))))
-- 
2.15.1

[bug#30274] [PATCH 12/21] gnu: Add perl-extutils-depends.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-extutils-depends): New public variable.
---
 gnu/packages/perl.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 49ef1e9a4..86a2f14e0 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -3030,6 +3030,30 @@ and alternative installers with the `installler` option.  But it's written in
 only about 40% as many lines of code and with zero non-core dependencies.")
     (license (package-license perl))))
 
+(define-public perl-extutils-depends
+  (package
+    (name "perl-extutils-depends")
+    (version "0.405")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/X/XA/XAOC/ExtUtils-Depends-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0b4ab9qmcihsfs2ajhn5qzg7nhazr68v3r0zvb7076smswd41mla"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-number-delta"
+        ,perl-test-number-delta)))
+    (home-page "http://search.cpan.org/dist/ExtUtils-Depends/")
+    (synopsis "Easily build XS extensions that depend on XS extensions")
+    (description "ExtUtils::Depends builds XS extensions that depend on XS
+extensions")
+    (license (package-license perl))))
+
 (define-public perl-extutils-installpaths
   (package
     (name "perl-extutils-installpaths")
-- 
2.15.1

[bug#30274] [PATCH 13/21] gnu: Add perl-b-hooks-op-check.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-b-hooks-op-check): New public variable.
---
 gnu/packages/perl.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 86a2f14e0..6ada5fe14 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -410,6 +410,27 @@ all known commands are checked.")
 compiling the surrounding scope.")
     (license (package-license perl))))
 
+(define-public perl-b-hooks-op-check
+  (package
+    (name "perl-b-hooks-op-check")
+    (version "0.22")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/E/ET/ETHER/B-Hooks-OP-Check-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1kfdv25gn6yik8jrwik4ajp99gi44s6idcvyyrzhiycyynzd3df7"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-extutils-depends" ,perl-extutils-depends)))
+    (home-page "http://search.cpan.org/dist/B-Hooks-OP-Check/")
+    (synopsis "Wrap OP check callbacks")
+    (description "This module allows you to wrap OP check callbacks.")
+    (license (package-license perl))))
+
 (define-public perl-b-keywords
   (package
     (name "perl-b-keywords")
-- 
2.15.1

[bug#30274] [PATCH 14/21] gnu: Add perl-bareword-filehandles.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-bareword-filehandles): New public variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 6ada5fe14..c3da2a618 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -344,6 +344,31 @@ autovivification for some constructs and optionally throws a warning or an
 error when it would have happened.")
     (license (package-license perl))))
 
+(define-public perl-bareword-filehandles
+  (package
+    (name "perl-bareword-filehandles")
+    (version "0.005")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/I/IL/ILMARI/bareword-filehandles-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0fdirls2pg7d6ymvlzzz59q3dy6hgh08k0qpr2mw51w127s8rav6"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-extutils-depends" ,perl-extutils-depends)))
+    (propagated-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-lexical-sealrequirehints" ,perl-lexical-sealrequirehints)))
+    (home-page "http://search.cpan.org/dist/bareword-filehandles/")
+    (synopsis "Disables bareword filehandles")
+    (description "bareword::filehandles disables bareword filehandles.")
+    (license (package-license perl))))
+
 (define-public perl-base
   (package
     (name "perl-base")
-- 
2.15.1

[bug#30274] [PATCH 15/21] gnu: Add perl-indirect.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-indirect): New public variable.
---
 gnu/packages/perl.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index c3da2a618..3c85e8e9f 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -3954,6 +3954,26 @@ dependencies for CPAN distributions.  These dependencies get bundled into the
 inc directory within a distribution and are used by Makefile.PL or Build.PL.")
     (license asl2.0)))
 
+(define-public perl-indirect
+  (package
+    (name "perl-indirect")
+    (version "0.38")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/V/VP/VPIT/indirect-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "13k5a8p903m8x3pcv9qqkzvnb8gpgq36cr3dvn3lk1ngsi9w5ydy"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/indirect/")
+    (synopsis "Lexically warn about using the indirect method call syntax.")
+    (description
+     "Indirect warns about using the indirect method call syntax.")
+    (license (package-license perl))))
+
 (define-public perl-io-captureoutput
   (package
     (name "perl-io-captureoutput")
-- 
2.15.1

[bug#30274] [PATCH 16/21] gnu: Add perl-lexical-sealrequirehints.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-lexical-sealrequirehints): New public variable.
---
 gnu/packages/perl.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 3c85e8e9f..6a76dc996 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -4292,6 +4292,29 @@ either uses the first module it finds or throws an error.")
 versa.")
     (license (package-license perl))))
 
+(define-public perl-lexical-sealrequirehints
+  (package
+    (name "perl-lexical-sealrequirehints")
+    (version "0.011")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/Z/ZE/ZEFRAM/Lexical-SealRequireHints-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0fh1arpr0hsj7skbn97yfvbk22pfcrpcvcfs15p5ss7g338qx4cy"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-module-build" ,perl-module-build)))
+    (home-page "http://search.cpan.org/dist/Lexical-SealRequireHints/")
+    (synopsis "prevent leakage of lexical hints")
+    (description
+     "Lexical::SealRequireHints prevents leakage of lexical hints")
+    (license (package-license perl))))
+
 (define-public perl-log-any
   (package
     (name "perl-log-any")
-- 
2.15.1

[bug#30274] [PATCH 17/21] gnu: Add perl-multidimensional.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-multidimensional): New public variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 6a76dc996..be89ee2b7 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -5993,6 +5993,32 @@ Certificate Authority certificates in a form that can be consumed by modules
 and libraries based on OpenSSL.")
     (license mpl2.0)))
 
+(define-public perl-multidimensional
+  (package
+    (name "perl-multidimensional")
+    (version "0.013")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/I/IL/ILMARI/multidimensional-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "02p5zv68i39hnkmzzxsk1fi7xy56pfcsslrd7yqwzhq74czcw81x"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-extutils-depends" ,perl-extutils-depends)))
+    (propagated-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-lexical-sealrequirehints" ,perl-lexical-sealrequirehints)))
+    (home-page "http://search.cpan.org/dist/multidimensional/")
+    (synopsis "Disable multidimensional array emulation")
+    (description
+     "Multidimensional disables multidimensional array emulation.")
+    (license (package-license perl))))
+
 (define-public perl-mro-compat
   (package
     (name "perl-mro-compat")
-- 
2.15.1

[bug#30274] [PATCH 18/21] gnu: Add perl-test-roo.

[Oleg Pykhalov]

* gnu/packages/perl-check.scm (perl-test-roo): New public variable.
---
 gnu/packages/perl-check.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/perl-check.scm b/gnu/packages/perl-check.scm
index 249997229..09ddaa242 100644
--- a/gnu/packages/perl-check.scm
+++ b/gnu/packages/perl-check.scm
@@ -973,6 +973,34 @@ cannot connect to the specified hosts and ports, the exception is caught and
 reported, and the tests skipped.")
     (license perl-license)))
 
+(define-public perl-test-roo
+  (package
+    (name "perl-test-roo")
+    (version "1.004")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Test-Roo-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1mnym49j1lj7gzylma5b6nr4vp75rmgz2v71904v01xmxhy9l4i1"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-capture-tiny" ,perl-capture-tiny)))
+    (propagated-inputs
+     `(("perl-indirect" ,perl-indirect)
+       ("perl-moo" ,perl-moo)
+       ("perl-moox-types-mooselike" ,perl-moox-types-mooselike)
+       ("perl-multidimensional" ,perl-multidimensional)
+       ("perl-strictures" ,perl-strictures)
+       ("perl-sub-install" ,perl-sub-install)))
+    (home-page "http://search.cpan.org/dist/Test-Roo/")
+    (synopsis "Composable, reusable tests with roles and Moo")
+    (description "Test::Roo provides composable, reusable tests with roles.")
+    (license asl2.0)))
+
 (define-public perl-test-script
   (package
     (name "perl-test-script")
-- 
2.15.1

[bug#30274] [PATCH 19/21] gnu: Add perl-universal-require.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-universal-require): New public variable.
---
 gnu/packages/perl.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index be89ee2b7..82ed20825 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -8537,6 +8537,27 @@ UNIVERSAL::can() as a function, which it is not.")
 UNIVERSAL::isa as a function.")
     (license (package-license perl))))
 
+(define-public perl-universal-require
+  (package
+    (name "perl-universal-require")
+    (version "0.18")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/N/NE/NEILB/UNIVERSAL-require-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1v9qdg80ng6dzyzs7cn8sb6mn8ym042i32lcnpd478b7g6l3d9xj"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/UNIVERSAL-require/")
+    (synopsis "Require modules from a variable")
+    (description "This module lets you require other modules where the module
+name is in a variable, something you can't do with the @code{require}
+built-in.")
+    (license (package-license perl))))
+
 (define-public perl-variable-magic
   (package
     (name "perl-variable-magic")
-- 
2.15.1

[bug#30274] [PATCH 20/21] gnu: Add perl-strictures-2.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-strictures-2): New public variable.
---
 gnu/packages/perl.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 82ed20825..00fa43698 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -7049,6 +7049,19 @@ on the length of the size.")
 run from within a source-controlled directory.")
     (license (package-license perl))))
 
+(define-public perl-strictures-2
+  (package
+    (inherit perl-strictures)
+    (version "2.000003")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/H/HA/HAARG/"
+                           "strictures-" version ".tar.gz"))
+       (sha256
+        (base32
+         "08mgvf1d2651gsg3jgjfs13878ndqa4ji8vfsda9f7jjd84ymy17"))))))
+
 (define-public perl-string-camelcase
   (package
     (name "perl-string-camelcase")
-- 
2.15.1

[bug#30274] [PATCH 21/21] gnu: Add licensecheck.

[Oleg Pykhalov]

* gnu/packages/license.scm (licensecheck): New public variable.
---
 gnu/packages/license.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
index 37b5c7388..ca1183f46 100644
--- a/gnu/packages/license.scm
+++ b/gnu/packages/license.scm
@@ -103,3 +103,56 @@ statements and serializes in normalized format.")
     (synopsis "Templated software licenses")
     (description "This package provides templated software licenses.")
     (license (package-license perl))))
+
+(define-public licensecheck
+  (package
+    (name "licensecheck")
+    (version "3.0.31")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://cpan/authors/id/J/JO/JONASS/App-Licensecheck-"
+                    "v" version ".tar.gz"))
+              (sha256
+               (base32
+                "12970mfcnqjil1p09s137nvqxjiqsjypivby8yhp163wl06i2s51"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-software-license" ,perl-software-license)
+       ("perl-test-requires" ,perl-test-requires)
+       ("perl-test-roo" ,perl-test-roo)
+       ("perl-test-script" ,perl-test-script)
+       ("perl-universal-require" ,perl-universal-require)
+       ("perl-number-range" ,perl-number-range)))
+    (propagated-inputs
+     `(("perl-getopt-long-descriptive" ,perl-getopt-long-descriptive)
+       ("perl-moo" ,perl-moo)
+       ("perl-namespace-clean" ,perl-namespace-clean)
+       ("perl-path-iterator-rule" ,perl-path-iterator-rule)
+       ("perl-path-tiny" ,perl-path-tiny)
+       ("perl-pod-constants" ,perl-pod-constants)
+       ("perl-regexp-pattern-license" ,perl-regexp-pattern-license)
+       ("perl-sort-key" ,perl-sort-key)
+       ("perl-strictures" ,perl-strictures-2)
+       ("perl-string-copyright" ,perl-string-copyright)
+       ("perl-string-escape" ,perl-string-escape)
+       ("perl-try-tiny" ,perl-try-tiny)
+       ("perl-module-runtime" ,perl-module-runtime)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (perllib (string-append out "/lib/perl5/site_perl/"
+                                            ,(package-version perl))))
+               (wrap-program (string-append out "/bin/licensecheck")
+                 `("PERL5LIB" ":"
+                   prefix (,(string-append perllib ":" (getenv "PERL5LIB")))))
+               #t))))))
+    (home-page "http://search.cpan.org/dist/App-Licensecheck/")
+    (synopsis "License checker for source files")
+    (description "Licensecheck attempts to determine the license that applies
+to each file passed to it, by searching the start of the file for text
+belonging to various licenses.")
+    (license (package-license perl))))
-- 
2.15.1

[bug#30274] [PATCH 21/21] gnu: Add licensecheck.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> * gnu/packages/license.scm (licensecheck): New public variable.
> ---
>  gnu/packages/license.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>
> diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
> index 37b5c7388..ca1183f46 100644
> --- a/gnu/packages/license.scm
> +++ b/gnu/packages/license.scm
> @@ -103,3 +103,56 @@ statements and serializes in normalized format.")
>      (synopsis "Templated software licenses")
>      (description "This package provides templated software licenses.")
>      (license (package-license perl))))
> +
> +(define-public licensecheck
> +  (package
> +    (name "licensecheck")
> +    (version "3.0.31")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://cpan/authors/id/J/JO/JONASS/App-Licensecheck-"
> +                    "v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "12970mfcnqjil1p09s137nvqxjiqsjypivby8yhp163wl06i2s51"))))
> +    (build-system perl-build-system)
> +    (native-inputs
> +     `(("perl-software-license" ,perl-software-license)
> +       ("perl-test-requires" ,perl-test-requires)
> +       ("perl-test-roo" ,perl-test-roo)
> +       ("perl-test-script" ,perl-test-script)
> +       ("perl-universal-require" ,perl-universal-require)
> +       ("perl-number-range" ,perl-number-range)))
> +    (propagated-inputs
> +     `(("perl-getopt-long-descriptive" ,perl-getopt-long-descriptive)
> +       ("perl-moo" ,perl-moo)
> +       ("perl-namespace-clean" ,perl-namespace-clean)
> +       ("perl-path-iterator-rule" ,perl-path-iterator-rule)
> +       ("perl-path-tiny" ,perl-path-tiny)
> +       ("perl-pod-constants" ,perl-pod-constants)
> +       ("perl-regexp-pattern-license" ,perl-regexp-pattern-license)
> +       ("perl-sort-key" ,perl-sort-key)
> +       ("perl-strictures" ,perl-strictures-2)

I'll try to build perl-moo version 2 which should be build with
perl-strictures version 2 in the native-inputs, so we could install
licensecheck to a user's profile.

[...]

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#30274] [PATCH 00/24] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

Apologies for previous patch series without `guix package -i` test.

`guix lint` doesn't show any warnings.
--8<---------------cut here---------------start------------->8---
./pre-inst-env env GUIX_PACKAGE_PATH= guix lint perl-test-filename perl-path-iterator-rule perl-pod-constants perl-regexp-pattern perl-regexp-pattern-license perl-number-range perl-string-copyright perl-string-escape perl-test-failwarnings perl-data-section perl-software-license perl-extutils-depends perl-b-hooks-op-check perl-bareword-filehandles perl-indirect perl-lexical-sealrequirehints perl-multidimensional perl-test-roo perl-universal-require perl-sub-quote licensecheck
--8<---------------cut here---------------end--------------->8---

I don't lint perl-strictures-2 perl-role-tiny-2 perl-moo-2.

`guix package -i licensecheck` succeeds.

Oleg Pykhalov (24):
  gnu: Add perl-test-filename.
  gnu: Add perl-path-iterator-rule.
  gnu: Add perl-pod-constants.
  gnu: Add perl-regexp-pattern.
  gnu: Add perl-regexp-pattern-license.
  gnu: Add perl-number-range.
  gnu: Add perl-string-copyright.
  gnu: Add perl-string-escape.
  gnu: Add perl-test-failwarnings.
  gnu: Add perl-data-section.
  gnu: Add perl-software-license.
  gnu: Add perl-extutils-depends.
  gnu: Add perl-b-hooks-op-check.
  gnu: Add perl-bareword-filehandles.
  gnu: Add perl-indirect.
  gnu: Add perl-lexical-sealrequirehints.
  gnu: Add perl-multidimensional.
  gnu: Add perl-test-roo.
  gnu: Add perl-universal-require.
  gnu: Add perl-strictures-2.
  gnu: Add perl-role-tiny-2.
  gnu: Add perl-sub-quote.
  gnu: Add perl-moo-2.
  gnu: Add licensecheck.

 gnu/local.mk                |   1 +
 gnu/packages/license.scm    | 159 +++++++++++++++++
 gnu/packages/perl-check.scm |  73 ++++++++
 gnu/packages/perl.scm       | 409 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 642 insertions(+)
 create mode 100644 gnu/packages/license.scm

-- 
2.15.1

[bug#30274] [PATCH 01/24] gnu: Add perl-test-filename.

[Oleg Pykhalov]

* gnu/packages/perl-check.scm (perl-test-filename): New public variable.
---
 gnu/packages/perl-check.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/perl-check.scm b/gnu/packages/perl-check.scm
index cbb2138a6..5a0fa6524 100644
--- a/gnu/packages/perl-check.scm
+++ b/gnu/packages/perl-check.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2017 Christopher Baines <mail@cbaines.net>
 ;;; Copyright © 2017 Petter <petter@mykolab.ch>
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Oleg Pykhalov <go.wigust@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -456,6 +457,28 @@ testing exception-throwing code with about the same amount of typing.")
 for testing.")
     (license perl-license)))
 
+(define-public perl-test-filename
+  (package
+    (name "perl-test-filename")
+    (version "0.03")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Test-Filename-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1gpw4mjw68gnby8s4cifvbz6g2923xsc189jkw9d27i8qv20qiba"))))
+    (build-system perl-build-system)
+    (propagated-inputs
+     `(("perl-path-tiny" ,perl-path-tiny)))
+    (home-page "http://search.cpan.org/dist/Test-Filename/")
+    (synopsis "Portable filename comparison")
+    (description "Test::Filename provides functions to convert all path
+separators automatically.")
+    (license asl2.0)))
+
 (define-public perl-test-files
   (package
     (name "perl-test-files")
-- 
2.15.1

[bug#30274] [PATCH 02/24] gnu: Add perl-path-iterator-rule.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-path-iterator-rule): New public variable.
---
 gnu/packages/perl.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index f79a11f76..0894144f9 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2017 Christopher Allan Webber <cwebber@dustycloud.org>
+;;; Copyright © 2018 Oleg Pykhalov <go.wigust@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8810,3 +8811,53 @@ till 5pm\" and \"on the second Tuesday of the month\" and \"between 4pm and
 4:15pm\" and \"in the first half of each minute\" and \"in January of
 1998\".")
     (license perl-license)))
+
+(define-public perl-path-iterator-rule
+  (package
+    (name "perl-path-iterator-rule")
+    (version "1.012")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Path-Iterator-Rule-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1z76avwvwgv4bw28kzx79mmb4449s5l345sn0wljq3dbf4wqigd1"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-file-pushd" ,perl-file-pushd)
+       ("perl-path-tiny" ,perl-path-tiny)
+       ("perl-test-deep" ,perl-test-deep)
+       ("perl-test-filename" ,perl-test-filename)))
+    (propagated-inputs
+     `(("perl-number-compare" ,perl-number-compare)
+       ("perl-text-glob" ,perl-text-glob)
+       ("perl-try-tiny" ,perl-try-tiny)))
+    (home-page "http://search.cpan.org/dist/Path-Iterator-Rule/")
+    (synopsis "Iterative, recursive file finder")
+    (description "Path::Iterator::Rule iterates over files and directories to
+identify ones matching a user-defined set of rules.  The API is based heavily
+on File::Find::Rule, but with more explicit distinction between matching rules
+and options that influence how directories are searched.  A
+Path::Iterator::Rule object is a collection of rules (match criteria) with
+methods to add additional criteria.  Options that control directory traversal
+are given as arguments to the method that generates an iterator.
+
+A summary of features for comparison to other file finding modules:
+
+@itemize
+@item provides many helper methods for specifying rules
+@item offers (lazy) iterator and flattened list interfaces
+@item custom rules implemented with callbacks
+@item breadth-first (default) or pre- or post-order depth-first searching
+@item follows symlinks (by default, but can be disabled)
+@item directories visited only once (no infinite loop; can be disabled)
+@item doesn't chdir during operation
+@item provides an API for extensions
+@end itemize
+
+As a convenience, the PIR module is an empty subclass of this one that is less
+arduous to type for one-liners.")
+    (license asl2.0)))
-- 
2.15.1

[bug#30274] [PATCH 03/24] gnu: Add perl-pod-constants.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-pod-constants): New public variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 0894144f9..2207b6d67 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -8861,3 +8861,29 @@ A summary of features for comparison to other file finding modules:
 As a convenience, the PIR module is an empty subclass of this one that is less
 arduous to type for one-liners.")
     (license asl2.0)))
+
+(define-public perl-pod-constants
+  (package
+    (name "perl-pod-constants")
+    (version "0.19")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MG/MGV/Pod-Constants-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1njgr2zly9nrwvfrjhgk9dqq48as1pmbb2rs4bh3irvla75v7azg"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Pod-Constants/")
+    (synopsis "Include constants from POD")
+    (description "This module allows you to specify those constants that
+should be documented in your POD, and pull them out a run time in a fairly
+arbitrary fashion.
+
+Pod::Constants uses Pod::Parser to do the parsing of the source file.  It has
+to open the source file it is called from, and does so directly either by
+lookup in %INC or by assuming it is $0 if the caller is @code{main}
+(or it can't find %INC{caller()}).")
+    (license artistic2.0)))
-- 
2.15.1

[bug#30274] [PATCH 04/24] gnu: Add perl-regexp-pattern.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-regexp-pattern): New public variable.
---
 gnu/packages/perl.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 2207b6d67..9a91ca8c5 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -8887,3 +8887,25 @@ to open the source file it is called from, and does so directly either by
 lookup in %INC or by assuming it is $0 if the caller is @code{main}
 (or it can't find %INC{caller()}).")
     (license artistic2.0)))
+
+(define-public perl-regexp-pattern
+  (package
+    (name "perl-regexp-pattern")
+    (version "0.1.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/P/PE/PERLANCAR/Regexp-Pattern-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0rwpl6dxd1yl2ng3d4jdy68jz3mggmdl35rphrw1x619sm1aa876"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-exception" ,perl-test-exception)))
+    (home-page "http://search.cpan.org/dist/Regexp-Pattern/")
+    (synopsis "Collection of regexp patterns")
+    (description "Regexp::Pattern is a convention for organizing reusable
+regexp patterns in modules.")
+    (license (package-license perl))))
-- 
2.15.1

[bug#30274] [PATCH 05/24] gnu: Add perl-regexp-pattern-license.

[Oleg Pykhalov]

* gnu/packages/license.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add this.
---
 gnu/local.mk             |  1 +
 gnu/packages/license.scm | 57 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 gnu/packages/license.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 80d6a8d4c..00025b317 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -248,6 +248,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/libffcall.scm			\
   %D%/packages/libffi.scm			\
   %D%/packages/libftdi.scm			\
+  %D%/packages/license.scm			\
   %D%/packages/calendar.scm			\
   %D%/packages/libidn.scm			\
   %D%/packages/libphidget.scm			\
diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
new file mode 100644
index 000000000..80bb8f6e1
--- /dev/null
+++ b/gnu/packages/license.scm
@@ -0,0 +1,57 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2018 Oleg Pykhalov <go.wigust@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages license)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system perl)
+  #:use-module (gnu packages perl)
+  #:use-module (gnu packages perl-check))
+
+;;;
+;;; Please: Try to add new module packages in alphabetic order.
+;;;
+
+(define-public perl-regexp-pattern-license
+  (package
+    (name "perl-regexp-pattern-license")
+    (version "v3.0.31")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/J/JO/JONASS/Regexp-Pattern-License-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1cp96rf3256bdsm3rmw068ngy2b3zip2dz1znpbplnsnxh9rb2q6"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-regexp-pattern" ,perl-regexp-pattern)
+       ("perl-test-exception" ,perl-test-exception)))
+    (propagated-inputs
+     `(("perl-strictures" ,perl-strictures-2)))
+    (home-page "http://search.cpan.org/dist/Regexp-Pattern-License/")
+    (synopsis "Regular expressions for legal licenses")
+    (description "Regexp::Pattern::License provides a hash of regular
+expression patterns related to legal software licenses.
+
+Regexp::Pattern is a convention for organizing reusable regex patterns.")
+    (license gpl3+)))
-- 
2.15.1

[bug#30274] [PATCH 06/24] gnu: Add perl-number-range.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-number-range): New public variable.
---
 gnu/packages/perl.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 9a91ca8c5..9aac61e0d 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6026,6 +6026,26 @@ collector daemon in use at Etsy.com.")
 subroutine, which you can call with a value to be tested against.")
     (license (package-license perl))))
 
+(define-public perl-number-range
+  (package
+    (name "perl-number-range")
+    (version "0.12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/L/LA/LARRYSH/Number-Range-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0999xvs3w2xprs14q4shqndjf2m6mzvhzdljgr61ddjaqhd84gj3"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Number-Range/")
+    (synopsis "Perl extension defining ranges of numbers")
+    (description "Number::Range is an object-oriented interface to test if a
+number exists in a given range, and to be able to manipulate the range.")
+    (license (package-license perl))))
+
 (define-public perl-object-signature
   (package
     (name "perl-object-signature")
-- 
2.15.1

[bug#30274] [PATCH 07/24] gnu: Add perl-string-copyright.

[Oleg Pykhalov]

* gnu/packages/license.scm (perl-string-copyright): New public variable.
---
 gnu/packages/license.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
index 80bb8f6e1..09a922842 100644
--- a/gnu/packages/license.scm
+++ b/gnu/packages/license.scm
@@ -55,3 +55,27 @@ expression patterns related to legal software licenses.
 
 Regexp::Pattern is a convention for organizing reusable regex patterns.")
     (license gpl3+)))
+
+(define-public perl-string-copyright
+  (package
+    (name "perl-string-copyright")
+    (version "0.003005")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/J/JO/JONASS/String-Copyright-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "12c6x4c10gr46ryc3dpwgfi6wggmgy4a1ls2hwhcpdm3wvzy5619"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-number-range" ,perl-number-range)))
+    (propagated-inputs
+     `(("perl-exporter-tiny" ,perl-exporter-tiny)))
+    (home-page "http://search.cpan.org/dist/String-Copyright/")
+    (synopsis "Representation of text-based copyright statements")
+    (description "String::Copyright Parses common styles of copyright
+statements and serializes in normalized format.")
+    (license gpl3+)))
-- 
2.15.1

[bug#30274] [PATCH 08/24] gnu: Add perl-string-escape.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-string-escape): New public variable.
---
 gnu/packages/perl.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 9aac61e0d..d1a54ab2f 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6913,6 +6913,28 @@ run from within a source-controlled directory.")
 CamelCase and back again.")
     (license (package-license perl))))
 
+(define-public perl-string-escape
+  (package
+    (name "perl-string-escape")
+    (version "2010.002")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/E/EV/EVO/String-Escape-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "12ls7f7847i4qcikkp3skwraqvjphjiv2zxfhl5d49326f5myr7x"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/String-Escape/")
+    (synopsis "Backslash escapes, quoted phrase, word elision, etc.")
+    (description "This module provides a flexible calling interface to some
+frequently-performed string conversion functions, including applying and
+expanding standard C/Unix-style backslash escapes like \n and \t, wrapping and
+removing double-quotes, and truncating to fit within a desired length.")
+    (license (package-license perl))))
+
 (define-public perl-string-rewriteprefix
   (package
     (name "perl-string-rewriteprefix")
-- 
2.15.1

[bug#30274] [PATCH 09/24] gnu: Add perl-test-failwarnings.

[Oleg Pykhalov]

* gnu/packages/perl-check.scm (perl-test-failwarnings): New public variable.
---
 gnu/packages/perl-check.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/perl-check.scm b/gnu/packages/perl-check.scm
index 5a0fa6524..249997229 100644
--- a/gnu/packages/perl-check.scm
+++ b/gnu/packages/perl-check.scm
@@ -410,6 +410,28 @@ exception based code.  It is built with Test::Builder and plays happily with
 Test::More and friends.")
     (license perl-license)))
 
+(define-public perl-test-failwarnings
+  (package
+    (name "perl-test-failwarnings")
+    (version "0.008")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Test-FailWarnings-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0vx9chcp5x8m0chq574p9fnfckh5gl94j7904rh9v17n568fyd6s"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-capture-tiny" ,perl-capture-tiny)))
+    (home-page "http://search.cpan.org/dist/Test-FailWarnings/")
+    (synopsis "Add test failures if warnings are caught")
+    (description
+     "Test::FailWarnings adds test failures if warnings are caught.")
+    (license asl2.0)))
+
 (define-public perl-test-fatal
   (package
     (name "perl-test-fatal")
-- 
2.15.1

[bug#30274] [PATCH 10/24] gnu: Add perl-data-section.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-data-section): New public variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index d1a54ab2f..4f5ff1b61 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -1813,6 +1813,32 @@ an \"unless\" regular expression.  If the text in question matches the
 like split on newlines unless newlines are embedded in quotes.")
     (license (package-license perl))))
 
+(define-public perl-data-section
+  (package
+    (name "perl-data-section")
+    (version "0.200007")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/R/RJ/RJBS/Data-Section-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "1pmlxca0a8sv2jjwvhwgqavq6iwys6kf457lby4anjp3f1dpx4yd"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-failwarnings" ,perl-test-failwarnings)))
+    (propagated-inputs
+     `(("perl-mro-compat" ,perl-mro-compat)
+       ("perl-sub-exporter" ,perl-sub-exporter)))
+    (home-page "http://search.cpan.org/dist/Data-Section/")
+    (synopsis "Read multiple hunks of data out of your DATA section")
+    (description "This package provides a Perl library to read multiple hunks
+of data out of your DATA section.")
+    (license (package-license perl))))
+
 (define-public perl-data-stag
   (package
     (name "perl-data-stag")
-- 
2.15.1

[bug#30274] [PATCH 11/24] gnu: Add perl-software-license.

[Oleg Pykhalov]

* gnu/packages/license.scm (perl-software-license): New public variable.
---
 gnu/packages/license.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
index 09a922842..774654f48 100644
--- a/gnu/packages/license.scm
+++ b/gnu/packages/license.scm
@@ -79,3 +79,27 @@ Regexp::Pattern is a convention for organizing reusable regex patterns.")
     (description "String::Copyright Parses common styles of copyright
 statements and serializes in normalized format.")
     (license gpl3+)))
+
+(define-public perl-software-license
+  (package
+    (name "perl-software-license")
+    (version "0.103013")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/L/LE/LEONT/Software-License-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1wqgh7vdlc966amlrq0b2szz18lnrl9rfh8wlf7v0hqg74vxjh96"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-try-tiny" ,perl-try-tiny)))
+    (propagated-inputs
+     `(("perl-data-section" ,perl-data-section)
+       ("perl-text-template" ,perl-text-template)))
+    (home-page "http://search.cpan.org/dist/Software-License/")
+    (synopsis "Templated software licenses")
+    (description "This package provides templated software licenses.")
+    (license (package-license perl))))
-- 
2.15.1

[bug#30274] [PATCH 12/24] gnu: Add perl-extutils-depends.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-extutils-depends): New public variable.
---
 gnu/packages/perl.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 4f5ff1b61..8cf465570 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -3030,6 +3030,30 @@ and alternative installers with the `installler` option.  But it's written in
 only about 40% as many lines of code and with zero non-core dependencies.")
     (license (package-license perl))))
 
+(define-public perl-extutils-depends
+  (package
+    (name "perl-extutils-depends")
+    (version "0.405")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/X/XA/XAOC/ExtUtils-Depends-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0b4ab9qmcihsfs2ajhn5qzg7nhazr68v3r0zvb7076smswd41mla"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-number-delta"
+        ,perl-test-number-delta)))
+    (home-page "http://search.cpan.org/dist/ExtUtils-Depends/")
+    (synopsis "Easily build XS extensions that depend on XS extensions")
+    (description "ExtUtils::Depends builds XS extensions that depend on XS
+extensions")
+    (license (package-license perl))))
+
 (define-public perl-extutils-installpaths
   (package
     (name "perl-extutils-installpaths")
-- 
2.15.1

[bug#30274] [PATCH 13/24] gnu: Add perl-b-hooks-op-check.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-b-hooks-op-check): New public variable.
---
 gnu/packages/perl.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 8cf465570..f5791615e 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -410,6 +410,27 @@ all known commands are checked.")
 compiling the surrounding scope.")
     (license (package-license perl))))
 
+(define-public perl-b-hooks-op-check
+  (package
+    (name "perl-b-hooks-op-check")
+    (version "0.22")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/E/ET/ETHER/B-Hooks-OP-Check-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1kfdv25gn6yik8jrwik4ajp99gi44s6idcvyyrzhiycyynzd3df7"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-extutils-depends" ,perl-extutils-depends)))
+    (home-page "http://search.cpan.org/dist/B-Hooks-OP-Check/")
+    (synopsis "Wrap OP check callbacks")
+    (description "This module allows you to wrap OP check callbacks.")
+    (license (package-license perl))))
+
 (define-public perl-b-keywords
   (package
     (name "perl-b-keywords")
-- 
2.15.1

[bug#30274] [PATCH 14/24] gnu: Add perl-bareword-filehandles.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-bareword-filehandles): New public variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index f5791615e..5c7d0c7e4 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -344,6 +344,31 @@ autovivification for some constructs and optionally throws a warning or an
 error when it would have happened.")
     (license (package-license perl))))
 
+(define-public perl-bareword-filehandles
+  (package
+    (name "perl-bareword-filehandles")
+    (version "0.005")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/I/IL/ILMARI/bareword-filehandles-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0fdirls2pg7d6ymvlzzz59q3dy6hgh08k0qpr2mw51w127s8rav6"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-extutils-depends" ,perl-extutils-depends)))
+    (propagated-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-lexical-sealrequirehints" ,perl-lexical-sealrequirehints)))
+    (home-page "http://search.cpan.org/dist/bareword-filehandles/")
+    (synopsis "Disables bareword filehandles")
+    (description "This module disables bareword filehandles.")
+    (license (package-license perl))))
+
 (define-public perl-base
   (package
     (name "perl-base")
-- 
2.15.1

[bug#30274] [PATCH 15/24] gnu: Add perl-indirect.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-indirect): New public variable.
---
 gnu/packages/perl.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 5c7d0c7e4..510f612b5 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -3954,6 +3954,26 @@ dependencies for CPAN distributions.  These dependencies get bundled into the
 inc directory within a distribution and are used by Makefile.PL or Build.PL.")
     (license asl2.0)))
 
+(define-public perl-indirect
+  (package
+    (name "perl-indirect")
+    (version "0.38")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/V/VP/VPIT/indirect-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "13k5a8p903m8x3pcv9qqkzvnb8gpgq36cr3dvn3lk1ngsi9w5ydy"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/indirect/")
+    (synopsis "Lexically warn about using the indirect method call syntax")
+    (description
+     "Indirect warns about using the indirect method call syntax.")
+    (license (package-license perl))))
+
 (define-public perl-io-captureoutput
   (package
     (name "perl-io-captureoutput")
-- 
2.15.1

[bug#30274] [PATCH 16/24] gnu: Add perl-lexical-sealrequirehints.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-lexical-sealrequirehints): New public variable.
---
 gnu/packages/perl.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 510f612b5..0a6dd46af 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -4292,6 +4292,29 @@ either uses the first module it finds or throws an error.")
 versa.")
     (license (package-license perl))))
 
+(define-public perl-lexical-sealrequirehints
+  (package
+    (name "perl-lexical-sealrequirehints")
+    (version "0.011")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/Z/ZE/ZEFRAM/Lexical-SealRequireHints-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0fh1arpr0hsj7skbn97yfvbk22pfcrpcvcfs15p5ss7g338qx4cy"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-module-build" ,perl-module-build)))
+    (home-page "http://search.cpan.org/dist/Lexical-SealRequireHints/")
+    (synopsis "Prevent leakage of lexical hints")
+    (description
+     "Lexical::SealRequireHints prevents leakage of lexical hints")
+    (license (package-license perl))))
+
 (define-public perl-log-any
   (package
     (name "perl-log-any")
-- 
2.15.1

[bug#30274] [PATCH 17/24] gnu: Add perl-multidimensional.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-multidimensional): New public variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 0a6dd46af..ebceadf48 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -5993,6 +5993,32 @@ Certificate Authority certificates in a form that can be consumed by modules
 and libraries based on OpenSSL.")
     (license mpl2.0)))
 
+(define-public perl-multidimensional
+  (package
+    (name "perl-multidimensional")
+    (version "0.013")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/I/IL/ILMARI/multidimensional-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "02p5zv68i39hnkmzzxsk1fi7xy56pfcsslrd7yqwzhq74czcw81x"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-extutils-depends" ,perl-extutils-depends)))
+    (propagated-inputs
+     `(("perl-b-hooks-op-check" ,perl-b-hooks-op-check)
+       ("perl-lexical-sealrequirehints" ,perl-lexical-sealrequirehints)))
+    (home-page "http://search.cpan.org/dist/multidimensional/")
+    (synopsis "Disable multidimensional array emulation")
+    (description
+     "Multidimensional disables multidimensional array emulation.")
+    (license (package-license perl))))
+
 (define-public perl-mro-compat
   (package
     (name "perl-mro-compat")
-- 
2.15.1

[bug#30274] [PATCH 18/24] gnu: Add perl-test-roo.

[Oleg Pykhalov]

* gnu/packages/perl-check.scm (perl-test-roo): New public variable.
---
 gnu/packages/perl-check.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/perl-check.scm b/gnu/packages/perl-check.scm
index 249997229..09ddaa242 100644
--- a/gnu/packages/perl-check.scm
+++ b/gnu/packages/perl-check.scm
@@ -973,6 +973,34 @@ cannot connect to the specified hosts and ports, the exception is caught and
 reported, and the tests skipped.")
     (license perl-license)))
 
+(define-public perl-test-roo
+  (package
+    (name "perl-test-roo")
+    (version "1.004")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Test-Roo-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1mnym49j1lj7gzylma5b6nr4vp75rmgz2v71904v01xmxhy9l4i1"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-capture-tiny" ,perl-capture-tiny)))
+    (propagated-inputs
+     `(("perl-indirect" ,perl-indirect)
+       ("perl-moo" ,perl-moo)
+       ("perl-moox-types-mooselike" ,perl-moox-types-mooselike)
+       ("perl-multidimensional" ,perl-multidimensional)
+       ("perl-strictures" ,perl-strictures)
+       ("perl-sub-install" ,perl-sub-install)))
+    (home-page "http://search.cpan.org/dist/Test-Roo/")
+    (synopsis "Composable, reusable tests with roles and Moo")
+    (description "Test::Roo provides composable, reusable tests with roles.")
+    (license asl2.0)))
+
 (define-public perl-test-script
   (package
     (name "perl-test-script")
-- 
2.15.1

[bug#30274] [PATCH 19/24] gnu: Add perl-universal-require.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-universal-require): New public variable.
---
 gnu/packages/perl.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index ebceadf48..7448a505f 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -8537,6 +8537,27 @@ UNIVERSAL::can() as a function, which it is not.")
 UNIVERSAL::isa as a function.")
     (license (package-license perl))))
 
+(define-public perl-universal-require
+  (package
+    (name "perl-universal-require")
+    (version "0.18")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/N/NE/NEILB/UNIVERSAL-require-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1v9qdg80ng6dzyzs7cn8sb6mn8ym042i32lcnpd478b7g6l3d9xj"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/UNIVERSAL-require/")
+    (synopsis "Require modules from a variable")
+    (description "This module lets you require other modules where the module
+name is in a variable, something you can't do with the @code{require}
+built-in.")
+    (license (package-license perl))))
+
 (define-public perl-variable-magic
   (package
     (name "perl-variable-magic")
-- 
2.15.1

[bug#30274] [PATCH 20/24] gnu: Add perl-strictures-2.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-strictures-2): New public variable.
---
 gnu/packages/perl.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 7448a505f..84a9dc1c8 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -7049,6 +7049,19 @@ on the length of the size.")
 run from within a source-controlled directory.")
     (license (package-license perl))))
 
+(define-public perl-strictures-2
+  (package
+    (inherit perl-strictures)
+    (version "2.000003")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/H/HA/HAARG/"
+                           "strictures-" version ".tar.gz"))
+       (sha256
+        (base32
+         "08mgvf1d2651gsg3jgjfs13878ndqa4ji8vfsda9f7jjd84ymy17"))))))
+
 (define-public perl-string-camelcase
   (package
     (name "perl-string-camelcase")
-- 
2.15.1

[bug#30274] [PATCH 21/24] gnu: Add perl-role-tiny-2.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-role-tiny-2): New public variable.
---
 gnu/packages/perl.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 84a9dc1c8..9e4e55985 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6810,6 +6810,19 @@ and @code{deserialize_regexp}.")
     (description "Role::Tiny is a minimalist role composition tool.")
     (license (package-license perl))))
 
+(define-public perl-role-tiny-2
+  (package
+    (inherit perl-role-tiny)
+    (version "2.000006")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/H/HA/HAARG/"
+                           "Role-Tiny-" version ".tar.gz"))
+       (sha256
+        (base32
+         "10p3sc639c0nj56bb77a2wg8samyyl8sqpliv3n8c0jaj2642wyc"))))))
+
 (define-public perl-safe-isa
   (package
     (name "perl-safe-isa")
-- 
2.15.1

[bug#30274] [PATCH 22/24] gnu: Add perl-sub-quote.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-sub-quote): New public variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 9e4e55985..55d4f22c4 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -7301,6 +7301,31 @@ specification is omitted in the name, then the current package is used.  The
 return value is the sub.")
     (license (package-license perl))))
 
+(define-public perl-sub-quote
+  (package
+    (name "perl-sub-quote")
+    (version "2.004000")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/H/HA/HAARG/Sub-Quote-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "1zrh3apxsw1ks25zkh9dcn00656rsvq4mimqz3w8p37s2c1m4qaq"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-fatal" ,perl-test-fatal)))
+    (propagated-inputs
+     `(("perl-sub-name" ,perl-sub-name)))
+    (home-page "http://search.cpan.org/dist/Sub-Quote/")
+    (synopsis "Efficient generation of subroutines via string eval")
+    (description "Sub::Quote provides an efficient generation of subroutines
+via string eval.")
+    (license (package-license perl))))
+
 (define-public perl-sub-uplevel
   (package
     (name "perl-sub-uplevel")
-- 
2.15.1

[bug#30274] [PATCH 23/24] gnu: Add perl-moo-2.

[Oleg Pykhalov]

* gnu/packages/perl.scm (perl-moo-2): New public variable.
---
 gnu/packages/perl.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 55d4f22c4..a9f656039 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -36,6 +36,7 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages perl)
+  #:use-module (srfi srfi-1)
   #:use-module (guix licenses)
   #:use-module (gnu packages)
   #:use-module (guix packages)
@@ -5120,6 +5121,36 @@ that avoids the details of Perl's object system.  Moo contains a subset of
 Moose and is optimised for rapid startup.")
     (license (package-license perl))))
 
+(define-public perl-moo-2
+  (package
+    (inherit perl-moo)
+    (name "perl-moo-2")
+    (version "2.003004")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/H/HA/HAARG/"
+                           "Moo-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1qciprcgb4661g2g4ks0fxkx5gbjvn7h9yfg0nzflqz9z0jvdfzq"))))
+    (propagated-inputs
+     `(("perl-role-tiny" ,perl-role-tiny-2)
+       ("perl-sub-name" ,perl-sub-name)
+       ("perl-sub-quote" ,perl-sub-quote)
+       ("perl-strictures" ,perl-strictures-2)
+       ,@(alist-delete "perl-strictures"
+                       (alist-delete "perl-role-tiny"
+                                     (package-propagated-inputs perl-moo)))))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'set-perl-search-path
+           (lambda _
+             ;; Use perl-strictures for testing.
+             (setenv "MOO_FATAL_WARNINGS" "=1")
+             #t)))))))
+
 (define-public perl-moose
   (package
     (name "perl-moose")
-- 
2.15.1

[bug#30274] [PATCH 24/24] gnu: Add licensecheck.

[Oleg Pykhalov]

* gnu/packages/license.scm (licensecheck): New public variable.
---
 gnu/packages/license.scm | 54 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/license.scm b/gnu/packages/license.scm
index 774654f48..42db64496 100644
--- a/gnu/packages/license.scm
+++ b/gnu/packages/license.scm
@@ -103,3 +103,57 @@ statements and serializes in normalized format.")
     (synopsis "Templated software licenses")
     (description "This package provides templated software licenses.")
     (license (package-license perl))))
+
+(define-public licensecheck
+  (package
+    (name "licensecheck")
+    (version "v3.0.31")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://cpan/authors/id/J/JO/JONASS/App-Licensecheck-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "12970mfcnqjil1p09s137nvqxjiqsjypivby8yhp163wl06i2s51"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-software-license" ,perl-software-license)
+       ("perl-test-requires" ,perl-test-requires)
+       ("perl-test-roo" ,perl-test-roo)
+       ("perl-test-script" ,perl-test-script)
+       ("perl-universal-require" ,perl-universal-require)
+       ("perl-number-range" ,perl-number-range)
+       ("perl-sub-quote" ,perl-sub-quote)))
+    (propagated-inputs
+     `(("perl-getopt-long-descriptive" ,perl-getopt-long-descriptive)
+       ("perl-moo" ,perl-moo-2)
+       ("perl-namespace-clean" ,perl-namespace-clean)
+       ("perl-path-iterator-rule" ,perl-path-iterator-rule)
+       ("perl-path-tiny" ,perl-path-tiny)
+       ("perl-pod-constants" ,perl-pod-constants)
+       ("perl-regexp-pattern-license" ,perl-regexp-pattern-license)
+       ("perl-sort-key" ,perl-sort-key)
+       ("perl-strictures" ,perl-strictures-2)
+       ("perl-string-copyright" ,perl-string-copyright)
+       ("perl-string-escape" ,perl-string-escape)
+       ("perl-try-tiny" ,perl-try-tiny)
+       ("perl-module-runtime" ,perl-module-runtime)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (perllib (string-append out "/lib/perl5/site_perl/"
+                                            ,(package-version perl))))
+               (wrap-program (string-append out "/bin/licensecheck")
+                 `("PERL5LIB" ":"
+                   prefix (,(string-append perllib ":" (getenv "PERL5LIB")))))
+               #t))))))
+    (home-page "http://search.cpan.org/dist/App-Licensecheck/")
+    (synopsis "License checker for source files")
+    (description "Licensecheck attempts to determine the license that applies
+to each file passed to it, by searching the start of the file for text
+belonging to various licenses.")
+    (license (package-license perl))))
-- 
2.15.1

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

In addition to the cover letter.

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Hello Guix,
>
> Licensecheck attempts to determine the license that applies to each file
> passed to it, by searching the start of the file for text belonging to various
> licenses.
>
>
> Some notes while I've adopted `guix import cpan` produced packages:
>
> - perl-b-hooks-op-check, perl-bareword-filehandles, perl-multidimensional had
>   a perl-gtk-perl in native-inputs.
>
> - perl-test-roo had a perl-bareword-filehandles in native-inputs.

`guix lint` failed on perl-strictures-2 and didn't lint other packages I
sended.  Well, will know this in future.

I have fixed following warning
--8<---------------cut here---------------start------------->8---
gnu/packages/perl.scm:4313:14: perl-lexical-sealrequirehints@0.011: synopsis should start with an upper-case letter or digit
gnu/packages/perl.scm:3972:14: perl-indirect@0.38: no period allowed at the end of the synopsis
gnu/packages/perl.scm:369:17: perl-bareword-filehandles@0.005: description should start with an upper-case letter or digit
gnu/packages/perl.scm:1883:14: perl-data-section@0.200007: synopsis should start with an upper-case letter or digit
gnu/packages/perl.scm:9122:17: perl-pod-constants@0.19: sentences in description should be followed by two spaces; possible infraction at 218
--8<---------------cut here---------------end--------------->8---

The following are new to me, so should I add a "v" in (version …) for
those packages?  I see for example perl-file-find-object has it.
--8<---------------cut here---------------start------------->8---
/home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: licensecheck@3.0.31: can be upgraded to v3.0.31
/home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:33:2: perl-regexp-pattern-license@3.0.31: can be upgraded to v3.0.31
--8<---------------cut here---------------end--------------->8---

[...]

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> The following are new to me, so should I add a "v" in (version …) for
> those packages?  I see for example perl-file-find-object has it.
> --8<---------------cut here---------------start------------->8---
> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: licensecheck@3.0.31: can be upgraded to v3.0.31
> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:33:2: perl-regexp-pattern-license@3.0.31: can be upgraded to v3.0.31
> --8<---------------cut here---------------end--------------->8---

This is a bug in the CPAN updater.  We strip the 'v' prefix from package
versions, which confuses the updater when upstream uses a 'v' prefix in
the metadata.

It would be nice to make it ignore that :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> The following are new to me, so should I add a "v" in (version …) for
>> those packages?  I see for example perl-file-find-object has it.
>> --8<---------------cut here---------------start------------->8---
>> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: licensecheck@3.0.31: can be upgraded to v3.0.31
>> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:33:2: perl-regexp-pattern-license@3.0.31: can be upgraded to v3.0.31
>> --8<---------------cut here---------------end--------------->8---
>
> This is a bug in the CPAN updater.  We strip the 'v' prefix from package
> versions, which confuses the updater when upstream uses a 'v' prefix in
> the metadata.
>
> It would be nice to make it ignore that :-)

Sorry, not clear to me.  Should I add a "v" prefix to the version field?

I see a bunch of packages packages have "v" prefix:
--8<---------------cut here---------------start------------->8---
./gnu/packages/perl.scm:3599:    (version "v2.49.1")
./gnu/packages/perl.scm:7969:    (version "v0.0.2")
./gnu/packages/perl.scm:8697:  (version "v0.2.13")
./gnu/packages/networking.scm:778:  (version "v0.003")
./gnu/packages/mail.scm:1755:  (version "v2.9.0")
--8<---------------cut here---------------end--------------->8---

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>
>>> The following are new to me, so should I add a "v" in (version …) for
>>> those packages?  I see for example perl-file-find-object has it.
>>> --8<---------------cut here---------------start------------->8---
>>> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: licensecheck@3.0.31: can be upgraded to v3.0.31
>>> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:33:2: perl-regexp-pattern-license@3.0.31: can be upgraded to v3.0.31
>>> --8<---------------cut here---------------end--------------->8---
>>
>> This is a bug in the CPAN updater.  We strip the 'v' prefix from package
>> versions, which confuses the updater when upstream uses a 'v' prefix in
>> the metadata.
>>
>> It would be nice to make it ignore that :-)
>
> Sorry, not clear to me.  Should I add a "v" prefix to the version field?

Sorry, I meant the opposite: we don't add the "v" prefix.  It would be
nice to make the CPAN updater aware of that.

> I see a bunch of packages packages have "v" prefix:
> --8<---------------cut here---------------start------------->8---
> ./gnu/packages/perl.scm:3599:    (version "v2.49.1")
> ./gnu/packages/perl.scm:7969:    (version "v0.0.2")
> ./gnu/packages/perl.scm:8697:  (version "v0.2.13")
> ./gnu/packages/networking.scm:778:  (version "v0.003")
> ./gnu/packages/mail.scm:1755:  (version "v2.9.0")
> --8<---------------cut here---------------end--------------->8---

Let's fix these :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#30274: [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Sorry, I meant the opposite: we don't add the "v" prefix.  It would be
> nice to make the CPAN updater aware of that.

I'll close current bug report.  Should we open a new one for CPAN
updater fix purpose?

>> I see a bunch of packages packages have "v" prefix:
>> --8<---------------cut here---------------start------------->8---
>> ./gnu/packages/perl.scm:3599:    (version "v2.49.1")
>> ./gnu/packages/perl.scm:7969:    (version "v0.0.2")
>> ./gnu/packages/perl.scm:8697:  (version "v0.2.13")
>> ./gnu/packages/networking.scm:778:  (version "v0.003")
>> ./gnu/packages/mail.scm:1755:  (version "v2.9.0")
>> --8<---------------cut here---------------end--------------->8---
>
> Let's fix these :-)

I guess it's better to do after a CPAN updater fix.  WDYT?

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Sorry, I meant the opposite: we don't add the "v" prefix.  It would be
>> nice to make the CPAN updater aware of that.
>
> I'll close current bug report.  Should we open a new one for CPAN
> updater fix purpose?

Sounds good!  I think the GitHub updater already ignores the "v" prefix
when comparing versions, so there might be some inspiration there.

>>> I see a bunch of packages packages have "v" prefix:
>>> --8<---------------cut here---------------start------------->8---
>>> ./gnu/packages/perl.scm:3599:    (version "v2.49.1")
>>> ./gnu/packages/perl.scm:7969:    (version "v0.0.2")
>>> ./gnu/packages/perl.scm:8697:  (version "v0.2.13")
>>> ./gnu/packages/networking.scm:778:  (version "v0.003")
>>> ./gnu/packages/mail.scm:1755:  (version "v2.9.0")
>>> --8<---------------cut here---------------end--------------->8---
>>
>> Let's fix these :-)
>
> I guess it's better to do after a CPAN updater fix.  WDYT?

No opinion either way :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hello Marius,

Marius Bakke <mbakke@fastmail.com> writes:

> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Sorry, I meant the opposite: we don't add the "v" prefix.  It would be
>>> nice to make the CPAN updater aware of that.
>>
>> I'll close current bug report.  Should we open a new one for CPAN
>> updater fix purpose?
>
> Sounds good!  I think the GitHub updater already ignores the "v" prefix
> when comparing versions, so there might be some inspiration there.

OK, reported as 30641

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Hello Guix,
>
> Licensecheck attempts to determine the license that applies to each file
> passed to it, by searching the start of the file for text belonging to various
> licenses.

Nice!

I've read through the series, and the only remark I have is that it's
better to use 'perl-license' rather than (package-license perl) (see the
comment in (guix licenses)).  Probably won't be a problem any time soon,
but still.

Regarding the -2 variants, I assume other packages fail to build if they
are simply updated?  It would be good to have comments about it in the
code.

Apart from that LGTM, thank you!

> Oleg Pykhalov (21):
>   gnu: Add perl-test-filename.
>   gnu: Add perl-path-iterator-rule.
>   gnu: Add perl-pod-constants.
>   gnu: Add perl-regexp-pattern.
>   gnu: Add perl-regexp-pattern-license.
>   gnu: Add perl-number-range.
>   gnu: Add perl-string-copyright.
>   gnu: Add perl-string-escape.
>   gnu: Add perl-test-failwarnings.
>   gnu: Add perl-data-section.
>   gnu: Add perl-software-license.
>   gnu: Add perl-extutils-depends.
>   gnu: Add perl-b-hooks-op-check.
>   gnu: Add perl-bareword-filehandles.
>   gnu: Add perl-indirect.
>   gnu: Add perl-lexical-sealrequirehints.
>   gnu: Add perl-multidimensional.
>   gnu: Add perl-test-roo.
>   gnu: Add perl-universal-require.
>   gnu: Add perl-strictures-2.
>   gnu: Add licensecheck.
>
>  gnu/local.mk                |   1 +
>  gnu/packages/license.scm    | 158 ++++++++++++++++++++
>  gnu/packages/perl-check.scm |  73 ++++++++++
>  gnu/packages/perl.scm       | 340 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 572 insertions(+)
>  create mode 100644 gnu/packages/license.scm
>
> -- 
> 2.15.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hello Marius,

Thank you for review!

Marius Bakke <mbakke@fastmail.com> writes:

> Regarding the -2 variants, I assume other packages fail to build if they
> are simply updated?

Probably, if packages hadn't been built with “-2 variants” by upstream.

> It would be good to have comments about it in the code.

To have comments in the “-2 variants” code or in the “other packages” code?

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Hello Marius,
>
> Thank you for review!
>
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Regarding the -2 variants, I assume other packages fail to build if they
>> are simply updated?
>
> Probably, if packages hadn't been built with “-2 variants” by upstream.
>
>> It would be good to have comments about it in the code.
>
> To have comments in the “-2 variants” code or in the “other packages” code?

In the -2 variants.  E.g. "Some packages don't yet work with this
newer version of FOO, so we package it separately".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Oleg Pykhalov <go.wigust@gmail.com> writes:

[...]

> In the -2 variants.  E.g. "Some packages don't yet work with this
> newer version of FOO, so we package it separately".

OK.  I commented those but without “, so we package it separately”.

Also I upgrade ‘licensecheck’ to 3.0.33 and
‘perl-regexp-pattern-license’ to 3.1.0.

Pushed as f09cb93e3a2310f7726cb98fa5679c1a8483c39f

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]