From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5Y6-0002PD-9k for guix-patches@gnu.org; Tue, 23 Jan 2018 15:52:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee5Y2-0007iv-95 for guix-patches@gnu.org; Tue, 23 Jan 2018 15:52:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60387) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee5Y2-0007im-4k for guix-patches@gnu.org; Tue, 23 Jan 2018 15:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee5Y1-00009a-Ol for guix-patches@gnu.org; Tue, 23 Jan 2018 15:52:01 -0500 Subject: [bug#30214] [PATCH 02/10] gnu: Add go-github.com-howeyc-gopass. Resent-Message-ID: Date: Tue, 23 Jan 2018 15:51:23 -0500 From: Leo Famulari Message-ID: <20180123205123.GH6750@jasmine.lan> References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-2-mail@cbaines.net> <20180122215306.GC15170@jasmine.lan> <87wp085ph3.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r5lq+205vWdkqwtk" Content-Disposition: inline In-Reply-To: <87wp085ph3.fsf@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 30214@debbugs.gnu.org --r5lq+205vWdkqwtk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 23, 2018 at 07:45:12PM +0000, Christopher Baines wrote: >=20 > Leo Famulari writes: >=20 > > On Mon, Jan 22, 2018 at 09:08:22PM +0000, Christopher Baines wrote: > >> * gnu/packages/terminals.scm (go-github.com-howeyc-gopass): New variab= le. > > > >> + (native-inputs > >> + `(("go-golang.org-x-crypto-ssh-terminal" > >> + ,go-golang.org-x-crypto-ssh-terminal))) > > > > Is it really just a native-input? Or could it need this library later, > > at run-time? >=20 > Well, the package doesn't build without it, and as far as I can tell the > store output doesn't reference it. I believe that > go-golang.org-x-crypto-ssh-terminal is a dependency of > go-github.com-howeyc-gopass, so if you're using > go-github.com-howeyc-gopass, then you'll need > go-golang.org-x-crypto-ssh-terminal. Maybe it should be a propagated > input instead? Go looks for dependencies by first looking for their source code (this is why the go-build-system installs the source code by default). Once it finds the source code, then it looks up the compiled objects. Finally, when building the end-user application (not just some library) it links everything together in what's basically a static archive. If everything seems to work even though x-crypto-ssh-terminal is a native-input, then I bet that whatever is using howeyc-gopass does not exercise the part of howeyc-gopass's code using x-crypto-ssh-terminal. I think it's more correct here to propagate, unless x-crypto-ssh-terminal is only used for howeyc-gopass's test suite or something like that. --r5lq+205vWdkqwtk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlpnoEsACgkQJkb6MLrK fwj7Jw/8D00JmgM0HbT1K84dukxnHuB59cGkIkihz13HZ/NVzgkjOixgt3WFbKDP BbCj/ELd4df6CrMrm5cA0nsBG5spGOEahIwM+7T/KpZXBjFDvhGeWWbLh6N53OTA Ne3YT3FYNb8M/bE++FFjWFF4IUWRlNaShS3AaGd/sArPer5wxQkGkXwqgoPtv5hT F1qtkcnH0zteJPGQXI4jbA0gJY/xYvxTomVXk4GmztgiQH8X8Ia0VDEfuNHcU8M4 WPnaNbRJuDvHD2lyizXPPAuYGz/sP/RkmGpTVhBugA6KQeA8kDwbPHhFMhcbFSRH niR0auhabxPxJxWb2ZNOkyfB5RB0LKUsOuKDXL//XurJcX4wLYURaSItnZWSU2XX dfUVUudGOTSp0YXi+ULDLzAn5dnHyPznKXFd3Z/wf5Hnv7uzQqnaPfbBtex8sH32 ngFdZk9c3nXVtckjW52xrdZBK+b2x5xebQDjY1KBjiLkEj2EuCd9DgCIZzQn1zpc i4Ww8O50GRqJ4J0CBvsfpnpdVTG0huycKjnuhdGDseqR6bL2t0EYJrhTJuDyzjWk TWHMT8GoCh0ke25+5mrTThwmJfCHUEUi2UA+F1pqqhz4q7lIMfwCvzsWiXG2/Hh/ GfkdV9t1EMT2u4FeOUjoTBzYHwrTjPbD7FhifXKhAJ2iraIA1Sg= =pMM+ -----END PGP SIGNATURE----- --r5lq+205vWdkqwtk--