From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5Cq-00041C-JK for guix-patches@gnu.org; Tue, 23 Jan 2018 15:30:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee5Cl-0002xr-TC for guix-patches@gnu.org; Tue, 23 Jan 2018 15:30:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60359) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee5Cl-0002xd-Ob for guix-patches@gnu.org; Tue, 23 Jan 2018 15:30:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee5Cl-00083G-BM for guix-patches@gnu.org; Tue, 23 Jan 2018 15:30:03 -0500 Subject: [bug#30214] [PATCH 03/10] gnu: Add go-github.com-jessevdk-go-flags. Resent-Message-ID: Date: Tue, 23 Jan 2018 15:29:35 -0500 From: Leo Famulari Message-ID: <20180123202935.GD6750@jasmine.lan> References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-3-mail@cbaines.net> <20180122215447.GD15170@jasmine.lan> <87vafs5p79.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3Pql8miugIZX0722" Content-Disposition: inline In-Reply-To: <87vafs5p79.fsf@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 30214@debbugs.gnu.org --3Pql8miugIZX0722 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 23, 2018 at 07:51:06PM +0000, Christopher Baines wrote: > Leo Famulari writes: > > On Mon, Jan 22, 2018 at 09:08:23PM +0000, Christopher Baines wrote: > >> * gnu/packages/golang.scm (go-github.com-jessevdk-go-flags): New varia= ble. > > > >> + (add-after 'unpack 'rename-archive > >> + (lambda _ > >> + (rename-file > >> + ,(string-append "src/github.com/jessevdk/go-flags-" ver= sion) > >> + "src/github.com/jessevdk/go-flags") > >> + #t))))) > > > > Should the go-build-system try to handle this automatically? >=20 > I believe this might be connected with what is in the source > tarball. Without this stage, the go-flags directory is called > go-flags-1.3.0, and this causes the build to fail [2]. Oh right, Go expects you to use Git checkouts instead of release tarballs. I bet it works if you do that. That kind of tarball is automatically created by GitHub per tag, and can't be disabled. > I'm not sure about the wider context, but it would be good to handle > this automatically. So, I think the build system doesn't need to handle this case. --3Pql8miugIZX0722 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlpnmy8ACgkQJkb6MLrK fwghqw//eKnanz6JwqO3HeMAfeFVHJEJ/JAZQ99UxyOWoK68cKMahAjcKXooouga BvckdIpfjWgvV+8FXoWhbpy4YQVjW1Hmn9a6bVbG9kaWZz8IitFwJ3bgNyFWJDvo aSRVkQIjA3PyZ0Q2DnbyH7dwgwUrYTSTpaV/ey9TjWH0m4o/Cude1j5LqXmCr6QS tyoWpXW1s1sLlO9EmOt2eVtk8bIqGB1ViSoZgr+Qb20FD2LHB7O4AfIEt5lsaCrV RhgVvWdUbC66B2nBsjRW/xA4ZL0iQIglc7xD619/zqJi1MXT/qaw9mZOGrk8rLkm +pNZcky0zS+HH2DHt+1utWXkmTv/l9yGkiAxDzB+/iH1FOz/xRI+vEUh5CnbV8ws EhzY9Iwj0jmfthS3uOvt+0xU7HWDCwguhmITwCvThtbqxWOquxu5fadCrQyIli5+ zw9FxKgmf66gRuUi0TPbh8xS9uq47dQt7EXd4x9dm6gMTq+PIyhNVJrJhsarvkgY r+d/n4HuqSyIu6caOQVzTCe19HUYb9tl42PxeAwa4acBE2d5clYlNdQKUl7VYWOM IH1j00n0B3Qhu1/F1UXppZ5TJcMyxVYaOKVHhn1Dt4Msciesh2ZpS3d2atoGbj6c 7fy6w1WnAk/tb7EfyVN33b0OAlI5qGI1v54hJZ+LVwVk7BL5KIg= =97i8 -----END PGP SIGNATURE----- --3Pql8miugIZX0722--