From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX8z4-0007Ye-6R for guix-patches@gnu.org; Thu, 04 Jan 2018 12:07:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX8yt-0004dO-3c for guix-patches@gnu.org; Thu, 04 Jan 2018 12:07:14 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:55440) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eX8ys-0004cs-Qp for guix-patches@gnu.org; Thu, 04 Jan 2018 12:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eX8ys-0004A3-Hn for guix-patches@gnu.org; Thu, 04 Jan 2018 12:07:02 -0500 Subject: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests. Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX8xd-0005rl-2N for guix-patches@gnu.org; Thu, 04 Jan 2018 12:06:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX8xE-000225-9K for guix-patches@gnu.org; Thu, 04 Jan 2018 12:05:45 -0500 Received: from esa1.cray.iphmx.com ([68.232.142.33]:11440) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eX8xD-0001yT-Qp for guix-patches@gnu.org; Thu, 04 Jan 2018 12:05:20 -0500 Received: from pe06.us.cray.com (pe06.us.cray.com [172.30.79.74]) by sealmr01.us.cray.com (8.14.3/8.13.8/hubv3-LastChangedRevision: 16250) with ESMTP id w04H4ROk025448 for ; Thu, 4 Jan 2018 09:04:28 -0800 Date: Thu, 4 Jan 2018 11:04:27 -0600 From: Eric Bavier Message-ID: <20180104170427.GI188239@pe06.us.cray.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 29979@debbugs.gnu.org --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This patch disable the signal handler unit tests in 'glog'. These tests are known to fail on several systems where the expected signals are not generated. -- Eric Bavier, Scientific Libraries, Cray Inc. --fUYQa+Pmc3FrFX/N Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-glog-Disable-signal-handler-unit-tests.patch" Content-Transfer-Encoding: 8bit >From 08e3f2407c98e8cdad631e5671c8563de3b78978 Mon Sep 17 00:00:00 2001 From: Eric Bavier Date: Thu, 7 Dec 2017 16:15:38 -0600 Subject: [PATCH] gnu: glog: Disable signal-handler unit tests. * gnu/packages/logging.scm (glog)[arguments]: Add 'disable-signal-tests' phase. --- gnu/packages/logging.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm index 6f9056d8f..713435c6a 100644 --- a/gnu/packages/logging.scm +++ b/gnu/packages/logging.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2016 Ricardo Wurmus ;;; Copyright © 2016, 2017 Ludovic Courtès ;;; Copyright © 2017 Stefan Reichör +;;; Copyright © 2017 Eric Bavier ;;; ;;; This file is part of GNU Guix. ;;; @@ -84,7 +85,14 @@ staying as close to their API as is reasonable.") ;; mismatch, so run the whole thing. (delete-file "test-driver") (delete-file "configure") ;it's read-only - (zero? (system* "autoreconf" "-vfi"))))))) + (zero? (system* "autoreconf" "-vfi")))) + (add-before 'check 'disable-signal-tests + (lambda _ + ;; See e.g. https://github.com/google/glog/issues/219 + ;; and https://github.com/google/glog/issues/256 + (substitute* "Makefile" + (("\tsignalhandler_unittest_sh") "\t$(EMPTY)")) + #t))))) (synopsis "C++ logging library") (description "Google glog is a library that implements application-level logging. -- 2.15.0 --fUYQa+Pmc3FrFX/N--