From: 宋文武 <iyzsong@member.fsf.org>
To: 29927@debbugs.gnu.org
Subject: [bug#29927] [PATCH 2/5] profiles: info-dir-file: Don't consider unwanted manifest entries.
Date: Mon, 1 Jan 2018 18:33:33 +0800 [thread overview]
Message-ID: <20180101103336.8613-3-iyzsong@member.fsf.org> (raw)
In-Reply-To: <20180101103336.8613-1-iyzsong@member.fsf.org>
* guix/profiles.scm (info-dir-file): Use 'eval-gexp' to filter out those
manifest inputs that doesn't have info manuals.
---
guix/profiles.scm | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/guix/profiles.scm b/guix/profiles.scm
index 3c05543be..f6e455c96 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -684,7 +684,19 @@ MANIFEST."
(define gzip ;lazy reference
(module-ref (resolve-interface '(gnu packages compression)) 'gzip))
- (define build
+ ;; We only need to build the 'dir' file for inputs that does contain info
+ ;; manuals.
+ (define interested
+ (eval-gexp
+ #~(filter
+ (lambda (input)
+ (file-exists? (string-append input "/share/info")))
+ '#$(manifest-inputs manifest))))
+
+ ;; XXX: We have to pass paths of inputs instead of paths of info files,
+ ;; because 'gexp-inputs' only adds inputs for strings which satisfies
+ ;; 'direct-store-path?'.
+ (define (build inputs)
(with-imported-modules '((guix build utils))
#~(begin
(use-modules (guix build utils)
@@ -708,12 +720,12 @@ MANIFEST."
(mkdir-p (string-append #$output "/share/info"))
(exit (every install-info
- (append-map info-files
- '#$(manifest-inputs manifest)))))))
+ (append-map info-files '#$inputs))))))
- (gexp->derivation "info-dir" build
- #:local-build? #t
- #:substitutable? #f))
+ (mlet* %store-monad ((inputs interested))
+ (gexp->derivation "info-dir" (build inputs)
+ #:local-build? #t
+ #:substitutable? #f)))
(define (ghc-package-cache-file manifest)
"Return a derivation that builds the GHC 'package.cache' file for all the
--
2.13.3
next prev parent reply other threads:[~2018-01-01 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 10:33 [bug#29928] [PATCH 0/5] Optimize profile hooks 宋文武
2018-01-01 10:33 ` [bug#29926] [PATCH 1/5] gexp: Add 'eval-gexp' 宋文武
2018-01-01 10:33 ` 宋文武 [this message]
2018-01-01 10:33 ` [bug#29925] [PATCH 3/5] guix package: Disable profile hooks on dry runs 宋文武
2018-01-01 13:36 ` Danny Milosavljevic
2018-01-01 10:33 ` [bug#29930] [PATCH 4/5] profiles: Filter out unwanted manifest entries for profile hooks 宋文武
2018-01-01 10:33 ` [bug#29929] [PATCH 5/5] profiles: Sort manifest inputs " 宋文武
2018-01-01 13:38 ` Danny Milosavljevic
2018-01-11 22:45 ` [bug#29928] [PATCH 0/5] Optimize " Ludovic Courtès
2018-01-19 14:42 ` 宋文武
2018-01-19 16:04 ` Ludovic Courtès
2018-01-20 12:52 ` 宋文武
2021-05-11 13:34 ` Leo Prikler
2021-05-12 11:12 ` bug#29925: " 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180101103336.8613-3-iyzsong@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=29927@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).