unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: 29697@debbugs.gnu.org
Subject: [bug#29697] Small fixes for java-powermock
Date: Wed, 13 Dec 2017 21:30:43 +0100	[thread overview]
Message-ID: <20171213212417.41463b57@lepiller.eu> (raw)

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Hi, these two patches should fix runtime issues with our powermock
package.

[-- Attachment #2: 0001-gnu-java-powermock-core-Include-resources.patch --]
[-- Type: text/x-patch, Size: 1205 bytes --]

From 6ec54c532fe4613685ca6587ae413d4c285ac8c4 Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Wed, 13 Dec 2017 21:18:50 +0100
Subject: [PATCH 1/2] gnu: java-powermock-core: Include resources.

* gnu/packages/java.scm (java-powermock-core)[arguments]: Add a phase to
include resources.
---
 gnu/packages/java.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 0be488dec..98391ab24 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -7418,7 +7418,13 @@ done to the IDE or continuous integration servers which simplifies adoption.")
        #:source-dir "powermock-core/src/main/java"
        #:test-dir "powermock-core/src/test"
        #:tests? #f; requires powermock-api
-       #:jdk ,icedtea-8))
+       #:jdk ,icedtea-8
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'copy-resources
+           (lambda _
+             (copy-recursively "powermock-core/src/main/resources"
+                               "build/classes"))))))
     (inputs
      `(("reflect" ,java-powermock-reflect)
        ("javassist" ,java-jboss-javassist)))
-- 
2.15.0


[-- Attachment #3: 0002-gnu-java-powermock-modules-junit4-Fix-junit-version-.patch --]
[-- Type: text/x-patch, Size: 1483 bytes --]

From b9631e4fda41168e46b415e250d65db96ce0c9cb Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Wed, 13 Dec 2017 21:20:30 +0100
Subject: [PATCH 2/2] gnu: java-powermock-modules-junit4: Fix junit version
 detection.

* gnu/packages/java.scm (java-powermock-modules-junit4)[arguments]: Fix
junit version detection.
---
 gnu/packages/java.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 98391ab24..2a8080eb3 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -7473,7 +7473,15 @@ done to the IDE or continuous integration servers which simplifies adoption.")
      `(#:jar-name "java-powermock-modules-junit4.jar"
        #:jdk ,icedtea-8
        #:source-dir "powermock-modules/powermock-module-junit4/src/main/java"
-       #:test-dir "powermock-modules/powermock-module-junit4/src/test"))
+       #:test-dir "powermock-modules/powermock-module-junit4/src/test"
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'fix-junit-detection
+           (lambda _
+             ;; Our junit version is 4.12-SNAPSHOT
+             (substitute* (find-files "powermock-modules/powermock-module-junit4"
+                                      "PowerMockJUnit4MethodValidator.java")
+               (("4.12") "4.12-SNAPSHOT")))))))
     (inputs
      `(("core" ,java-powermock-core)
        ("reflect" ,java-powermock-reflect)
-- 
2.15.0


             reply	other threads:[~2017-12-13 20:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 20:30 Julien Lepiller [this message]
2018-03-03 13:32 ` [bug#29697] Patch review Gábor Boskovits
2018-06-23 15:31 ` bug#29697: Small fixes for java-powermock Gábor Boskovits

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213212417.41463b57@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=29697@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).