On Thu, Nov 23, 2017 at 03:04:46PM -0500, Adam Van Ymeren wrote:

Hi,

> Patch taken from the debian package for python-axolotl-0.1.39.
> 
> python-axolotl has been failing since March,
> https://hydra.gnu.org/job/gnu/master/python-axolotl-0.1.35.x86_64-linux
> 
> This also fixes the OMEMO and OTR plugins for Gajim work.

Thanks for looking into this and sending the patch.

> diff --git a/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
> new file mode 100644
> index 000000000..b25806ca2
> --- /dev/null
> +++ b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
> @@ -0,0 +1,21 @@
> +Description: Removes IV paramenter from AES constructor, since it is not necessary for ctr mode.
> +Author: Josue Ortega <josue@debian.org>
> +Last-Update: 2017-04-13
> +
> +--- a/axolotl/sessioncipher.py
> ++++ b/axolotl/sessioncipher.py
> +@@ -228,13 +228,7 @@
> +         # counterint = struct.unpack(">L", counterbytes)[0]
> +         # counterint = int.from_bytes(counterbytes, byteorder='big')
> +         ctr = Counter.new(128, initial_value=counter)
> +-
> +-        # cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
> +-        ivBytes = bytearray(16)
> +-        ByteUtil.intToByteArray(ivBytes, 0, counter)
> +-
> +-        cipher = AES.new(key, AES.MODE_CTR, IV=bytes(ivBytes), counter=ctr)
> +-
> ++        cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
> +         return cipher

I think this change should be submitted upstream, which is here:

https://github.com/tgalal/python-axolotl

Can you do that? We wouldn't have to wait for a new release of
python-axolotl, but we should wait to hear what the upstream maintainer
thinks.