From: Leo Famulari <leo@famulari.name>
To: Adam Van Ymeren <adam@vany.ca>
Cc: 29415@debbugs.gnu.org
Subject: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and fix build.
Date: Fri, 24 Nov 2017 19:09:52 -0500 [thread overview]
Message-ID: <20171125000952.GA17061@jasmine.lan> (raw)
In-Reply-To: <87y3mw3go1.fsf@vany.ca>
[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]
On Thu, Nov 23, 2017 at 03:04:46PM -0500, Adam Van Ymeren wrote:
Hi,
> Patch taken from the debian package for python-axolotl-0.1.39.
>
> python-axolotl has been failing since March,
> https://hydra.gnu.org/job/gnu/master/python-axolotl-0.1.35.x86_64-linux
>
> This also fixes the OMEMO and OTR plugins for Gajim work.
Thanks for looking into this and sending the patch.
> diff --git a/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
> new file mode 100644
> index 000000000..b25806ca2
> --- /dev/null
> +++ b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
> @@ -0,0 +1,21 @@
> +Description: Removes IV paramenter from AES constructor, since it is not necessary for ctr mode.
> +Author: Josue Ortega <josue@debian.org>
> +Last-Update: 2017-04-13
> +
> +--- a/axolotl/sessioncipher.py
> ++++ b/axolotl/sessioncipher.py
> +@@ -228,13 +228,7 @@
> + # counterint = struct.unpack(">L", counterbytes)[0]
> + # counterint = int.from_bytes(counterbytes, byteorder='big')
> + ctr = Counter.new(128, initial_value=counter)
> +-
> +- # cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
> +- ivBytes = bytearray(16)
> +- ByteUtil.intToByteArray(ivBytes, 0, counter)
> +-
> +- cipher = AES.new(key, AES.MODE_CTR, IV=bytes(ivBytes), counter=ctr)
> +-
> ++ cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
> + return cipher
I think this change should be submitted upstream, which is here:
https://github.com/tgalal/python-axolotl
Can you do that? We wouldn't have to wait for a new release of
python-axolotl, but we should wait to hear what the upstream maintainer
thinks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-25 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 20:04 [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and fix build Adam Van Ymeren
2017-11-25 0:09 ` Leo Famulari [this message]
2017-11-27 15:00 ` Adam Van Ymeren
2017-11-27 18:09 ` Leo Famulari
2017-11-27 18:10 ` Leo Famulari
2018-01-30 21:16 ` Ludovic Courtès
2018-01-31 14:38 ` Adam Van Ymeren
2018-01-31 16:37 ` bug#29415: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125000952.GA17061@jasmine.lan \
--to=leo@famulari.name \
--cc=29415@debbugs.gnu.org \
--cc=adam@vany.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).