[bug#29306] network-manager-vpnc

[bug#29306] network-manager-vpnc

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]

This adds the vpnc plugin for NetworkManager.

I should add a note why the substitute happens
and why the tests are enabled.
Anything I've missed in this first crude patch,
let me know. This is just to provide a base to
help people reproduce the the current NM problem.
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dl.n0.is/dist/keys/
  WWW: https://we.make.ritual.n0.is

[-- Attachment #1.2: 0001-gnu-Add-network-manager-vpnc.patch --]
[-- Type: text/plain, Size: 2556 bytes --]

From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Wed, 15 Nov 2017 10:40:46 +0000
Subject: [PATCH] gnu: Add network-manager-vpnc.

* gnu/packages/gnome.scm (network-manager-vpnc): New variable.
---
 gnu/packages/gnome.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index abe430570..996f0f43b 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5103,6 +5103,51 @@ to virtual private networks (VPNs) via OpenVPN.")
     (license license:gpl2+)
     (properties `((upstream-name . "NetworkManager-openvpn")))))
 
+(define-public network-manager-vpnc
+  (package
+    (name "network-manager-vpnc")
+    (version "1.2.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://gnome/sources/NetworkManager-vpnc/"
+                    (version-major+minor version)
+                    "/NetworkManager-vpnc-" version ".tar.xz"))
+              (sha256
+               (base32
+                "01gv205p51fsz2pfpch81ax0xm8gwj6646acag5hh0p931j53irr"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f ;test-import-export is failing
+       #:configure-flags '("--enable-absolute-paths")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-Makefile
+           (lambda _
+             (substitute* "nm-vpnc-service.conf"
+               (("own_prefix")
+                "own")))))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("pkg-config" ,pkg-config)
+       ("libtool" ,libtool)
+       ("intltool" ,intltool)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("vpnc" ,vpnc)
+       ("network-manager" ,network-manager)
+       ("network-manager-applet" ,network-manager-applet) ;for libnma
+       ("libsecret" ,libsecret)))
+    (home-page "https://wiki.gnome.org/Projects/NetworkManager/VPN")
+    (synopsis "VPNC plug-in for NetworkManager")
+    (description
+     "This extension of NetworkManager allows it to take care of connections
+to virtual private networks (VPNs) via VPNC.")
+    (license license:gpl2+)
+    (properties `((upstream-name . "NetworkManager-vpnc")))))
+
 (define-public mobile-broadband-provider-info
   (package
     (name "mobile-broadband-provider-info")
-- 
2.15.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29306] network-manager-vpnc

[Ludovic Courtès]

Heya ng0,

ng0 <ng0@infotropique.org> skribis:

> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@infotropique.org>
> Date: Wed, 15 Nov 2017 10:40:46 +0000
> Subject: [PATCH] gnu: Add network-manager-vpnc.
>
> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.

I don’t think this patch is crude.  :-)

Minor issues:

> +    (arguments
> +     '(#:tests? #f ;test-import-export is failing

Do you think you could investigate a bit?

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-Makefile
> +           (lambda _
> +             (substitute* "nm-vpnc-service.conf"
> +               (("own_prefix")
> +                "own")))))))

Please add a comment explaining what this does.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("pkg-config" ,pkg-config)
> +       ("libtool" ,libtool)
> +       ("intltool" ,intltool)))

Autoconf/Automake/Libtool are probably unnecessary.

Otherwise LGTM, thanks!

Ludo’.

[bug#29306] network-manager-vpnc

[Jelle Licht]

Heya folks,

ludo@gnu.org (Ludovic Courtès) writes:

> Heya ng0,
>
> ng0 <ng0@infotropique.org> skribis:
>
>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0@infotropique.org>
>> Date: Wed, 15 Nov 2017 10:40:46 +0000
>> Subject: [PATCH] gnu: Add network-manager-vpnc.
>>
>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.

Is this still being worked on/relevant? If so, I would like to verify
that it does what we want it to do, and get it merged :-).

Regards,
Jelle

[bug#29306] network-manager-vpnc

[Ludovic Courtès]

Heya,

Jelle Licht <jlicht@fsfe.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Heya ng0,
>>
>> ng0 <ng0@infotropique.org> skribis:
>>
>>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
>>> From: ng0 <ng0@infotropique.org>
>>> Date: Wed, 15 Nov 2017 10:40:46 +0000
>>> Subject: [PATCH] gnu: Add network-manager-vpnc.
>>>
>>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.
>
> Is this still being worked on/relevant? If so, I would like to verify
> that it does what we want it to do, and get it merged :-).

Please give it a spin!  It’s sad to see patches bitrot.

Cheers,
Ludo’.

[bug#29306] network-manager-vpnc

[ng0]

Hi Ludovic and Jelle,

Ludovic Courts transcribed 654 bytes:
> Heya,
> 
> Jelle Licht <jlicht@fsfe.org> skribis:
> 
> > ludo@gnu.org (Ludovic Courtès) writes:
> >
> >> Heya ng0,
> >>
> >> ng0 <ng0@infotropique.org> skribis:
> >>
> >>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
> >>> From: ng0 <ng0@infotropique.org>
> >>> Date: Wed, 15 Nov 2017 10:40:46 +0000
> >>> Subject: [PATCH] gnu: Add network-manager-vpnc.
> >>>
> >>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.
> >
> > Is this still being worked on/relevant? If so, I would like to verify
> > that it does what we want it to do, and get it merged :-).

Feel free to take on this. I have started publishing my old patches,
so there could be some progress in there.
Consider all my open patches here (I have no idea how many) up for
taking (leaving me as co/author), since I'm mainly doing NetBSD and
GNUnet these days.

The last known state of this patch is here:
https://c.n0.is/infotropique/p2/infotropiqueOScore/ports-wip/file/tip/ports/net/network-manager-vpnc/network-manager-vpnc.scm


Cheers,
ng0
 
> Please give it a spin!  It’s sad to see patches bitrot.
> 
> Cheers,
> Ludo’.

bug#29306: network-manager-vpnc

[Maxim Cournoyer]

Jelle Licht <jlicht@fsfe.org> writes:

> Heya folks,
>
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Heya ng0,
>>
>> ng0 <ng0@infotropique.org> skribis:
>>
>>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
>>> From: ng0 <ng0@infotropique.org>
>>> Date: Wed, 15 Nov 2017 10:40:46 +0000
>>> Subject: [PATCH] gnu: Add network-manager-vpnc.
>>>
>>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.
>
> Is this still being worked on/relevant? If so, I would like to verify
> that it does what we want it to do, and get it merged :-).

Closing, since you contributed a package for network-manager-vpnc back
in July of last year, with commit d376129f0b2 :-).

Maxim