From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eE2Rx-0002ZS-Pu for guix-patches@gnu.org; Sun, 12 Nov 2017 19:18:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eE2Ru-000439-Fy for guix-patches@gnu.org; Sun, 12 Nov 2017 19:18:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:56943) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eE2Ru-00042z-9e for guix-patches@gnu.org; Sun, 12 Nov 2017 19:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eE2Rt-0004cp-Rn for guix-patches@gnu.org; Sun, 12 Nov 2017 19:18:01 -0500 Subject: [bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into subsections. Resent-Message-ID: Date: Sun, 12 Nov 2017 13:17:25 -0600 From: Eric Bavier Message-ID: <20171112131725.7dbee7aa@centurylink.net> In-Reply-To: <20171112203644.GB10629@jasmine.lan> References: <20171112110233.1384-1-cmmarusich@gmail.com> <20171112110558.1447-1-cmmarusich@gmail.com> <20171112203644.GB10629@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/tVN9eX1ZoZTPfhX7H5k_PoL"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 29271@debbugs.gnu.org, Chris Marusich , myglc2@gmail.com --Sig_/tVN9eX1ZoZTPfhX7H5k_PoL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 12 Nov 2017 15:36:44 -0500 Leo Famulari wrote: > On Sun, Nov 12, 2017 at 03:05:58AM -0800, Chris Marusich wrote: > > +@anchor{fallback-option} > > @item --fallback > > -When substituting a pre-built binary fails, fall back to building > > -packages locally. > > +Attempt to build locally instead of issuing an error when substitutes > > +are enabled and a substitute is available, but the substitution attempt > > +fails (@pxref{Substitution Failure}). =20 >=20 > I was able to read this smaller change. I think the new sentence is too > byzantine. I know what --fallback does but I found this sentence hard to > understand. Same here. >=20 > The condition that determines whether we "attempt to build locally" > should be at the beginning of the sentence, like this: >=20 > "When substitutes are enabled and a substitute is available, but the > substitution fails, fall back to building the derivation locally." >=20 > This is basically the same as before, but with some more detail about > the condition. IMHO, the original text is just fine, and succinctly conveys the origin of the option name. Perhaps just add the cross reference. `~Eric --Sig_/tVN9eX1ZoZTPfhX7H5k_PoL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAloInkUACgkQ/XPKxxnT JWb3mQ//RoNg9lSNQWhGwmeKtxCYDWp624+dLCmiGZlP0FmugXDAEW+nZJVMpB+B 92Ry55JeMonHtNn77TfP7KAh0POYsHEmCJ2H9Nlx8i+lp/+KKsoUYqGwkcR/QKxx zyCde8tUdIbIp7UBjYLYd4e5bzjnrUMjzU99eXxLf3ndLYnqxyonFZ0cL8pJapn6 UgIfvqEH6vyKAtqP+2iLmuZ+6DuLfQ7GfjA5h3bsUDwscJybWfw0K5SZzCEVpOzm uhPtKBwA7xmkLpIRO6XGolMygL7bgWRLCfMFO4v7qhqh+byfqc5gNPvm2/HgPKO+ tTdB1ycYO7em5qicvkUKILFHGUzW424BrJsJ4YGgnpS2pPcxuVqClV54yDIkvSGS zyLQYalX5ytBspp7L1YSW/Ao9j5u0rghYFGEJqcUUPxPOkCOSFNWE3p1Jqv8C+3C siHBKee9mAdoznh5dahvRHTM1FT7D65MFxSMFhGjRTCRAsGe3/n31xeFIxoucc96 CaZnckegV9MBFd/gImVikRk9s96/7nH7/2TpGmOuoTm8jaJy/6XGPjETo+cEGdm6 cAeHvLcqAecm+u9pZGRIk+QIS0GhJ6dRyuoAMGNxQH35KamriCAQqrFzPUzFWEk4 AH3U+kUwwb/ILUFDUNfTWYOxvLT0QbpgR2nX0iKXqQ++6nxcjCA= =aytH -----END PGP SIGNATURE----- --Sig_/tVN9eX1ZoZTPfhX7H5k_PoL--