unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#29152] [PATCH] gnu: uboot: Fix same-arch? check.
@ 2017-11-05 11:06 Mathieu Othacehe
  2017-11-05 15:38 ` Danny Milosavljevic
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Othacehe @ 2017-11-05 11:06 UTC (permalink / raw)
  To: 29152

* gnu/packages/bootloaders.scm (make-u-boot-package): Compare %current-system
  to system associated to given triplet. Comparing a system and a triplet
  didn't make sense.
---
 gnu/packages/bootloaders.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index be3ea18fb..179e101fd 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -333,7 +333,8 @@ also initializes the boards (RAM etc).")
 
 (define (make-u-boot-package board triplet)
   "Returns a u-boot package for BOARD cross-compiled for TRIPLET."
-  (let ((same-arch? (if (string-prefix? (%current-system) triplet)
+  (let ((same-arch? (if (string-prefix? (%current-system)
+                                        (gnu-triplet->nix-system triplet))
                       `#t
                       `#f)))
     (package
-- 
2.15.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#29152] [PATCH] gnu: uboot: Fix same-arch? check.
  2017-11-05 11:06 [bug#29152] [PATCH] gnu: uboot: Fix same-arch? check Mathieu Othacehe
@ 2017-11-05 15:38 ` Danny Milosavljevic
  2017-11-06 18:54   ` Mathieu Othacehe
  0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2017-11-05 15:38 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 29152

Good catch! LGTM!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#29152] [PATCH] gnu: uboot: Fix same-arch? check.
  2017-11-05 15:38 ` Danny Milosavljevic
@ 2017-11-06 18:54   ` Mathieu Othacehe
  0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Othacehe @ 2017-11-06 18:54 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 29152


> Good catch! LGTM!

Thanks Danny, pushed as 2ac42fe51fcbd9b9f36fcfce350da2d483dc0cc9.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-06 18:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-05 11:06 [bug#29152] [PATCH] gnu: uboot: Fix same-arch? check Mathieu Othacehe
2017-11-05 15:38 ` Danny Milosavljevic
2017-11-06 18:54   ` Mathieu Othacehe

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).