From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAEFA-0000eW-5S for guix-patches@gnu.org; Thu, 02 Nov 2017 08:05:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAEF4-0006QO-66 for guix-patches@gnu.org; Thu, 02 Nov 2017 08:05:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38300) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAEF4-0006QB-2R for guix-patches@gnu.org; Thu, 02 Nov 2017 08:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eAEF3-0001Zq-NE for guix-patches@gnu.org; Thu, 02 Nov 2017 08:05:01 -0400 Subject: [bug#29061] Java patches Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAEEl-0000NJ-9o for guix-patches@gnu.org; Thu, 02 Nov 2017 08:04:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAEEh-0006BX-Fl for guix-patches@gnu.org; Thu, 02 Nov 2017 08:04:43 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:36008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eAEEh-00067r-6S for guix-patches@gnu.org; Thu, 02 Nov 2017 08:04:39 -0400 Received: from polymos.lepiller.eu (l9.lns-se1200-ld-01-t2-31-35-229-149.dsl.dyn.abo.bbox.fr [31.35.229.149]) by lepiller.eu (OpenSMTPD) with ESMTPSA id ae8432ed (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Thu, 2 Nov 2017 12:06:15 +0000 (UTC) Date: Thu, 2 Nov 2017 13:09:17 +0100 From: Julien Lepiller Message-ID: <20171102130917.0b81e32b@polymos.lepiller.eu> In-Reply-To: <36548D50-8D22-4731-9BE4-510F984D1195@lepiller.eu> References: <20171029214709.7a610dfe@polymos.lepiller.eu> <20171029215438.6d9e001d@polymos.lepiller.eu> <20171030145536.GC27298@jasmine.lan> <36548D50-8D22-4731-9BE4-510F984D1195@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 29061@debbugs.gnu.org > > I think I messed up these patches... I use git rebase a lot to fix > things, but sometimes it does weird things. The result of applying > these patches is working though. > > I don't think the unzip phase has anything to do with > ant-build-system. In this case, the "source" archive contains other > archives (source, bin) and only one is interesting for our purpose, > but its name is probably difficult to guess. > > Re the patch, I'm familiar enough with java to produce it, but not to > understand why it's needed. I will report compiling issues upstream. > > Thanks for the review, I will fix the issues you mentionned and push > when I have time. Fixed and pushed as a6dd06d0e2297c4eabbfcb5461ee6560cd0b2f95 - bb27eb0dbfa27d4aeb7525ee5ef70f624506af0b. Thank you for the review!