unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: 29114@debbugs.gnu.org
Subject: [bug#29114] [PATCH 05/10] gnu: krunner: Make some tests pass.
Date: Thu,  2 Nov 2017 09:47:45 +0100	[thread overview]
Message-ID: <20171102084750.21368-5-h.goebel@crazy-compilers.com> (raw)
In-Reply-To: <20171102084750.21368-1-h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm[arguments]
  <#:tests?>: Remove.
  <#:phases>[fix-paths-for-test'] New phase.
  <#:phases>[check-setup]: Set $HOME. Blacklist a failing new-in-5.39.0 test.
---
 gnu/packages/kde-frameworks.scm | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 6f261afd1..78290cf1a 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2747,13 +2747,26 @@ to easily extend the contacts collection.")
        ("solid" ,solid)
        ("threadweaver" ,threadweaver)))
     (arguments
-     `(#:tests? #f ; FIXME: 1/1 tests fail.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'fix-paths-for-test
+           ;; This test tries to access paths like /home, /usr/bin and /bin/ls
+           ;; which don't exist in the build-container. Change to existing paths.
+           (lambda _
+             (substitute* "autotests/runnercontexttest.cpp"
+               (("/home\"") "/tmp\"") ;; single path-part
+               (("//usr/bin\"") (string-append (getcwd) "\"")) ;; multiple path-parts
+               (("/bin/ls" path)
+                (string-append (assoc-ref %build-inputs "coreutils") path)))))
          (add-before 'check 'check-setup
            (lambda _
+             (setenv "HOME" (getcwd))
              ;; make Qt render "offscreen", required for tests
              (setenv "QT_QPA_PLATFORM" "offscreen")
+             ;; Blacklist a failing test-function. TODO: Make it pass.
+             (with-output-to-file "bin/BLACKLIST"
+               (lambda _
+                 (display "[testMatch]\n*\n")))
              #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Framework for Plasma runners")
-- 
2.13.5

  parent reply	other threads:[~2017-11-02  8:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02  8:46 [bug#29114] [PATCH 00/10] KDE Updates and cleanups Hartmut Goebel
2017-11-02  8:47 ` [bug#29114] [PATCH 01/10] gnu: extra-cmake-modules: Install pri-files into lib/qt5/ Hartmut Goebel
2017-11-02  8:47   ` [bug#29114] [PATCH 02/10] gnu: kde-frameworks: Update to 5.39.0 Hartmut Goebel
2017-11-02  8:47   ` [bug#29114] [PATCH 03/10] gnu: kimageformats: Update comment Hartmut Goebel
2017-11-02  8:47   ` [bug#29114] [PATCH 04/10] gnu: kdelibs4support: Make test kstandarddirstest pass Hartmut Goebel
2017-11-02  8:47   ` Hartmut Goebel [this message]
2017-11-02  8:47   ` [bug#29114] [PATCH 06/10] gnu: solid: Enable building interface for qml Hartmut Goebel
2017-11-02  8:47   ` [bug#29114] [PATCH 07/10] gnu: libksysguard: Update to 5.11.2 Hartmut Goebel
2017-11-02 20:37     ` Marius Bakke
2017-11-02 21:43       ` Hartmut Goebel
2017-11-02  8:47   ` [bug#29114] [PATCH 08/10] gnu: kactivities: Move to tier 2 Hartmut Goebel
2017-11-02  8:47   ` [bug#29114] [PATCH 09/10] gnu: kdewebkit: Move to be in alphabetical order Hartmut Goebel
2017-11-02  8:47   ` [bug#29114] [PATCH 10/10] gnu: prison: " Hartmut Goebel
2017-11-02 20:39 ` [bug#29114] [PATCH 00/10] KDE Updates and cleanups Marius Bakke
     [not found] ` <handler.29114.B.150961240712169.ack@debbugs.gnu.org>
2017-11-05  9:58   ` bug#29114: Acknowledgement ([PATCH 00/10] KDE Updates and cleanups) Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102084750.21368-5-h.goebel@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=29114@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).