unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: 29103@debbugs.gnu.org
Subject: [bug#29103] [PATCH 4/6] gnu: krunner: Make all tests pass.
Date: Wed,  1 Nov 2017 15:41:44 +0100	[thread overview]
Message-ID: <20171101144146.15687-4-h.goebel@crazy-compilers.com> (raw)
In-Reply-To: <20171101144146.15687-1-h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm[arguments]
  <#:tests?>: Remove.
  <#:phases>'fix-paths-for-test': New phase.
---
 gnu/packages/kde-frameworks.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c1cf4e4aa..78290cf1a 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2747,9 +2747,17 @@ to easily extend the contacts collection.")
        ("solid" ,solid)
        ("threadweaver" ,threadweaver)))
     (arguments
-     `(#:tests? #f ; FIXME: 1/1 tests fail.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'fix-paths-for-test
+           ;; This test tries to access paths like /home, /usr/bin and /bin/ls
+           ;; which don't exist in the build-container. Change to existing paths.
+           (lambda _
+             (substitute* "autotests/runnercontexttest.cpp"
+               (("/home\"") "/tmp\"") ;; single path-part
+               (("//usr/bin\"") (string-append (getcwd) "\"")) ;; multiple path-parts
+               (("/bin/ls" path)
+                (string-append (assoc-ref %build-inputs "coreutils") path)))))
          (add-before 'check 'check-setup
            (lambda _
              (setenv "HOME" (getcwd))
-- 
2.13.5

  parent reply	other threads:[~2017-11-01 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 12:48 [bug#29103] [PATCH 0/6] KDE Updates Hartmut Goebel
2017-11-01 14:41 ` [bug#29103] [PATCH 1/6] gnu: kde-frameworks: Update to 5.39.0 Hartmut Goebel
2017-11-01 14:41   ` [bug#29103] [PATCH 2/6] gnu: kimageformats: Update comment Hartmut Goebel
2017-11-01 14:41   ` [bug#29103] [PATCH 3/6] gnu: kdelibs4support: Make test kstandarddirstest pass Hartmut Goebel
2017-11-01 14:41   ` Hartmut Goebel [this message]
2017-11-01 14:41   ` [bug#29103] [PATCH 5/6] gnu: solid: Enable building interface for qml Hartmut Goebel
2017-11-01 14:41   ` [bug#29103] [PATCH 6/6] gnu: libksysguard: Update to 5.11.2 Hartmut Goebel
     [not found] ` <handler.29103.B.15095405208424.ack@debbugs.gnu.org>
2017-11-02  8:27   ` bug#29103: Acknowledgement ([PATCH 0/6] KDE Updates) Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171101144146.15687-4-h.goebel@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=29103@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).