From: Leo Famulari <leo@famulari.name>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 29061@debbugs.gnu.org
Subject: [bug#29061] Java patches
Date: Mon, 30 Oct 2017 10:55:36 -0400 [thread overview]
Message-ID: <20171030145536.GC27298@jasmine.lan> (raw)
In-Reply-To: <20171029215438.6d9e001d@polymos.lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 3585 bytes --]
On Sun, Oct 29, 2017 at 09:54:38PM +0100, Julien Lepiller wrote:
> On Sun, 29 Oct 2017 21:47:09 +0100
> Julien Lepiller <julien@lepiller.eu> wrote:
>
> > Hi, here are 22 new java patches that get us a bit closer to maven :)
> >
> >
> >
>
> Somehow I can't use git send-email, so here are the patches.
Thanks for all this!
This is a cursory review. I trust that, in general, these packages are
the latest upstream versions (or there is a code comment explaining why
not), the licenses are free and correctly listed, and that everything
seems to work.
Beyond that, I think your work on Java packaging falls under the commit
policy mentioned in HACKING, about "allowing individuals to commit
directly on non-controversial changes on parts they’re familiar with":
https://git.savannah.gnu.org/cgit/guix.git/tree/HACKING?id=faffd821f35dc34944226a992033df5a4be60cb1#n63
> From 10c1801922abbc82e48360b22d5d8681449715b9 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 24 Oct 2017 22:05:04 +0200
> Subject: [PATCH 01/22] gnu: Add java-bsh.
>
> * gnu/packages/java.scm (java-bsh): New variable.
> From f02f8c081e1627180e9f78393c3ab1fd8ad8b60b Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 24 Oct 2017 22:05:04 +0200
> Subject: [PATCH 02/22] gnu: Add java-bsh.
>
> * gnu/packages/java.scm (java-bsh): New variable.
These two patches can be squashed into one, right?
> From 016af8aad804f488e530ae680855f175e8d8cfd1 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 24 Oct 2017 22:08:38 +0200
> Subject: [PATCH 03/22] gnu: Add java-jmock.
>
> * gnu/packages/java.scm (java-jmock): New variable.
This patch looks a bit weird, as if there are two copies of the package
or something.
> From ff6b73b44424949796b18689e4c5aba156573b41 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 24 Oct 2017 22:30:48 +0200
> Subject: [PATCH 10/22] gnu: Add java-mvel2.
>
> * gnu/packages/java.scm (java-mvel2): New variable.
This patch also adds java-jnacl. It should be added in its own patch,
right?
> From 3ea3acbd6cc141687107b1ad2a14bad7cefb9ebe Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 24 Oct 2017 22:36:11 +0200
> Subject: [PATCH 12/22] gnu: Add java-bouncycastle-bcprov.
>
> * gnu/packages/java.scm (java-bouncycastle-bcprov): New variable.
[...]
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'unzip-src
> + (lambda _
> + (mkdir-p "src")
> + (with-directory-excursion "src"
> + (zero? (system* "unzip" "../src.zip"))))))))
Not a blocker for this patch series — I notice this custom unzip
phase in a few packages. Should it be added to ant-build-system?
> From d300f5ec70007f7554f14031b2af2def5ad3f439 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Wed, 25 Oct 2017 23:05:10 +0200
> Subject: [PATCH 16/22] gnu: Add java-powermock-reflect.
>
> * gnu/packages/java.scm (java-powermock-reflect): New variable.
> ---
> gnu/local.mk | 1 +
> gnu/packages/java.scm | 38 +++++
> .../patches/java-powermock-fix-java-files.patch | 178 +++++++++++++++++++++
Please mention the new patch file and its addition to gnu/local.mk in
the commit message.
Also, do you think the patch should be submitted upstream?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-30 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 20:47 [bug#29061] Java patches Julien Lepiller
2017-10-29 20:54 ` Julien Lepiller
2017-10-30 14:55 ` Leo Famulari [this message]
2017-10-30 15:23 ` Julien Lepiller
2017-11-02 12:09 ` Julien Lepiller
2017-11-02 12:11 ` bug#29061: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030145536.GC27298@jasmine.lan \
--to=leo@famulari.name \
--cc=29061@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).