From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41012)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e8fEc-0005sq-8L
	for guix-patches@gnu.org; Sun, 29 Oct 2017 00:30:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e8fEZ-0002es-3h
	for guix-patches@gnu.org; Sun, 29 Oct 2017 00:30:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:59218)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e8fEY-0002ef-VR
	for guix-patches@gnu.org; Sun, 29 Oct 2017 00:30:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e8fEY-0001BO-F6
	for guix-patches@gnu.org; Sun, 29 Oct 2017 00:30:02 -0400
Subject: bug#29030: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as
	TODO.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.29030.D29030.15092513434445.done@debbugs.gnu.org>
Date: Sat, 28 Oct 2017 18:29:07 -0500
From: Eric Bavier <ericbavier@centurylink.net>
Message-ID: <20171028182907.60b8629e@centurylink.net>
In-Reply-To: <87po977ls3.fsf@gnu.org>
References: <CY4PR11MB1718DEC796149A5DE28DC5F1B75A0@CY4PR11MB1718.namprd11.prod.outlook.com>
	<87po977ls3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 29030-done@debbugs.gnu.org

On Sat, 28 Oct 2017 09:51:24 +0200
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> Hi Eric,
>=20
> Eric Bavier <bavier@cray.com> skribis:
>=20
> > On my system, perl-sys-cpu's tests fail because of differences in the i=
nformation available in /proc/cpuinfo.
> >
> > Debian's patch for this perl module seemed nice: rather than trying to =
fix the related functions, just concede that the module is mostly used just=
 to read the number of available processors and mark the other tests as "TO=
DO". =20
>=20
> [...]
>=20
> > +              (snippet
> > +               '(begin
> > +                  ;; Replace test with one that marks cpu_clock and cp=
u_type
> > +                  ;; as TODO.  Borrowed from Debian. =20
>=20
> Perhaps make it clear in the comment that we do this because the
> contents of /proc/cpuinfo differ based on different factors.

OK.

> Otherwise LGTM, thanks!

Thanks, pushed in 9de52b56438674c0d0f92be34cebf5f1a38a6bfa.

`~Eric