unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#28986] [PATCH] gnu: Add r-tgstat.
@ 2017-10-22 11:56 Ricardo Wurmus
  2017-10-26  5:13 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2017-10-22 11:56 UTC (permalink / raw)
  To: 28986; +Cc: Ricardo Wurmus

* gnu/packages/statistics.scm (r-tgstat): New variable.
---
 gnu/packages/statistics.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index b3ebd5abb..6c8f7b5fa 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -27,6 +27,7 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix hg-download)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system r)
@@ -5442,3 +5443,37 @@ the least concave majorant (LCM), for the half-normal and correlation
 distributions, and for computing empirical higher criticism (HC) scores and
 the corresponding decision threshold.")
     (license license:gpl3+)))
+
+(define-public r-tgstat
+  (let ((changeset "4f8e60c03598f49aff6f5beeab40f2b995377e9f")
+        (revision "1"))
+    (package
+      (name "r-tgstat")
+      (version (string-append "1.0.2-" revision "." (string-take changeset 7)))
+      (source
+       (origin
+         (method hg-fetch)
+         (uri (hg-reference
+               (url "https://bitbucket.org/tanaylab/tgstat")
+               (changeset changeset)))
+         (sha256
+          (base32
+           "0ilkkyximy77zbncm91kdfqbxf0qyndg16pd3q3p6a3xc9qcmxvn"))))
+      (build-system r-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'fix-isnan
+             (lambda _
+               (substitute* "src/tgstat.h"
+                 (("#define isnan ::isnan")
+                  "#define isnan std::isnan"))
+               #t)))))
+      (propagated-inputs
+       `(("r-rcpp" ,r-rcpp)))
+      (home-page "https://bitbucket.org/tanaylab/tgstat/")
+      (synopsis "Tanay's group statistical utilities")
+      (description
+       "The goal of tgstat is to provide fast and efficient statistical
+tools.")
+      (license license:gpl2))))
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#28986] [PATCH] gnu: Add r-tgstat.
  2017-10-22 11:56 [bug#28986] [PATCH] gnu: Add r-tgstat Ricardo Wurmus
@ 2017-10-26  5:13 ` Ludovic Courtès
  2017-10-26  7:56   ` Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2017-10-26  5:13 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 28986

Hi,

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/statistics.scm (r-tgstat): New variable.

[...]

> +      (home-page "https://bitbucket.org/tanaylab/tgstat/")
> +      (synopsis "Tanay's group statistical utilities")
> +      (description
> +       "The goal of tgstat is to provide fast and efficient statistical
> +tools.")

It would be nice to elaborate, but otherwise LGTM.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#28986] [PATCH] gnu: Add r-tgstat.
  2017-10-26  5:13 ` Ludovic Courtès
@ 2017-10-26  7:56   ` Ricardo Wurmus
  2017-10-30 11:12     ` bug#28986: " Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2017-10-26  7:56 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 28986


Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/statistics.scm (r-tgstat): New variable.
>
> [...]
>
>> +      (home-page "https://bitbucket.org/tanaylab/tgstat/")
>> +      (synopsis "Tanay's group statistical utilities")
>> +      (description
>> +       "The goal of tgstat is to provide fast and efficient statistical
>> +tools.")
>
> It would be nice to elaborate, but otherwise LGTM.

Yes, I agree.  Like many R packages this is just a bunch of unrelated
functions that are generic enough to get their own package.  Having so
many of these packages is a cultural problem in R…

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#28986: [PATCH] gnu: Add r-tgstat.
  2017-10-26  7:56   ` Ricardo Wurmus
@ 2017-10-30 11:12     ` Ricardo Wurmus
  0 siblings, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2017-10-30 11:12 UTC (permalink / raw)
  To: 28986-done


Ricardo Wurmus <rekado@elephly.net> writes:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> * gnu/packages/statistics.scm (r-tgstat): New variable.
>>
>> [...]
>>
>>> +      (home-page "https://bitbucket.org/tanaylab/tgstat/")
>>> +      (synopsis "Tanay's group statistical utilities")
>>> +      (description
>>> +       "The goal of tgstat is to provide fast and efficient statistical
>>> +tools.")
>>
>> It would be nice to elaborate, but otherwise LGTM.
>
> Yes, I agree.  Like many R packages this is just a bunch of unrelated
> functions that are generic enough to get their own package.  Having so
> many of these packages is a cultural problem in R…

I pushed it to master as is.  Closing.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-30 23:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-22 11:56 [bug#28986] [PATCH] gnu: Add r-tgstat Ricardo Wurmus
2017-10-26  5:13 ` Ludovic Courtès
2017-10-26  7:56   ` Ricardo Wurmus
2017-10-30 11:12     ` bug#28986: " Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).