unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies)
@ 2017-10-20 19:35 ng0
  2017-10-21 21:29 ` ng0
  0 siblings, 1 reply; 7+ messages in thread
From: ng0 @ 2017-10-20 19:35 UTC (permalink / raw)
  To: 28917


[-- Attachment #1.1: Type: text/plain, Size: 247 bytes --]

This adds gst-transcoder, python-pycanberra and gavl
required for pitivi.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org

[-- Attachment #1.2: 0001-gnu-Add-gst-transcoder.patch --]
[-- Type: text/plain, Size: 2477 bytes --]

From 16d6b89abd22f9aff3e15e12649a7658d4ad14fc Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Mon, 16 Oct 2017 05:41:50 +0000
Subject: [PATCH 1/3] gnu: Add gst-transcoder.

* gnu/packages/video.scm (gst-transcoder): New variable.
---
 gnu/packages/video.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index c1856b62f..b7051383c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -11,7 +11,7 @@
 ;;; Copyright © 2016 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman@gmail.com>
 ;;; Copyright © 2016 Andy Patterson <ajpatter@uwaterloo.ca>
-;;; Copyright © 2016, 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2016, 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2017 Feng Shu <tumashu@163.com>
@@ -49,6 +49,7 @@
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
+  #:use-module (guix build-system meson)
   #:use-module (guix build-system python)
   #:use-module (guix build-system waf)
   #:use-module (gnu packages)
@@ -2385,3 +2386,30 @@ tables")
 generation of MPEG TS and DVB PSI tables according to standards ISO/IEC 13818s
 and ITU-T H.222.0.")
     (license license:lgpl2.1)))
+
+(define-public gst-transcoder
+  (package
+    (name "gst-transcoder")
+    (version "1.12.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/pitivi/gst-transcoder/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0cnwmrsd321s02ff91m3j27ydj7f8wks0jvmp5admlhka6z7zxm9"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("gobject-introspection" ,gobject-introspection)
+       ("glib" ,glib)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)))
+    (native-inputs
+     `(("python" ,python)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/pitivi/gst-transcoder/")
+    (synopsis "GStreamer Transcoding API")
+    (description "GStreamer Transcoding API")
+    (license license:lgpl2.1)))
-- 
2.14.2


[-- Attachment #1.3: 0002-gnu-Add-python-pycanberra.patch --]
[-- Type: text/plain, Size: 3766 bytes --]

From 882f2958c2e3c99d6d5d15f038f0261402bea492 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Mon, 16 Oct 2017 15:31:04 +0000
Subject: [PATCH 2/3] gnu: Add python-pycanberra.

* gnu/packages/libcanberra.scm (python-pycanberra): New variable.
---
 gnu/packages/libcanberra.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/libcanberra.scm b/gnu/packages/libcanberra.scm
index 941d3dcc4..81f20ba6d 100644
--- a/gnu/packages/libcanberra.scm
+++ b/gnu/packages/libcanberra.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2016 Fabian Harfert <fhmgufs@web.de>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,8 +25,11 @@
   #:use-module (gnu packages)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (guix build utils)
+  #:use-module (guix utils)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
@@ -33,6 +37,7 @@
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages xiph))
 
 (define-public libcanberra
@@ -126,3 +131,49 @@ sounds for various system events.")
     (license (list cc-by-sa4.0 cc-by3.0 gpl2 gpl2+))
 
     (home-page "http://www.freedesktop.org/wiki/Specifications/sound-theme-spec/")))
+
+(define-public python-pycanberra
+  (let ((commit "88c53cd44a626ede3b07dab0b548f8bcfda42867"))
+    (package
+      (name "python-pycanberra")
+      (version (string-append "0.0." (string-take commit 7)))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/totdb/pycanberra")
+               (commit commit)))
+         (file-name (string-append name "-" version "-checkout"))
+         (sha256
+          (base32
+           "04xv5g599s5bvr1pd273hbb5kq1n194sjwhgj39jgh1l3g5w9k3y"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:imported-modules (,@%gnu-build-system-modules
+                             (guix build python-build-system))
+         #:tests? #f ;No tests included.
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure)
+           (delete 'build)
+           (replace 'install
+             (lambda* (#:key outputs inputs #:allow-other-keys)
+               (let* ((python (assoc-ref inputs "python"))
+                      (python-version ((@@ (guix build python-build-system)
+                                           get-python-version)
+                                       python))
+                      (out (assoc-ref outputs "out"))
+                      (python-sitedir (string-append out "/lib/python"
+                                                     python-version
+                                                     "/site-packages")))
+                 (install-file "pycanberra.py" python-sitedir))
+                 #t)))))
+      (propagated-inputs
+       `(("libcanberra" ,libcanberra)))
+      (native-inputs
+       `(("python" ,python)))
+      (synopsis "Ctypes wrapper for the libcanberra API")
+      (description
+       "Pycanberra is a basic Python wrapper for libcanberra.")
+      (home-page "https://github.com/totdb/pycanberra")
+      (license lgpl2.1+))))
-- 
2.14.2


[-- Attachment #1.4: 0003-gnu-Add-gavl.patch --]
[-- Type: text/plain, Size: 2335 bytes --]

From c6e4c4502eb8dbeeeac2ba60aeeede3a7e1242fe Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Fri, 20 Oct 2017 18:32:12 +0000
Subject: [PATCH 3/3] gnu: Add gavl.

* gnu/packages/video.scm (gavl): New variable.
---
 gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index b7051383c..ea55ead3d 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -69,6 +69,7 @@
   #:use-module (gnu packages databases)
   #:use-module (gnu packages dejagnu)
   #:use-module (gnu packages docbook)
+  #:use-module (gnu packages documentation)
   #:use-module (gnu packages elf)
   #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
@@ -2413,3 +2414,36 @@ and ITU-T H.222.0.")
     (synopsis "GStreamer Transcoding API")
     (description "GStreamer Transcoding API")
     (license license:lgpl2.1)))
+
+(define-public gavl
+  (package
+    (name "gavl")
+    (version "1.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/gmerlin/"
+                           name "/" version "/"
+                           name "-" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("doxygen" ,doxygen)))
+    (home-page "http://gmerlin.sourceforge.net")
+    (synopsis "low level library for multimedia API building")
+    (description
+     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
+library, upon which multimedia APIs can be built.  Gavl handles all the
+details of audio and video formats like colorspaces, samplerates,
+multichannel configurations etc.  It provides standardized definitions for
+those formats as well as container structures for carrying audio samples or
+video images inside an application.
+
+In addition, it handles the sometimes ugly task to convert between all
+these formats and provides some elementary operations (copying, scaling,
+alpha blending etc).")
+    (license license:gpl3)))
-- 
2.14.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies)
  2017-10-20 19:35 [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies) ng0
@ 2017-10-21 21:29 ` ng0
  2017-10-21 21:32   ` ng0
  0 siblings, 1 reply; 7+ messages in thread
From: ng0 @ 2017-10-21 21:29 UTC (permalink / raw)
  To: 28917

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

ng0 transcribed 10K bytes:
> This adds gst-transcoder, python-pycanberra and gavl
> required for pitivi.

Yarg. I've sent the wrong python-pycanberra. Correction incoming.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies)
  2017-10-21 21:29 ` ng0
@ 2017-10-21 21:32   ` ng0
  2017-10-25 14:24     ` Kei Kebreau
  0 siblings, 1 reply; 7+ messages in thread
From: ng0 @ 2017-10-21 21:32 UTC (permalink / raw)
  To: 28917


[-- Attachment #1.1: Type: text/plain, Size: 413 bytes --]

ng0 transcribed 1.4K bytes:
> ng0 transcribed 10K bytes:
> > This adds gst-transcoder, python-pycanberra and gavl
> > required for pitivi.
> 
> Yarg. I've sent the wrong python-pycanberra. Correction incoming.

Correction appended.

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org

[-- Attachment #1.2: 0001-gnu-Add-gst-transcoder.patch --]
[-- Type: text/plain, Size: 2560 bytes --]

From cf2e3bae975e900dcb4cfdc7c573cdd6d25459ba Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Mon, 16 Oct 2017 05:41:50 +0000
Subject: [PATCH 1/3] gnu: Add gst-transcoder.

* gnu/packages/video.scm (gst-transcoder): New variable.
---
 gnu/packages/video.scm | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 63824f6c5..baebe6404 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -11,7 +11,7 @@
 ;;; Copyright © 2016 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman@gmail.com>
 ;;; Copyright © 2016 Andy Patterson <ajpatter@uwaterloo.ca>
-;;; Copyright © 2016, 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2016, 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2017 Feng Shu <tumashu@163.com>
@@ -49,6 +49,7 @@
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
+  #:use-module (guix build-system meson)
   #:use-module (guix build-system python)
   #:use-module (guix build-system waf)
   #:use-module (gnu packages)
@@ -2472,3 +2473,29 @@ tools for styling them, including a built-in real-time video preview.")
    ; by upstream). See https://github.com/Aegisub/Aegisub/blob/master/LICENCE
    ; src/MatroskaParser.(c|h) is under bsd-3 with permission from the author
 
+(define-public gst-transcoder
+  (package
+    (name "gst-transcoder")
+    (version "1.12.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/pitivi/gst-transcoder/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0cnwmrsd321s02ff91m3j27ydj7f8wks0jvmp5admlhka6z7zxm9"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("gobject-introspection" ,gobject-introspection)
+       ("glib" ,glib)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)))
+    (native-inputs
+     `(("python" ,python)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/pitivi/gst-transcoder/")
+    (synopsis "GStreamer Transcoding API")
+    (description "GStreamer Transcoding API")
+    (license license:lgpl2.1)))
-- 
2.14.2


[-- Attachment #1.3: 0002-gnu-Add-python-pycanberra.patch --]
[-- Type: text/plain, Size: 2556 bytes --]

From b9db8b2e43434def418e69e108279f41b0dd1455 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Mon, 16 Oct 2017 15:31:04 +0000
Subject: [PATCH 2/3] gnu: Add python-pycanberra.

* gnu/packages/libcanberra.scm (python-pycanberra): New variable.
---
 gnu/packages/libcanberra.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/libcanberra.scm b/gnu/packages/libcanberra.scm
index 941d3dcc4..9af6b40ff 100644
--- a/gnu/packages/libcanberra.scm
+++ b/gnu/packages/libcanberra.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2016 Fabian Harfert <fhmgufs@web.de>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,8 +25,11 @@
   #:use-module (gnu packages)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (guix build utils)
+  #:use-module (guix utils)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
@@ -33,6 +37,7 @@
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages xiph))
 
 (define-public libcanberra
@@ -126,3 +131,26 @@ sounds for various system events.")
     (license (list cc-by-sa4.0 cc-by3.0 gpl2 gpl2+))
 
     (home-page "http://www.freedesktop.org/wiki/Specifications/sound-theme-spec/")))
+
+(define-public python-pycanberra
+  (package
+    (name "python-pycanberra")
+    (version "0.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dist.ng0.infotropique.org/releases/"
+                           "pycanberra/pycanberra-" version ".tar.xz"))
+       (sha256
+        (base32
+         "16jjf8fcgaprmz6jacsxrh17l1ad891fns38bxv49lg3s3mn1nj2"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;No tests included.
+    (propagated-inputs
+     `(("libcanberra" ,libcanberra)))
+    (synopsis "Ctypes wrapper for the libcanberra API")
+    (description
+     "Pycanberra is a basic Python wrapper for libcanberra.")
+    (home-page "https://git.ng0.infotropique.org/pycanberra/")
+    (license lgpl2.1+)))
-- 
2.14.2


[-- Attachment #1.4: 0003-gnu-Add-gavl.patch --]
[-- Type: text/plain, Size: 2386 bytes --]

From b97a66068be69bc53d654d6204cdb1df5c889dd6 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Fri, 20 Oct 2017 18:32:12 +0000
Subject: [PATCH 3/3] gnu: Add gavl.

* gnu/packages/video.scm (gavl): New variable.
---
 gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index baebe6404..7294c5bf2 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -69,6 +69,7 @@
   #:use-module (gnu packages databases)
   #:use-module (gnu packages dejagnu)
   #:use-module (gnu packages docbook)
+  #:use-module (gnu packages documentation)
   #:use-module (gnu packages elf)
   #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
@@ -2499,3 +2500,36 @@ tools for styling them, including a built-in real-time video preview.")
     (synopsis "GStreamer Transcoding API")
     (description "GStreamer Transcoding API")
     (license license:lgpl2.1)))
+
+(define-public gavl
+  (package
+    (name "gavl")
+    (version "1.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/gmerlin/"
+                           name "/" version "/"
+                           name "-" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("doxygen" ,doxygen)))
+    (home-page "http://gmerlin.sourceforge.net")
+    (synopsis "low level library for multimedia API building")
+    (description
+     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
+library, upon which multimedia APIs can be built.  Gavl handles all the
+details of audio and video formats like colorspaces, samplerates,
+multichannel configurations etc.  It provides standardized definitions for
+those formats as well as container structures for carrying audio samples or
+video images inside an application.
+
+In addition, it handles the sometimes ugly task to convert between all
+these formats and provides some elementary operations (copying, scaling,
+alpha blending etc).")
+    (license license:gpl3)))
-- 
2.14.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies)
  2017-10-21 21:32   ` ng0
@ 2017-10-25 14:24     ` Kei Kebreau
  2017-10-26 20:07       ` ng0
  0 siblings, 1 reply; 7+ messages in thread
From: Kei Kebreau @ 2017-10-25 14:24 UTC (permalink / raw)
  To: ng0; +Cc: 28917

ng0 <ng0@infotropique.org> writes:

> ng0 transcribed 1.4K bytes:
>> ng0 transcribed 10K bytes:
>> > This adds gst-transcoder, python-pycanberra and gavl
>> > required for pitivi.
>> 
>> Yarg. I've sent the wrong python-pycanberra. Correction incoming.
>
> Correction appended.
>
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://dist.ng0.infotropique.org/dist/keys/
> https://www.infotropique.org https://ng0.infotropique.org
>
>
>
> From b97a66068be69bc53d654d6204cdb1df5c889dd6 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@infotropique.org>
> Date: Fri, 20 Oct 2017 18:32:12 +0000
> Subject: [PATCH 3/3] gnu: Add gavl.
>
> * gnu/packages/video.scm (gavl): New variable.
> ---
>  gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index baebe6404..7294c5bf2 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -69,6 +69,7 @@
>    #:use-module (gnu packages databases)
>    #:use-module (gnu packages dejagnu)
>    #:use-module (gnu packages docbook)
> +  #:use-module (gnu packages documentation)
>    #:use-module (gnu packages elf)
>    #:use-module (gnu packages file)
>    #:use-module (gnu packages flex)
> @@ -2499,3 +2500,36 @@ tools for styling them, including a built-in real-time video preview.")
>      (synopsis "GStreamer Transcoding API")
>      (description "GStreamer Transcoding API")
>      (license license:lgpl2.1)))
> +
> +(define-public gavl
> +  (package
> +    (name "gavl")
> +    (version "1.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/gmerlin/"
> +                           name "/" version "/"
> +                           name "-" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("doxygen" ,doxygen)))
> +    (home-page "http://gmerlin.sourceforge.net")
> +    (synopsis "low level library for multimedia API building")
> +    (description
> +     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
> +library, upon which multimedia APIs can be built.  Gavl handles all the
> +details of audio and video formats like colorspaces, samplerates,

"samplerates" should be two words.

> +multichannel configurations etc.  It provides standardized definitions for
                              ^
               a comma after "configurations" would be nice.
> +those formats as well as container structures for carrying audio samples or
> +video images inside an application.
> +
> +In addition, it handles the sometimes ugly task to convert between all

Instead of "ugly task to convert..." perhaps we can say "ugly task of
converting..."

> +these formats and provides some elementary operations (copying, scaling,
> +alpha blending etc).")
> +    (license license:gpl3)))

I suppose the changes to gavl's description could be forwarded upstream,
seeing as this is the same description as the one
gmerlin.sourceforge.net uses.

Everything else LGTM. Thanks for working on this!

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies)
  2017-10-25 14:24     ` Kei Kebreau
@ 2017-10-26 20:07       ` ng0
  2017-10-27 12:28         ` Kei Kebreau
  0 siblings, 1 reply; 7+ messages in thread
From: ng0 @ 2017-10-26 20:07 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 28917


[-- Attachment #1.1: Type: text/plain, Size: 4011 bytes --]

Kei Kebreau transcribed 3.2K bytes:
> ng0 <ng0@infotropique.org> writes:
> 
> > ng0 transcribed 1.4K bytes:
> >> ng0 transcribed 10K bytes:
> >> > This adds gst-transcoder, python-pycanberra and gavl
> >> > required for pitivi.
> >> 
> >> Yarg. I've sent the wrong python-pycanberra. Correction incoming.
> >
> > Correction appended.
> >
> > -- 
> > ng0
> > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> > GnuPG: https://dist.ng0.infotropique.org/dist/keys/
> > https://www.infotropique.org https://ng0.infotropique.org
> >
> >
> >
> > From b97a66068be69bc53d654d6204cdb1df5c889dd6 Mon Sep 17 00:00:00 2001
> > From: ng0 <ng0@infotropique.org>
> > Date: Fri, 20 Oct 2017 18:32:12 +0000
> > Subject: [PATCH 3/3] gnu: Add gavl.
> >
> > * gnu/packages/video.scm (gavl): New variable.
> > ---
> >  gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >
> > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> > index baebe6404..7294c5bf2 100644
> > --- a/gnu/packages/video.scm
> > +++ b/gnu/packages/video.scm
> > @@ -69,6 +69,7 @@
> >    #:use-module (gnu packages databases)
> >    #:use-module (gnu packages dejagnu)
> >    #:use-module (gnu packages docbook)
> > +  #:use-module (gnu packages documentation)
> >    #:use-module (gnu packages elf)
> >    #:use-module (gnu packages file)
> >    #:use-module (gnu packages flex)
> > @@ -2499,3 +2500,36 @@ tools for styling them, including a built-in real-time video preview.")
> >      (synopsis "GStreamer Transcoding API")
> >      (description "GStreamer Transcoding API")
> >      (license license:lgpl2.1)))
> > +
> > +(define-public gavl
> > +  (package
> > +    (name "gavl")
> > +    (version "1.4.0")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (string-append "mirror://sourceforge/gmerlin/"
> > +                           name "/" version "/"
> > +                           name "-" version ".tar.gz"))
> > +       (file-name (string-append name "-" version ".tar.gz"))
> > +       (sha256
> > +        (base32
> > +         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)
> > +       ("doxygen" ,doxygen)))
> > +    (home-page "http://gmerlin.sourceforge.net")
> > +    (synopsis "low level library for multimedia API building")
> > +    (description
> > +     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
> > +library, upon which multimedia APIs can be built.  Gavl handles all the
> > +details of audio and video formats like colorspaces, samplerates,
> 
> "samplerates" should be two words.
> 
> > +multichannel configurations etc.  It provides standardized definitions for
>                               ^
>                a comma after "configurations" would be nice.
> > +those formats as well as container structures for carrying audio samples or
> > +video images inside an application.
> > +
> > +In addition, it handles the sometimes ugly task to convert between all
> 
> Instead of "ugly task to convert..." perhaps we can say "ugly task of
> converting..."
> 
> > +these formats and provides some elementary operations (copying, scaling,
> > +alpha blending etc).")
> > +    (license license:gpl3)))
> 
> I suppose the changes to gavl's description could be forwarded upstream,
> seeing as this is the same description as the one
> gmerlin.sourceforge.net uses.

Maybe… Besides having the correct text it requires writing
the email etc. If I don't forget it, I'll get to it eventually
at some point… this year.

> Everything else LGTM. Thanks for working on this!
> 
Thanks for the review.

Updated patches appended.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org

[-- Attachment #1.2: 0001-gnu-Add-gst-transcoder.patch --]
[-- Type: text/plain, Size: 2560 bytes --]

From 9cebc1dff4d4bf3165de0f6d1d1c521496e032fe Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Mon, 16 Oct 2017 05:41:50 +0000
Subject: [PATCH 1/3] gnu: Add gst-transcoder.

* gnu/packages/video.scm (gst-transcoder): New variable.
---
 gnu/packages/video.scm | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index d73e21a31..3983c6053 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -11,7 +11,7 @@
 ;;; Copyright © 2016 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman@gmail.com>
 ;;; Copyright © 2016 Andy Patterson <ajpatter@uwaterloo.ca>
-;;; Copyright © 2016, 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2016, 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2017 Feng Shu <tumashu@163.com>
@@ -49,6 +49,7 @@
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
+  #:use-module (guix build-system meson)
   #:use-module (guix build-system python)
   #:use-module (guix build-system waf)
   #:use-module (gnu packages)
@@ -2472,3 +2473,29 @@ tools for styling them, including a built-in real-time video preview.")
    ; by upstream). See https://github.com/Aegisub/Aegisub/blob/master/LICENCE
    ; src/MatroskaParser.(c|h) is under bsd-3 with permission from the author
 
+(define-public gst-transcoder
+  (package
+    (name "gst-transcoder")
+    (version "1.12.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/pitivi/gst-transcoder/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0cnwmrsd321s02ff91m3j27ydj7f8wks0jvmp5admlhka6z7zxm9"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("gobject-introspection" ,gobject-introspection)
+       ("glib" ,glib)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)))
+    (native-inputs
+     `(("python" ,python)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/pitivi/gst-transcoder/")
+    (synopsis "GStreamer Transcoding API")
+    (description "GStreamer Transcoding API")
+    (license license:lgpl2.1)))
-- 
2.14.3


[-- Attachment #1.3: 0002-gnu-Add-python-pycanberra.patch --]
[-- Type: text/plain, Size: 2556 bytes --]

From a86ff27522101c6cc3dfe1f9c4b2ded1a1c95d0c Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Mon, 16 Oct 2017 15:31:04 +0000
Subject: [PATCH 2/3] gnu: Add python-pycanberra.

* gnu/packages/libcanberra.scm (python-pycanberra): New variable.
---
 gnu/packages/libcanberra.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/libcanberra.scm b/gnu/packages/libcanberra.scm
index 941d3dcc4..9af6b40ff 100644
--- a/gnu/packages/libcanberra.scm
+++ b/gnu/packages/libcanberra.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2016 Fabian Harfert <fhmgufs@web.de>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,8 +25,11 @@
   #:use-module (gnu packages)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (guix build utils)
+  #:use-module (guix utils)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
@@ -33,6 +37,7 @@
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages xiph))
 
 (define-public libcanberra
@@ -126,3 +131,26 @@ sounds for various system events.")
     (license (list cc-by-sa4.0 cc-by3.0 gpl2 gpl2+))
 
     (home-page "http://www.freedesktop.org/wiki/Specifications/sound-theme-spec/")))
+
+(define-public python-pycanberra
+  (package
+    (name "python-pycanberra")
+    (version "0.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dist.ng0.infotropique.org/releases/"
+                           "pycanberra/pycanberra-" version ".tar.xz"))
+       (sha256
+        (base32
+         "16jjf8fcgaprmz6jacsxrh17l1ad891fns38bxv49lg3s3mn1nj2"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;No tests included.
+    (propagated-inputs
+     `(("libcanberra" ,libcanberra)))
+    (synopsis "Ctypes wrapper for the libcanberra API")
+    (description
+     "Pycanberra is a basic Python wrapper for libcanberra.")
+    (home-page "https://git.ng0.infotropique.org/pycanberra/")
+    (license lgpl2.1+)))
-- 
2.14.3


[-- Attachment #1.4: 0003-gnu-Add-gavl.patch --]
[-- Type: text/plain, Size: 2391 bytes --]

From 939166948d5b278c47536276b0aa09229f6ecaa7 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Fri, 20 Oct 2017 18:32:12 +0000
Subject: [PATCH 3/3] gnu: Add gavl.

* gnu/packages/video.scm (gavl): New variable.
---
 gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 3983c6053..be22a84fe 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -69,6 +69,7 @@
   #:use-module (gnu packages databases)
   #:use-module (gnu packages dejagnu)
   #:use-module (gnu packages docbook)
+  #:use-module (gnu packages documentation)
   #:use-module (gnu packages elf)
   #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
@@ -2499,3 +2500,36 @@ tools for styling them, including a built-in real-time video preview.")
     (synopsis "GStreamer Transcoding API")
     (description "GStreamer Transcoding API")
     (license license:lgpl2.1)))
+
+(define-public gavl
+  (package
+    (name "gavl")
+    (version "1.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/gmerlin/"
+                           name "/" version "/"
+                           name "-" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("doxygen" ,doxygen)))
+    (home-page "http://gmerlin.sourceforge.net")
+    (synopsis "low level library for multimedia API building")
+    (description
+     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
+library, upon which multimedia APIs can be built.  Gavl handles all the
+details of audio and video formats like colorspaces, sample rates,
+multichannel configurations, etc.  It provides standardized definitions for
+those formats as well as container structures for carrying audio samples or
+video images inside an application.
+
+In addition, it handles the sometimes ugly task of converting between all
+these formats and provides some elementary operations (copying, scaling,
+alpha blending etc).")
+    (license license:gpl3)))
-- 
2.14.3


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies)
  2017-10-26 20:07       ` ng0
@ 2017-10-27 12:28         ` Kei Kebreau
  2017-11-28 19:04           ` bug#28917: " ng0
  0 siblings, 1 reply; 7+ messages in thread
From: Kei Kebreau @ 2017-10-27 12:28 UTC (permalink / raw)
  To: ng0; +Cc: 28917

[-- Attachment #1: Type: text/plain, Size: 4187 bytes --]

ng0 <ng0@infotropique.org> writes:

> Kei Kebreau transcribed 3.2K bytes:
>> ng0 <ng0@infotropique.org> writes:
>> 
>> > ng0 transcribed 1.4K bytes:
>> >> ng0 transcribed 10K bytes:
>> >> > This adds gst-transcoder, python-pycanberra and gavl
>> >> > required for pitivi.
>> >> 
>> >> Yarg. I've sent the wrong python-pycanberra. Correction incoming.
>> >
>> > Correction appended.
>> >
>> > -- 
>> > ng0
>> > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
>> > GnuPG: https://dist.ng0.infotropique.org/dist/keys/
>> > https://www.infotropique.org https://ng0.infotropique.org
>> >
>> >
>> >
>> > From b97a66068be69bc53d654d6204cdb1df5c889dd6 Mon Sep 17 00:00:00 2001
>> > From: ng0 <ng0@infotropique.org>
>> > Date: Fri, 20 Oct 2017 18:32:12 +0000
>> > Subject: [PATCH 3/3] gnu: Add gavl.
>> >
>> > * gnu/packages/video.scm (gavl): New variable.
>> > ---
>> >  gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
>> >  1 file changed, 34 insertions(+)
>> >
>> > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
>> > index baebe6404..7294c5bf2 100644
>> > --- a/gnu/packages/video.scm
>> > +++ b/gnu/packages/video.scm
>> > @@ -69,6 +69,7 @@
>> >    #:use-module (gnu packages databases)
>> >    #:use-module (gnu packages dejagnu)
>> >    #:use-module (gnu packages docbook)
>> > +  #:use-module (gnu packages documentation)
>> >    #:use-module (gnu packages elf)
>> >    #:use-module (gnu packages file)
>> >    #:use-module (gnu packages flex)
>> > @@ -2499,3 +2500,36 @@ tools for styling them, including a built-in real-time video preview.")
>> >      (synopsis "GStreamer Transcoding API")
>> >      (description "GStreamer Transcoding API")
>> >      (license license:lgpl2.1)))
>> > +
>> > +(define-public gavl
>> > +  (package
>> > +    (name "gavl")
>> > +    (version "1.4.0")
>> > +    (source
>> > +     (origin
>> > +       (method url-fetch)
>> > +       (uri (string-append "mirror://sourceforge/gmerlin/"
>> > +                           name "/" version "/"
>> > +                           name "-" version ".tar.gz"))
>> > +       (file-name (string-append name "-" version ".tar.gz"))
>> > +       (sha256
>> > +        (base32
>> > +         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
>> > +    (build-system gnu-build-system)
>> > +    (native-inputs
>> > +     `(("pkg-config" ,pkg-config)
>> > +       ("doxygen" ,doxygen)))
>> > +    (home-page "http://gmerlin.sourceforge.net")
>> > +    (synopsis "low level library for multimedia API building")

I also missed this the first time: the synopsis must start with an
upper-case letter or digit. I fixed it before pushing the patch.

>> > +    (description
>> > +     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
>> > +library, upon which multimedia APIs can be built.  Gavl handles all the
>> > +details of audio and video formats like colorspaces, samplerates,
>> 
>> "samplerates" should be two words.
>> 
>> > +multichannel configurations etc.  It provides standardized definitions for
>>                               ^
>>                a comma after "configurations" would be nice.
>> > +those formats as well as container structures for carrying audio samples or
>> > +video images inside an application.
>> > +
>> > +In addition, it handles the sometimes ugly task to convert between all
>> 
>> Instead of "ugly task to convert..." perhaps we can say "ugly task of
>> converting..."
>> 
>> > +these formats and provides some elementary operations (copying, scaling,
>> > +alpha blending etc).")
>> > +    (license license:gpl3)))
>> 
>> I suppose the changes to gavl's description could be forwarded upstream,
>> seeing as this is the same description as the one
>> gmerlin.sourceforge.net uses.
>
> Maybe… Besides having the correct text it requires writing
> the email etc. If I don't forget it, I'll get to it eventually
> at some point… this year.
>
>> Everything else LGTM. Thanks for working on this!
>> 
> Thanks for the review.
>
> Updated patches appended.

Excellent, and thank you. These have been pushed to master.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#28917: gst-transcoder + python-pycanberra + gavl (pitivi dependencies)
  2017-10-27 12:28         ` Kei Kebreau
@ 2017-11-28 19:04           ` ng0
  0 siblings, 0 replies; 7+ messages in thread
From: ng0 @ 2017-11-28 19:04 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 28917-done

[-- Attachment #1: Type: text/plain, Size: 4603 bytes --]

Kei Kebreau transcribed 5.0K bytes:
> ng0 <ng0@infotropique.org> writes:
> 
> > Kei Kebreau transcribed 3.2K bytes:
> >> ng0 <ng0@infotropique.org> writes:
> >> 
> >> > ng0 transcribed 1.4K bytes:
> >> >> ng0 transcribed 10K bytes:
> >> >> > This adds gst-transcoder, python-pycanberra and gavl
> >> >> > required for pitivi.
> >> >> 
> >> >> Yarg. I've sent the wrong python-pycanberra. Correction incoming.
> >> >
> >> > Correction appended.
> >> >
> >> > -- 
> >> > ng0
> >> > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> >> > GnuPG: https://dist.ng0.infotropique.org/dist/keys/
> >> > https://www.infotropique.org https://ng0.infotropique.org
> >> >
> >> >
> >> >
> >> > From b97a66068be69bc53d654d6204cdb1df5c889dd6 Mon Sep 17 00:00:00 2001
> >> > From: ng0 <ng0@infotropique.org>
> >> > Date: Fri, 20 Oct 2017 18:32:12 +0000
> >> > Subject: [PATCH 3/3] gnu: Add gavl.
> >> >
> >> > * gnu/packages/video.scm (gavl): New variable.
> >> > ---
> >> >  gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
> >> >  1 file changed, 34 insertions(+)
> >> >
> >> > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> >> > index baebe6404..7294c5bf2 100644
> >> > --- a/gnu/packages/video.scm
> >> > +++ b/gnu/packages/video.scm
> >> > @@ -69,6 +69,7 @@
> >> >    #:use-module (gnu packages databases)
> >> >    #:use-module (gnu packages dejagnu)
> >> >    #:use-module (gnu packages docbook)
> >> > +  #:use-module (gnu packages documentation)
> >> >    #:use-module (gnu packages elf)
> >> >    #:use-module (gnu packages file)
> >> >    #:use-module (gnu packages flex)
> >> > @@ -2499,3 +2500,36 @@ tools for styling them, including a built-in real-time video preview.")
> >> >      (synopsis "GStreamer Transcoding API")
> >> >      (description "GStreamer Transcoding API")
> >> >      (license license:lgpl2.1)))
> >> > +
> >> > +(define-public gavl
> >> > +  (package
> >> > +    (name "gavl")
> >> > +    (version "1.4.0")
> >> > +    (source
> >> > +     (origin
> >> > +       (method url-fetch)
> >> > +       (uri (string-append "mirror://sourceforge/gmerlin/"
> >> > +                           name "/" version "/"
> >> > +                           name "-" version ".tar.gz"))
> >> > +       (file-name (string-append name "-" version ".tar.gz"))
> >> > +       (sha256
> >> > +        (base32
> >> > +         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
> >> > +    (build-system gnu-build-system)
> >> > +    (native-inputs
> >> > +     `(("pkg-config" ,pkg-config)
> >> > +       ("doxygen" ,doxygen)))
> >> > +    (home-page "http://gmerlin.sourceforge.net")
> >> > +    (synopsis "low level library for multimedia API building")
> 
> I also missed this the first time: the synopsis must start with an
> upper-case letter or digit. I fixed it before pushing the patch.
> 
> >> > +    (description
> >> > +     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
> >> > +library, upon which multimedia APIs can be built.  Gavl handles all the
> >> > +details of audio and video formats like colorspaces, samplerates,
> >> 
> >> "samplerates" should be two words.
> >> 
> >> > +multichannel configurations etc.  It provides standardized definitions for
> >>                               ^
> >>                a comma after "configurations" would be nice.
> >> > +those formats as well as container structures for carrying audio samples or
> >> > +video images inside an application.
> >> > +
> >> > +In addition, it handles the sometimes ugly task to convert between all
> >> 
> >> Instead of "ugly task to convert..." perhaps we can say "ugly task of
> >> converting..."
> >> 
> >> > +these formats and provides some elementary operations (copying, scaling,
> >> > +alpha blending etc).")
> >> > +    (license license:gpl3)))
> >> 
> >> I suppose the changes to gavl's description could be forwarded upstream,
> >> seeing as this is the same description as the one
> >> gmerlin.sourceforge.net uses.
> >
> > Maybe… Besides having the correct text it requires writing
> > the email etc. If I don't forget it, I'll get to it eventually
> > at some point… this year.
> >
> >> Everything else LGTM. Thanks for working on this!
> >> 
> > Thanks for the review.
> >
> > Updated patches appended.
> 
> Excellent, and thank you. These have been pushed to master.

Thanks!

Closing the bug.

N.
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-11-28 19:06 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20 19:35 [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies) ng0
2017-10-21 21:29 ` ng0
2017-10-21 21:32   ` ng0
2017-10-25 14:24     ` Kei Kebreau
2017-10-26 20:07       ` ng0
2017-10-27 12:28         ` Kei Kebreau
2017-11-28 19:04           ` bug#28917: " ng0

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).