From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2Kjm-0007KH-Cr for guix-patches@gnu.org; Wed, 11 Oct 2017 13:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2Kji-0003mU-9A for guix-patches@gnu.org; Wed, 11 Oct 2017 13:24:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53993) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2Kji-0003mP-5d for guix-patches@gnu.org; Wed, 11 Oct 2017 13:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e2Kjh-0000Vf-Tz for guix-patches@gnu.org; Wed, 11 Oct 2017 13:24:01 -0400 Subject: [bug#27475] Add kashmir, crypto++, opendht-with-msgpack-c++-11, and some updates. Resent-Message-ID: Date: Wed, 11 Oct 2017 18:22:54 +0100 From: Christopher Baines Message-ID: <20171011182254.101c14ce@cbaines.net> In-Reply-To: <8737apqrlj.fsf@openmailbox.org> References: <8737apqrlj.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/L9proWUIEjIxDDKrLilzSt7"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Adonay Felipe Nogueira Cc: 27475@debbugs.gnu.org --Sig_/L9proWUIEjIxDDKrLilzSt7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 24 Jun 2017 13:26:48 -0300 Adonay Felipe Nogueira wrote: > Here follows a series of patches, it's part of the attempt to package > GNU Ring. However, these contributions don't need custom patches from > Savir Faire Linux. The only doubt is in regards to the need to have a > variant of msgpack that uses C++ 11 instead, and have a variant of > opendht that makes use of such msgpack variant instead. I've just noticed that no one has taken a look at this yet! Not quite sure how that has happened. Here are my comments. The first general comment is that these patches don't quite apply now, so it would be useful to send another set which do apply cleanly. Starting with the kashmir package. > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/Corvusoft/" > name > + "-dependency/archive/" commit > ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "11hbh3d7w74gng9qgz3hdrzvxjgil1pymk2bzxv1ajh9vp60xxs9")))) Looks like this patch may have got caught up in the recent hash changes from GitHub. I had to change the sha256 before this would build. The directory structure in this package looks a little odd. The Debian package has kashmir-dependency/kashmir as include/kashmir, which might be a little more usual. guix lint also reports some issues: /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f39= 13f: tabulation on line 39, column 0 + more tab issues /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f39= 13f: tabulation on line 71, column 0 /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f39= 13f: line 72 is way too long (98 characters) /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f39= 13f: line 73 is way too long (176 characters) As for the crypto++ package. guix lint reports lots of tabs. > + (add-after 'build 'build-shared > + (lambda _ > + ;; By default, only the static > + ;; library is built. > + (zero? > + (system* "make" "shared")))) I think you could get rid of this phase by adding "shared" to the #:make-flags. I'm not sure why the binary is has .exe in the name? Even the inbuilt help calls it cryptest: Unrecognized command. Run "cryptest h" to obtain usage information. I have no idea what this does, but running it in a container fails, as it seems to be looking for data in the doc output: =E2=86=92 guix environment --container --ad-hoc crypto++:bin -- cryptest.= exe CryptoPP::Exception caught: FileStore: error opening file for reading: TestData/usage.dat On to the opendht update. > + (let ((release "1.3.3") > + (revision 5)) I'm not why this revision is being used? Also, with the msgpack-c++-11 package, I built both msgpack and msgpack-c++-11 and diffed the contents with diffoscope, and they are practically identical as far as I can see. I'm guessing there was supposed to be a difference? Last but not least, for the argon2 package, for which I don't have any questions or suggestions. Ignoring the tabs, I think it looks fine. I hope this helps Adonay :) --Sig_/L9proWUIEjIxDDKrLilzSt7 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlneU25fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfesRAAqvy1n6AW3isidhUG6c0pY1l1fTYq54+er3l4USujQDwskO60ifXhJVjV Za5Yroy0t+jWL2WpCdl77tCNuYilT00sbi/+a/d5/RCLNRR4Sp0+DWQIKW1ZT+87 o24ArNg1+LhaQLgmSL3eezgNuuhO4qL7xWZT6uZ5CjycCkIVXjTyobRbTbyYoFO9 cqvBdOTCKyJG7g3bLaBOJs/1WR3mRwp3oOKlbY1SQ9GT/7ug43pNh3FPisVudLRS GJkTEe8LskybO9CgOU3gPHaEWMJ7MnVJmXQghJQAScu2KSS8n0bMN9r/KdlJ/H7D XVBQmKMzy+8gNEyb46L3nbW5ewU+KIlldGNRPR1Av/XSE4hGYtKMIj5CaTPverph zFI5Gr6ADsc4Uq3mjD3SndRICMQJAqVnG/gqukZvCqXvdao+w30B0zTsWibdS2C0 qtv25wZob9sSTk/uctZbTTxB3V/pF4AVvGMy8Sq/bYY2lMtyqAb4V5cqk56pA34J ZHFlBre6fvIke9SYmDD9Aq2u0nNb2Yn4FQ0nj3mgELF3e/ricdTHsHzlJlTNDfSw N2NytqlOIRB1vY5V5iTKJCj6mg8TINjOyy0V+O640bKJ/jBZde9XaXTLgRE16aVy UxIAgxFiqoTfLE7wrn6GI7Seu2dd5Q7LGBh/8Am2DcUu4j7KWXM= =i3gW -----END PGP SIGNATURE----- --Sig_/L9proWUIEjIxDDKrLilzSt7--