Patch pushed

On Tue, Aug 01, 2017 at 11:19:09PM +0200, Marius Bakke wrote:
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > This has qtnetworkauth, qtremoteobjects, qtspeech.
> >
> > After this we have qt3d, qtvirtualkeyboard, qtwebengine and qtwebview.
> 
> Great, thanks for keeping up with Qt!
> 
> [...]
>   
> > +(define-public qtspeech
> > +  (package (inherit qtsvg)
> > +    (name "qtspeech")
> > +    (version "5.9.1")
> > +    (source (origin
> > +             (method url-fetch)
> > +             (uri (string-append "https://download.qt.io/official_releases/qt/"
> > +                                 (version-major+minor version) "/" version
> > +                                 "/submodules/" name "-opensource-src-"
> > +                                 version ".tar.xz"))
> > +             (sha256
> > +              (base32
> > +               "00daxkf8iwf6n9rhkkv3isv5qa8wijwzb0zy1f6zlm3vcc8fz75c"))))
> > +    (inputs
> > +     `(("qtbase" ,qtbase)))
> > +    (native-inputs
> > +     `(("perl" ,perl)
> > +       ("qtdeclarative" ,qtdeclarative)
> > +       ("qtmultimedia" ,qtmultimedia)
> > +       ("qtxmlpatterns" ,qtxmlpatterns)))))
> 
> Does this package not keep references to these inputs? Can you add a
> comment about why they are only needed at build-time? I'd guess tests,
> but it's not obvious.
> 
> These packages also need separate synopses and descriptions from
> 'qtsvg', but other than that looks good to me.



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted