From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1oLk-00016p-Bs
	for guix-patches@gnu.org; Tue, 10 Oct 2017 02:49:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1oLe-0005nH-V7
	for guix-patches@gnu.org; Tue, 10 Oct 2017 02:49:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50330)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e1oLe-0005nB-RZ
	for guix-patches@gnu.org; Tue, 10 Oct 2017 02:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1oLe-0004Ti-Kd
	for guix-patches@gnu.org; Tue, 10 Oct 2017 02:49:02 -0400
Subject: [bug#28723] [PATCH 2/2] gnu: Add hdf-java.
Resent-Message-ID: <handler.28723.B28723.150761813517200@debbugs.gnu.org>
Date: Tue, 10 Oct 2017 08:48:42 +0200 (CEST)
Message-Id: <20171010.084842.1384895904458327220.post@thomasdanckaert.be>
From: Thomas Danckaert <post@thomasdanckaert.be>
In-Reply-To: <20171009192702.GB21287@jasmine.lan>
References: <20171006.180153.688490172361889589.post@thomasdanckaert.be>
	<20171006.182042.2104233175241159680.post@thomasdanckaert.be>
	<20171009192702.GB21287@jasmine.lan>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: leo@famulari.name
Cc: 28723@debbugs.gnu.org

From: Leo Famulari <leo@famulari.name>
Subject: Re: [bug#28723] [PATCH 2/2] gnu: Add hdf-java.
Date: Mon, 9 Oct 2017 15:27:02 -0400

>> +        (add-before 'check 'build-examples
>> +          (lambda _
>> +            (apply system* `("javac"
>> +                             ,@(find-files "examples" ".*\\.java")))
>> +            #t)))
> 
> Do we have to explicity return #t here? Does the javac call not return
> a value that we can pass to (zero? ...)?

Yes, I'm pretty sure this can be improved.  Good catch!

Thanks for taking a look.

Thomas