From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1drN-0000iE-Kz for guix-patches@gnu.org; Mon, 09 Oct 2017 15:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1drL-0007Um-Eb for guix-patches@gnu.org; Mon, 09 Oct 2017 15:37:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1drL-0007Uc-AG for guix-patches@gnu.org; Mon, 09 Oct 2017 15:37:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e1drL-00060y-3E for guix-patches@gnu.org; Mon, 09 Oct 2017 15:37:03 -0400 Subject: [bug#28723] [PATCH 2/2] gnu: Add hdf-java. Resent-Message-ID: Date: Mon, 9 Oct 2017 15:27:02 -0400 From: Leo Famulari Message-ID: <20171009192702.GB21287@jasmine.lan> References: <20171006.180153.688490172361889589.post@thomasdanckaert.be> <20171006.182042.2104233175241159680.post@thomasdanckaert.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QTprm0S8XgL7H0Dt" Content-Disposition: inline In-Reply-To: <20171006.182042.2104233175241159680.post@thomasdanckaert.be> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Thomas Danckaert Cc: 28723@debbugs.gnu.org --QTprm0S8XgL7H0Dt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 06, 2017 at 06:20:42PM +0200, Thomas Danckaert wrote: > Hi Guix, >=20 > this patch adds hdf-java. >=20 > It's quite ugly, but it seems the autotools build for this package is bar= ely > working and really needs a lot of patching... (Actually, using CMake is > recommended, but then we would have to build the HDF4 and HDF5 packages w= ith > CMake as well). >=20 > cheers, >=20 > Thomas > From 619b38cc889bc41e0128f038aa78e54f71fb7dab Mon Sep 17 00:00:00 2001 > From: Thomas Danckaert > Date: Wed, 4 Oct 2017 17:17:03 +0200 > Subject: [PATCH 2/2] gnu: Add hdf-java. >=20 > * gnu/packages/maths.scm (hdf-java): New variable. Overall, LGTM... > + (add-before 'check 'build-examples > + (lambda _ > + (apply system* `("javac" > + ,@(find-files "examples" ".*\\.java"))) > + #t))) Do we have to explicity return #t here? Does the javac call not return a value that we can pass to (zero? ...)? --QTprm0S8XgL7H0Dt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlnbzYYACgkQJkb6MLrK fwh3thAAywK6r44OlbnHFldsMg+HrHPH/dkB0yUBLu1N6gIDX+0Pd11GxnZxnbTq Pfp5Nc2E2hBlPpZ3vv2IaobaxL3Zowp3S4/T4os9doNAyMqlc2PsHGJmELTULkRx J7Qm5LS+Zo+8fhJn22SZqPQmAyGpSz0a3QauK/1qfRX8AEVV159iTePLahQRD1Xp 4jn3T2fH8XG/FPMnDgnUU1uaEUh4vbkrNXW+nd6BSTwJoNToLu44lOGSNIUnJcd9 gUFTYWz/XZcbCSR/Lq2rV6OsmvaOdF0hgtBtTLCso2bDX+kJjOVKZDVe+TbTAEqo M6Ry6KI4DhaLc3a2jLH7vyK/8X9wywQjFk/gihkQyNVLH/t0GBtSmzIJVPrBbBjh sSh+9wumOcysMMeb+FIyNsUck/mdH43jS+tfzCHe4UNza8xtKKSwNG0fIr/00q6r FNFitgw67pGz7SyHBFKStZbMofPsye681U9UO6FEOhqsYzVsd2T9GuHDMEXBinG/ Anz/BdAG1SEGWuXQtFukV0o17XzcFyqQQNba8CsMQnd4UWlsvkx/1YMeTtJfEvhv khe4azn4HyjoWNJA4eSjfYHiCeHLGYwLdMFo78puqM9CndxFOAXeLKSFhPSR6JPI yYobaKxhHW3Kc5uuUz2SRidm0WiWJqXC4vg76P5ry5C6nLSEcAg= =d6r8 -----END PGP SIGNATURE----- --QTprm0S8XgL7H0Dt--