From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0ZGz-00069C-Pk for guix-patches@gnu.org; Fri, 06 Oct 2017 16:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0ZGw-0001tA-LO for guix-patches@gnu.org; Fri, 06 Oct 2017 16:31:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0ZGw-0001st-IB for guix-patches@gnu.org; Fri, 06 Oct 2017 16:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0ZGw-0005WH-CP for guix-patches@gnu.org; Fri, 06 Oct 2017 16:31:02 -0400 Subject: bug#28198: [PATCH 3/3] services: Add MongoDB. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Fri, 6 Oct 2017 21:29:52 +0100 From: Christopher Baines Message-ID: <20171006212952.20336912@cbaines.net> In-Reply-To: <87efqj6khm.fsf@gnu.org> References: <20170930075942.31332-1-mail@cbaines.net> <20170930075942.31332-3-mail@cbaines.net> <87efqj6khm.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/N=Vih7B/5KwLNFVtqF1XUWH"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28198-done@debbugs.gnu.org --Sig_/N=Vih7B/5KwLNFVtqF1XUWH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 04 Oct 2017 16:44:21 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > * gnu/services/databases.scm (%default-mongodb-configuration-file, > > %mongodb-accounts, mongodb-service-type): New variables. > > (): New record type. > > (mongodb-activation, mongodb-shepherd-service): New procedures. > > * gnu/tests/databases.scm (%test-mongodb): New variable. > > * doc/guix.text (Database Services): Add MongoDB documentation. =20 > ^ >=20 > texi :-) >=20 > [...] >=20 > > +(define mongodb-service-type > > + (service-type > > + (name 'mongodb) > > + (extensions > > + (list (service-extension shepherd-root-service-type > > + (compose list > > + mongodb-shepherd-service)) > > + (service-extension activation-service-type > > + mongodb-activation) > > + (service-extension account-service-type > > + (const %mongodb-accounts)))) > > + (default-value > > + (mongodb-configuration)))) =20 >=20 > Could you add a =E2=80=98description=E2=80=99 field? :-) >=20 > Like =E2=80=9CRun the MongoDB document database server.=E2=80=9D >=20 > Apart from that it looks great. I've added the explicit #t values to the two phases, fixed the texi typo, and added the description, and now pushed. Thanks again for reviewing Ludo :) --Sig_/N=Vih7B/5KwLNFVtqF1XUWH Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnX58BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XegOg/9FzC9dvIjr+odFzanCIDgwdZydzWYeUvBMBF+1uEb1/4j7MZoQnSadSSG Ott/njYHBFJLLgUNZc4a7khG7zPN5FT3UfEcv/o92P4foUJe5kN3LdtCtaZa0KJd 6+WkEUPUy+ORn1WOj4w2QFlgd8gEkyZu1kuX1uLYXcfn99bmDGrkUXQTcRWDa599 W/G+NmRxpq4tqY7pTznit78INB6zdlueMKaTZopadWsJcQfEU4wS0EdD0pBRQ+Xn 1t9xkvWVkCXoExleCZQ4hHb9/tUDYcCYjL1x5efOXuOW6H+UCSV5QKPVuR/xDO2w hspFEWQ1+nbeWeUtGFhXsuwP1sTHuOI8MepcBJ1Bqt2zE7y/rdqFKkbf879gQc1c xXHK7LYs5UIe07/EdAAJWIeorPpi4hV0zdDC915qvWINwPRBKJwxKcSNLw32N09N Syy0BsNkOI0XlIdlRI1gRc+XrZn4oZ7ucEnD6NAOjQMKtdS+OS2AD3lyclcSgqBR 9MHkSwX53DyhZSFE+1s36T2EhIjg1mEloiGhmOea5F9X3HXzefEjfXjWzosxm5jn IljYimLMLHtjhYtp5buYQh0SZqHO7qhPsb0rsqT7EU74OFm0OpHYTBWAj9XrHJFf NnEVuOAHTWvglrus9Vgt6SVZsT297zl9fsG7HtJoRYMkB6osaYs= =AYvC -----END PGP SIGNATURE----- --Sig_/N=Vih7B/5KwLNFVtqF1XUWH--