unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28127@debbugs.gnu.org
Subject: [bug#28127] [PATCH 2/2] web: Add NGinx documentation.
Date: Thu, 5 Oct 2017 21:43:09 +0100	[thread overview]
Message-ID: <20171005214309.5c7e8f49@cbaines.net> (raw)
In-Reply-To: <8760bv6kb6.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

On Wed, 04 Oct 2017 16:48:13 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail@cbaines.net> skribis:
> 
> > * gnu/packages/web.scm (nginx): Add comment about deleting the
> > documentation. (nginx-xslscript): New variable.
> >   (nginx-docs): New variable.  
> 
> That’s a good idea!
> 
> > +(define-public nginx-docs
> > +  ;; This documentation should be relevant for nginx-1.12.0
> > +  (let ((revision 1961)
> > +        (changeset "dd4b6c564e10"))
> > +    (package
> > +      (name "nginx-docs")  
> 
> Maybe “nginx-doc” (singular)?

I wasn't sure about nginx-doc, so I have sent an updated patch using
nginx-documentation. 

> > +      (home-page "https://nginx.org")
> > +      (synopsis "Documentation for NGinx")
> > +      (description
> > +       "The documentation for the NGinx web server.")  
> 
> “This package provides HTML documentation for the NGINX web
> server.” (?)
> 
> Also, s/NGinx/NGINX/ if I’m not mistaken.

I haven't seen any guidance on this, but the documentation itself uses
nginx (all lower case) as far as I can see, so I've switched to using
that.

I've sent an updated patch, thanks for your review :)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

  reply	other threads:[~2017-10-05 20:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 18:42 [bug#28127] [PATCH] Add documentation for NGinx Christopher Baines
2017-08-17 18:44 ` [bug#28127] [PATCH 1/2] perl: Add perl-parse-recdescent Christopher Baines
2017-08-17 18:44   ` [bug#28127] [PATCH 2/2] web: Add NGinx documentation Christopher Baines
2017-10-04 14:48     ` Ludovic Courtès
2017-10-05 20:43       ` Christopher Baines [this message]
2017-10-04 14:45   ` [bug#28127] [PATCH 1/2] perl: Add perl-parse-recdescent Ludovic Courtès
2017-10-05 20:40     ` Christopher Baines
2017-10-05 20:40 ` Christopher Baines
2017-10-05 20:40   ` [bug#28127] [PATCH 2/2] web: Add nginx-documentation Christopher Baines
2017-10-07 20:31     ` Ludovic Courtès
2017-10-08 13:38       ` bug#28127: " Christopher Baines
2017-10-07 20:30   ` [bug#28127] [PATCH 1/2] perl: Add perl-parse-recdescent Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005214309.5c7e8f49@cbaines.net \
    --to=mail@cbaines.net \
    --cc=28127@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).