From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28635-done@debbugs.gnu.org
Subject: bug#28635: [PATCH 2/2] vm: Add disk-image-size to <virtual-machine>.
Date: Wed, 4 Oct 2017 07:25:36 +0100 [thread overview]
Message-ID: <20171004072536.0d736c3a@cbaines.net> (raw)
In-Reply-To: <87zi9874uz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Tue, 03 Oct 2017 15:12:04 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
> > * gnu/system/vm.scm (<virtual-machine>): Add disk-image-size.
> > (port-forwardings->qemu-options): Use disk-image-size from
> > <virtual-machine>.
>
> As long as “make check-system TESTS=basic” passes, fine with me!
It failed at first, as I had a the memory-size and disk-image-size
fields the wrong way around in a match statement, but after I fixed
that it worked fine.
I've now pushed these changes, thanks for your review :)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-10-04 6:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 19:54 [bug#28635] [PATCH] Allow configuring the disk image size of a virtual machine Christopher Baines
2017-09-28 19:57 ` [bug#28635] [PATCH 1/2] vm: Add a minimum root size Christopher Baines
2017-09-28 19:57 ` [bug#28635] [PATCH 2/2] vm: Add disk-image-size to <virtual-machine> Christopher Baines
2017-10-03 13:12 ` Ludovic Courtès
2017-10-04 6:25 ` Christopher Baines [this message]
2017-10-03 13:11 ` [bug#28635] [PATCH 1/2] vm: Add a minimum root size Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004072536.0d736c3a@cbaines.net \
--to=mail@cbaines.net \
--cc=28635-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).