From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dzTBi-0005m4-Di
	for guix-patches@gnu.org; Tue, 03 Oct 2017 15:49:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dzTBe-0003BS-Hs
	for guix-patches@gnu.org; Tue, 03 Oct 2017 15:49:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:38140)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dzTBe-0003BB-Dj
	for guix-patches@gnu.org; Tue, 03 Oct 2017 15:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dzTBe-00074T-79
	for guix-patches@gnu.org; Tue, 03 Oct 2017 15:49:02 -0400
Subject: bug#28378: [PATCH] gnu: Add heimdall.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.28378.D28378.150706008227074.done@debbugs.gnu.org>
Date: Tue, 3 Oct 2017 21:46:27 +0200
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20171003214627.74bd788a@lepiller.eu>
In-Reply-To: <8760cdrtww.fsf@gnu.org>
References: <20170906223653.15420-1-dannym@scratchpost.org>
	<87shfzylum.fsf@gnu.org> <20170920220902.21333ec3@lepiller.eu>
	<8760cdrtww.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 28378-done@debbugs.gnu.org

Le Wed, 20 Sep 2017 22:34:23 +0200,
ludo@gnu.org (Ludovic Court=C3=A8s) a =C3=A9crit :

> Hi Julien,
>=20
> Julien Lepiller <julien@lepiller.eu> skribis:
>=20
> > From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien@lepiller.eu>
> > Date: Tue, 29 Aug 2017 23:54:16 +0200
> > Subject: [PATCH] gnu: Add heimdall.
> >
> > * gnu/packages/flashing-tools.scm (heimdall): New variable.
> >
> > Co-Authored-By: Danny Milosavljevic <dannym@scratchpost.org> =20
>=20
> It LGTM.  I don=E2=80=99t see why libpit.a is needed, but I=E2=80=99ll le=
t you
> decide.  :-)
>=20
> > +    (build-system cmake-build-system)
> > +    (arguments
> > +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease") =20
>=20
> Why not keep the default =E2=80=9CRelWithDebInfo=E2=80=9D?
That's what was documented in this package.

Pushed as f282aa530b91c8fecb910bc0a3323fcbd4d39ffb.

>=20
> Thanks!
>=20
> Ludo=E2=80=99.