From: Julien Lepiller <julien@lepiller.eu>
To: 28378-done@debbugs.gnu.org
Subject: bug#28378: [PATCH] gnu: Add heimdall.
Date: Tue, 3 Oct 2017 21:46:27 +0200 [thread overview]
Message-ID: <20171003214627.74bd788a@lepiller.eu> (raw)
In-Reply-To: <8760cdrtww.fsf@gnu.org>
Le Wed, 20 Sep 2017 22:34:23 +0200,
ludo@gnu.org (Ludovic Courtès) a écrit :
> Hi Julien,
>
> Julien Lepiller <julien@lepiller.eu> skribis:
>
> > From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien@lepiller.eu>
> > Date: Tue, 29 Aug 2017 23:54:16 +0200
> > Subject: [PATCH] gnu: Add heimdall.
> >
> > * gnu/packages/flashing-tools.scm (heimdall): New variable.
> >
> > Co-Authored-By: Danny Milosavljevic <dannym@scratchpost.org>
>
> It LGTM. I don’t see why libpit.a is needed, but I’ll let you
> decide. :-)
>
> > + (build-system cmake-build-system)
> > + (arguments
> > + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")
>
> Why not keep the default “RelWithDebInfo”?
That's what was documented in this package.
Pushed as f282aa530b91c8fecb910bc0a3323fcbd4d39ffb.
>
> Thanks!
>
> Ludo’.
next prev parent reply other threads:[~2017-10-03 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 22:36 [bug#28378] [PATCH] gnu: Add heimdall Danny Milosavljevic
2017-09-07 8:05 ` Ludovic Courtès
2017-09-20 20:09 ` Julien Lepiller
2017-09-20 20:34 ` Ludovic Courtès
2017-10-03 19:46 ` Julien Lepiller [this message]
2017-10-04 21:27 ` Mekeor Melire
2017-10-04 21:31 ` Mekeor Melire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003214627.74bd788a@lepiller.eu \
--to=julien@lepiller.eu \
--cc=28378-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).