From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyKHG-0008Ko-MV for guix-patches@gnu.org; Sat, 30 Sep 2017 12:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyKHC-0004HT-Lm for guix-patches@gnu.org; Sat, 30 Sep 2017 12:06:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyKHC-0004HO-HJ for guix-patches@gnu.org; Sat, 30 Sep 2017 12:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyKHC-0007UO-Aw for guix-patches@gnu.org; Sat, 30 Sep 2017 12:06:02 -0400 Subject: [bug#28170] Add gnutls/dane + use it where its needed (gnurl, libmicrohttpd, gnunet) Resent-Message-ID: Date: Sat, 30 Sep 2017 17:05:04 +0100 From: Christopher Baines Message-ID: <20170930170504.1c476ed8@cbaines.net> In-Reply-To: <20170930150152.oqwfd7ff5xshkt4s@abyayala> References: <20170821095726.qtf2ko526nup4yba@abyayala> <20170930122616.17079913@cbaines.net> <20170930122309.akl2dxa46eru36pb@abyayala> <20170930134346.54a4c54a@cbaines.net> <20170930140144.yenmf7pr2ffecmll@abyayala> <20170930141255.yrnasw4aenfl77n4@abyayala> <20170930153444.3e49436f@cbaines.net> <20170930145636.dpri5bh7ipy22mib@abyayala> <20170930150152.oqwfd7ff5xshkt4s@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/.qQW6zF5Bb_e1lqeQZkWO6_"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28170@debbugs.gnu.org --Sig_/.qQW6zF5Bb_e1lqeQZkWO6_ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 30 Sep 2017 15:01:52 +0000 ng0 wrote: > ng0 transcribed 2.1K bytes: > > Christopher Baines transcribed 1.7K bytes: =20 > > > On Sat, 30 Sep 2017 14:12:55 +0000 > > > ng0 wrote: > > > =20 > > > > The fix in this version is to only add the necessary input > > > > to the inherited gnutls. =20 > > >=20 > > > Ok. One hopefully final thing. From the commit message [1], it's > > > not clear to me if this is fixing an issue with the GNUnet > > > package, by providing it with the right dependencies, or, adding > > > additional functionality to the GNUnet package, by providing a > > > more capable GnuTLS? > > >=20 > > > 1: "GNUnet and its dependency chain needs GnuTLS with DANE > > > support."=20 > > It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL. > > Certain features of these applications will not work without it. > > GnuTLS without Dane is not fatal error for these packages, but > > Dane is recommended. > > I have no idea how I should put this into the very strict dictionary > > we have in commit messages=E2=80=A6 In more free-form it would be no pr= oblem > > for me. > > --=20 > > ng0 > > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 > > GnuPG: https://krosos.org/dist/keys/ > > https://www.infotropique.org https://krosos.org =20 >=20 > Okay, I now see what you mean. >=20 > To make it short: the correct dependency is provided in place > of the current working-but-not-correct GnuTLS. >=20 > Is that more clear? I think you've made it clear to me now. =46rom what you're saying, I think its the 2nd thing I said. Making this change will enable some functionality in the GNUnet package (and possibly some of the other packages changed). I'm not sure using the word "correct" helps, unless you say what the dependencies are correct/incorrect with respect to, for example, if the GNUnet documentation says that it should be built with GnuTLS with Dane support, then that would be a reason to talk about correctness. As for the commit format. As I understand the conventions, you can put anything in between the first line, and the changelog at the bottom. For example, one case where I ended up writing quite a bit is here [1]. It doesn't have to be very specific, but something about the intent or intended effect of the change in each commit would be very useful. 1: http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D6230e155afd8c43c12ee= 3f03032aac34433db11a --Sig_/.qQW6zF5Bb_e1lqeQZkWO6_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPwLBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfmSQ/+P42GijDgeg0YVVwAoEr+bTxG7YVygyNnBqSnSb08gvOt4DeaWv4ZHzCL 0MpKdXdOx9wXM+WYGgOIZOavE6f9d3RhWaCK54p4tVqbwyfnHzpGu9lpty94RS2E H+uQIq5qoIhoKzPOP4cpcZUJWoscHtRBFCBcvoayO/Cgn00GvjuNuKy1Sv5WQQ0c YceUg+vwEkGxNZ7v7wRNbHqFETMJ4JAiaqb4PDEJBzHKZXGik18ld8WxdCM1YcdU EzRd7Sqr/D/YIlS5/saVhEOIlUoeSx3y7sWS/ziVMmTSTUSyW2NelewLFl8PpHUw Vs87SS5shm39td6RdJEd6vGDxKjEOsdm0L17fAe89ccXfwWFLH5rrKA1hN5Kw4nw tFL2KTsNHqK4Cv/dEzhkEGB8oIfPGNNUAyskzMge7flpj9/HpY2viiB+pXXpz5F6 BsIne7lBOMXN5gsDApH+U2YfQU9DWQtiwKz/JI6A3Xs2ZQP03/5kI5nk9sl/rhWC PKJW8cOEpOc+pdSAgwlaJGCgTSA0upYddbtaWXbm1OG0wsAdMtd10aWec6srfq4d lBSg+qWDf3syw9/meFFqEbY2+W0u+o4k0iAs5mtBSIziIO59oe/l9fDFNEd3KUCc IKIRU4zEjppzv9MOycnYxsNcMiHaSMc1hJ1XFEj6bTaXe0hokBU= =BAeQ -----END PGP SIGNATURE----- --Sig_/.qQW6zF5Bb_e1lqeQZkWO6_--