From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28198@debbugs.gnu.org
Subject: [bug#28198] [PATCH 2/4] gnu: Add mongodb.
Date: Sat, 30 Sep 2017 09:04:20 +0100 [thread overview]
Message-ID: <20170930090420.7a29807b@cbaines.net> (raw)
In-Reply-To: <87shg7udc5.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]
On Thu, 31 Aug 2017 14:32:58 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
> > * gnu/packages/databases.scm (mongodb): New variable.
>
> [...]
>
> > + (build-system gnu-build-system)
> > + (native-inputs
> > + `(("scons" ,scons)
> > + ("python" ,python-2)
> > + ("openssl" ,openssl)
> > + ("boost" ,boost)
> > + ("snappy" ,snappy)
> > + ("zlib" ,zlib)
> > + ("pcre" ,pcre)
> > + ("valgrind" ,valgrind)
> > + ("yaml-cpp" ,yaml-cpp)
> > + ("perl" ,perl)))
>
> Seems like some of these should rather go to ‘inputs’, no?
Indeed. I've now sent an updated set of patches, and I've moved some of
these to inputs.
> > + (arguments
> > + `(#:tests? #f ;; TODO: Check phase currently fails
>
> Maybe leave a few details on why this is failing.
I tried to check, and the tests passed, which seems good :)
> > + (replace 'install
> > + (lambda _
> > + (let ((bin (string-append (assoc-ref %outputs
> > "out") "/bin")))
> > + (install-file "mongod" bin)
> > + (install-file "mongos" bin)
> > + (install-file "mongo" bin))))))))
>
> Return #t.
Good spot, this should be fixed in the latest patch.
> > + (home-page "https://www.mongodb.org/")
> > + (synopsis "High performance and high availability document
> > database")
> > + (description
> > + "Mongo is a high-performance, high availability, schema-free
> > +document-oriented database. A key goal of MongoDB is to bridge
> > the gap +between key/value stores (which are fast and highly
> > scalable) and traditional +RDBMS systems (which are deep in
> > functionality).")
> > + (license (list license:agpl3 license:asl2.0))))
>
> AGPL version 3 only? Also please add a comment stating whether it’s
> dual-licensed or something else.
I've added a comment stating that the Apache license applies to parts
of the source code. I don't believe it's dual licensed.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-09-30 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 9:18 [bug#28198] [PATCH] Add MongoDB package and service Christopher Baines
2017-08-23 9:25 ` [bug#28198] [PATCH 1/4] vm: Add disk-image-size to <virtual-machine> Christopher Baines
2017-08-23 9:25 ` [bug#28198] [PATCH 2/4] gnu: Add mongodb Christopher Baines
2017-08-31 12:32 ` Ludovic Courtès
2017-09-30 8:04 ` Christopher Baines [this message]
2017-08-23 9:25 ` [bug#28198] [PATCH 3/4] services: Add MongoDB Christopher Baines
2017-08-31 12:34 ` Ludovic Courtès
2017-09-30 8:05 ` Christopher Baines
2017-08-23 9:25 ` [bug#28198] [PATCH 4/4] tests: databases: Add MongoDB test Christopher Baines
2017-08-31 12:37 ` Ludovic Courtès
2017-09-30 8:09 ` Christopher Baines
2017-08-31 12:29 ` [bug#28198] [PATCH 1/4] vm: Add disk-image-size to <virtual-machine> Ludovic Courtès
2017-09-25 20:36 ` Christopher Baines
2017-09-26 7:14 ` Ludovic Courtès
2017-09-29 6:48 ` [bug#28635] " Christopher Baines
2017-08-26 22:33 ` [bug#28198] [PATCH] Add MongoDB package and service Roel Janssen
2017-08-27 22:30 ` Christopher Baines
2017-09-30 7:59 ` [bug#28198] [PATCH 1/3] vm: Add disk-image-size to <virtual-machine> Christopher Baines
2017-09-30 7:59 ` [bug#28198] [PATCH 2/3] gnu: Add mongodb Christopher Baines
2017-10-04 14:40 ` Ludovic Courtès
2017-09-30 7:59 ` [bug#28198] [PATCH 3/3] services: Add MongoDB Christopher Baines
2017-10-04 14:44 ` Ludovic Courtès
2017-10-06 20:29 ` bug#28198: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170930090420.7a29807b@cbaines.net \
--to=mail@cbaines.net \
--cc=28198@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).