From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dy0uH-0007C6-JQ
	for guix-patches@gnu.org; Fri, 29 Sep 2017 15:25:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dy0uE-0002ZO-Dx
	for guix-patches@gnu.org; Fri, 29 Sep 2017 15:25:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:59189)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dy0uE-0002ZD-A4
	for guix-patches@gnu.org; Fri, 29 Sep 2017 15:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dy0uE-0000K3-4N
	for guix-patches@gnu.org; Fri, 29 Sep 2017 15:25:02 -0400
Subject: [bug#28586] [PATCH 2/2] gnu: Add Syncthing.
Resent-Message-ID: <handler.28586.B28586.15067130821207@debbugs.gnu.org>
Date: Fri, 29 Sep 2017 15:24:31 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20170929192431.GA12405@jasmine.lan>
References: <fd4f5962c0ba60f54823815b1fa8f0c22bd315a8.1506285652.git.leo@famulari.name>
	<5f9b36da2183c37cb24713472ea22921c0f48d36.1506285652.git.leo@famulari.name>
	<20170925182144.GA16527@jasmine.lan>
	<20170925192852.GA12757@jasmine.lan> <87d16d3o0f.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87d16d3o0f.fsf@gnu.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 28586@debbugs.gnu.org

On Tue, Sep 26, 2017 at 09:41:36AM +0200, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> Note that it should always return a Boolean:
> 
>   (or (zero? (system* "go" "install" …))
>       (begin  ;we failed but we want to print debugging info
>         (system* "go" "env")
>         #f))

Ah, yes, thanks for the reminder.

> > However, when it encounters a failure, it does not seem to run `go env`:
> >
> > ------
> > [...]
> > 	/gnu/store/40m4imp31qkhl2yqvxm4dfaw0j6hgfr2-golang-github-com-golang-groupcache-lru-0.0.0-0.72d04f9/src/github.com/pkg/errors
> > 	/gnu/store/dn3hbj11bzk6ys3yj5k36k7a9fyg1zp8-golang-github-com-edsrzf-mmap-go-0.0.0-0.0bce6a6/src/github.com/pkg/errors
> > 	/gnu/store/h36806f660r6p5xzwsc89zrbfnvi6nwi-golang-github-com-d4l3k-messagediff-1.1.0-0.29f32d8/src/github.com/pkg/errors
> > exit status 1
> > exit status 1
> > phase `build' failed after 1.9 seconds
> 
> I think it just means that “go env” returned with exit code 1, no?

No, it prints 'exit status 1' twice even when the `go env` invocation is
removed from the build phase. This particular case was really about
making debugging easier for me. It's not necessary to run `go env` when
things fail.

I'm still trying to solve the previously mentioned issue about certain
inputs needing to be propagated...