From: Thomas Danckaert <post@thomasdanckaert.be>
To: leo@famulari.name
Cc: 27922@debbugs.gnu.org
Subject: [bug#27922] [PATCH] gnu: python-numpy: Update to 1.12.1.
Date: Tue, 26 Sep 2017 18:59:21 +0200 (CEST) [thread overview]
Message-ID: <20170926.185921.1683575194897240087.post@thomasdanckaert.be> (raw)
In-Reply-To: <20170926154620.GB11123@jasmine.lan>
[-- Attachment #1: Type: Text/Plain, Size: 1234 bytes --]
From: Leo Famulari <leo@famulari.name>
Subject: Re: [bug#27922] [PATCH] gnu: python-numpy: Update to 1.12.1.
Date: Tue, 26 Sep 2017 11:46:20 -0400
> On Tue, Sep 26, 2017 at 01:48:45PM +0200, Ludovic Courtès wrote:
>> Thomas Danckaert <post@thomasdanckaert.be> skribis:
>> > I can push a modified patch (with the pypi source) if it's ok.
>> Is there
>> > any reason we would not update to version 1.13.1 rightaway?
>>
>> If the dependents of NumPy build fine, I see no reason not to
>> upgrade to
>> 1.13.1.
>>
>> Thanks for picking this up!
>
> Yes, thank you! I got distracted and had to take a little break,
> which
> is why this patch fell by the wayside.
Attached patch updates to 1.13.1. I had to add bash-minimal as a
native input because the numpy people made their build system a
little more convoluted ;-) (external commands such as gcc are run
within a shell with $SHELL -c 'gcc [...]', I didn't look up the
motivation for that).
If there are no objections, I'll push this soon.
Thomas
ps I couldn't check if matplotlib still builds with this numpy
version, because our bluez package (on which matplotlib apparently
depends) appears to be broken. But that's another story.
[-- Attachment #2: 0001-gnu-python-numpy-Update-to-1.13.1.patch --]
[-- Type: Text/X-Patch, Size: 2308 bytes --]
From 2b90b6e2a9b7ac73937ee8e52b08bb715ba33fb7 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <post@thomasdanckaert.be>
Date: Tue, 26 Sep 2017 16:26:08 +0200
Subject: [PATCH] gnu: python-numpy: Update to 1.13.1.
* gnu/packages/python.scm (python-numpy, python2-numpy): Update to 1.12.1.
[source]: Download the zip release from pypi instead of a git snapshot.
[native-inputs]: Add unzip and bash-minimal.
[arguments]: Set SHELL environment variable.
Co-authored by Leo Famulari <leo@famulari.name>
---
gnu/packages/python.scm | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5dcb5a05c..6b9de923d 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3720,22 +3720,24 @@ between language specification and implementation aspects.")
(define-public python-numpy
(package
(name "python-numpy")
- (version "1.12.0")
+ (version "1.13.1")
(source
(origin
(method url-fetch)
- (uri (string-append
- "https://github.com/numpy/numpy/archive/v" version ".tar.gz"))
- (file-name (string-append name "-" version ".tar.gz"))
+ (uri (pypi-uri "numpy" version ".zip"))
(sha256
(base32
- "025d4j4aakcp8w5i5diqh812cbbjgac7jszx1j56ivrbi1i8vv7d"))))
+ "1fsgkhh1vdkhmlz8vmdgxnj9n9yaanckxxzz9s0b4p08fqvjic69"))))
(build-system python-build-system)
(inputs
`(("openblas" ,openblas)
("lapack" ,lapack)))
(native-inputs
- `(("python-cython" ,python-cython)
+ `(("unzip" ,unzip)
+ ;; We need bash because numpy's distutils runs external commands with
+ ;; $SHELL -c '...'.
+ ("bash" ,bash-minimal)
+ ("python-cython" ,python-cython)
("python-nose" ,python-nose)
("gfortran" ,gfortran)))
(arguments
@@ -3743,6 +3745,8 @@ between language specification and implementation aspects.")
(modify-phases %standard-phases
(add-before 'build 'set-environment-variables
(lambda* (#:key inputs #:allow-other-keys)
+ (setenv "SHELL"
+ (string-append (assoc-ref inputs "bash") "/bin/bash"))
(call-with-output-file "site.cfg"
(lambda (port)
(format port
--
2.14.1
next prev parent reply other threads:[~2017-09-26 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 19:49 [bug#27922] [PATCH] gnu: python-numpy: Update to 1.12.1 Leo Famulari
2017-08-02 20:12 ` Marius Bakke
2017-08-02 22:48 ` Leo Famulari
2017-09-04 13:19 ` Ludovic Courtès
2017-09-26 9:53 ` Thomas Danckaert
2017-09-26 11:48 ` Ludovic Courtès
2017-09-26 15:46 ` Leo Famulari
2017-09-26 16:59 ` Thomas Danckaert [this message]
2017-09-26 20:08 ` Ludovic Courtès
2017-09-27 6:36 ` Thomas Danckaert
2017-09-27 19:35 ` Ludovic Courtès
2017-09-28 18:32 ` Thomas Danckaert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926.185921.1683575194897240087.post@thomasdanckaert.be \
--to=post@thomasdanckaert.be \
--cc=27922@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).