From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dsKiA-0005tX-N9
	for guix-patches@gnu.org; Wed, 13 Sep 2017 23:21:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dsKi6-000148-Km
	for guix-patches@gnu.org; Wed, 13 Sep 2017 23:21:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58885)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dsKi6-000144-Hu
	for guix-patches@gnu.org; Wed, 13 Sep 2017 23:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dsKi6-0007K6-BG
	for guix-patches@gnu.org; Wed, 13 Sep 2017 23:21:02 -0400
Subject: bug#28429: [PATCH] gnu: Add John the Ripper.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.28429.D28429.150535922128079.done@debbugs.gnu.org>
Date: Wed, 13 Sep 2017 22:20:07 -0500
From: Eric Bavier <ericbavier@centurylink.net>
Message-ID: <20170913222007.1dd3ad35@centurylink.net>
In-Reply-To: <874ls647le.fsf@gnu.org>
References: <20170912025014.27269-1-bavier@member.fsf.org>
	<87vakn3tog.fsf@gnu.org> <20170913084627.535c4ec5@centurylink.net>
	<874ls647le.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 28429-done@debbugs.gnu.org

On Wed, 13 Sep 2017 23:22:21 +0200
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> >> /etc/passwd in the build environment has this line (see
> >> nix/libstore/build.cc:1859):
> >>=20
> >>   nixbld:x:%1%:%2%:Nix build user:/:/noshell
> >>=20
> >> Isn=E2=80=99t it sufficient to have =E2=80=9C/=E2=80=9D as the home di=
rectory? =20
> >
> > It seems the build user noes not have sufficient permissions to create a
> > directory there?  The tests want to create "~/.john" (specifically
> > "//.john"). =20
>=20
> And setting =E2=80=98HOME=E2=80=99 isn=E2=80=99t enough?  (There are seve=
ral packages where we
> do that right before the =E2=80=98check=E2=80=99 phase.)

The code accesses 'getpwuid(getuid())->pw_dir', so effectively ignores
'HOME'.

>=20
> > From dd9795e5d63beaf06f2e3c76944e82a5564dc87d Mon Sep 17 00:00:00 2001
> > From: Eric Bavier <bavier@member.fsf.org>
> > Date: Mon, 11 Sep 2017 21:44:14 -0500
> > Subject: [PATCH] gnu: Add John the Ripper.
> >
> > * gnu/packages/password-utils.scm (john-the-ripper-jumbo): New variable=
. =20
>=20
> Perfect, thanks!

Pushed in eb28a777b5ad13e88d5932e9f97c976a079c94ac.

`~Eric