From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28177@debbugs.gnu.org
Subject: [bug#28177] [PATCH 01/12] gnu: Add discount.
Date: Tue, 12 Sep 2017 21:57:23 +0100 [thread overview]
Message-ID: <20170912215723.729b6015@cbaines.net> (raw)
In-Reply-To: <87ingq7kma.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Sun, 10 Sep 2017 15:23:41 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
> > This is required by perl-text-markdown-discount, which is required
> > by ikiwiki.
> >
> > * gnu/packages/markdown.scm (discount) New variable.
>
> [...]
>
> > + (add-before 'configure 'set_ac_default_path
> > + (lambda args
> > + (substitute* "configure.inc"
> > + (("ac_default_path=\".*\"")
> > + (string-append "ac_default_path=\"" (getenv
> > "PATH") "\"")))
> > + #t)))))
>
> Did you check the references of the resulting store item? It seems to
> me that we might end up referring too much if this value is recorded
> in the binary (GCC, Binutils, Make, etc.).
>
> Perhaps we should instead set it to a very specific list, say
> coreutils, grep, sed, or whatever is expected?
The store item references look fine, I think this is just the path the
configure.inc script searches. In looking at this again, I discovered
that setting the AC_PATH environment variable has the same effect, so
I've updated the patch to do that, as well as adding a comment to
clarify that these are used at build time only.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-09-12 20:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 18:04 [bug#28177] [PATCH] Add ikiwiki and dependencies Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 01/12] gnu: Add discount Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 02/12] gnu: Add perl-text-markdown-discount Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 03/12] gnu: Add perl-test-cpan-meta-json Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 04/12] gnu: Add perl-test-cpan-meta Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 05/12] gnu: Add perl-devel-cycle Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 06/12] gnu: Add perl-test-memory-cycle Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 07/12] gnu: Add perl-test-notabs Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 08/12] gnu: Add perl-test-eol Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 09/12] gnu: Add perl-html-scrubber Christopher Baines
2017-09-10 13:25 ` Ludovic Courtès
2017-09-12 21:36 ` Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 10/12] gnu: Add perl-yaml-libyaml Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 11/12] gnu: Add perl-cgi-session Christopher Baines
2017-08-21 18:08 ` [bug#28177] [PATCH 12/12] gnu: Add ikiwiki Christopher Baines
2017-09-10 13:27 ` Ludovic Courtès
2017-09-12 21:38 ` Christopher Baines
2017-09-10 13:23 ` [bug#28177] [PATCH 01/12] gnu: Add discount Ludovic Courtès
2017-09-12 20:57 ` Christopher Baines [this message]
2017-09-12 21:38 ` Christopher Baines
2017-09-12 21:38 ` [bug#28177] [PATCH 02/12] gnu: Add perl-text-markdown-discount Christopher Baines
2017-09-12 21:38 ` [bug#28177] [PATCH 03/12] gnu: Add perl-test-cpan-meta-json Christopher Baines
2017-09-12 21:38 ` [bug#28177] [PATCH 04/12] gnu: Add perl-test-cpan-meta Christopher Baines
2017-09-12 21:38 ` [bug#28177] [PATCH 05/12] gnu: Add perl-devel-cycle Christopher Baines
2017-09-12 21:38 ` [bug#28177] [PATCH 06/12] gnu: Add perl-test-memory-cycle Christopher Baines
2017-09-12 21:38 ` [bug#28177] [PATCH 07/12] gnu: Add perl-test-notabs Christopher Baines
2017-09-12 21:39 ` [bug#28177] [PATCH 08/12] gnu: Add perl-test-eol Christopher Baines
2017-09-12 21:39 ` [bug#28177] [PATCH 09/12] gnu: Add perl-html-scrubber Christopher Baines
2017-09-12 21:39 ` [bug#28177] [PATCH 10/12] gnu: Add perl-yaml-libyaml Christopher Baines
2017-09-12 21:39 ` [bug#28177] [PATCH 11/12] gnu: Add perl-cgi-session Christopher Baines
2017-09-12 21:39 ` [bug#28177] [PATCH 12/12] gnu: Add ikiwiki Christopher Baines
2017-09-13 8:17 ` [bug#28177] [PATCH 01/12] gnu: Add discount Ludovic Courtès
2017-09-13 17:21 ` bug#28177: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912215723.729b6015@cbaines.net \
--to=mail@cbaines.net \
--cc=28177@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).