unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28399@debbugs.gnu.org
Subject: [bug#28399] [PATCH 1/2] services: mysql: Fix missing modules on activation.
Date: Tue, 12 Sep 2017 19:48:25 +0100	[thread overview]
Message-ID: <20170912194825.70eb4436@cbaines.net> (raw)
In-Reply-To: <87shftd67d.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On Mon, 11 Sep 2017 09:50:46 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Hi Chris,
> 
> Christopher Baines <mail@cbaines.net> skribis:
> 
> > Some systems using the MySQL service would fail to boot, giving the
> > error:
> >
> >   ERROR: no code for module (ice-9 popen)
> >
> > * gnu/services/databases.scm (%mysql-activation): Wrap the gexp
> > using with-imported-modules, to ensure that the required modules
> > are available.  
> 
> [...]
> 
> > +    (with-imported-modules '((ice-9 popen)
> > +                             (guix build utils))  
> 
> The effect of this would be to import (ice-9 popen) from the host
> Guile in the build side.  Thus someone running Guile 2.2.2 on the
> host would get a slightly different file from someone running Guile
> 2.0.14, and so on, which hinders reproducibility.

That makes sense.

> The ‘use-modules’ form should be enough.  Does the test you sent
> reproduce the original problem?

It does for me. If you just revert the commit adding in the
with-imported-modules bit, running the mysql system test then fails:

ERROR: In procedure scm-error:
ERROR: no code for module (ice-9 popen)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

  reply	other threads:[~2017-09-12 18:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09 14:39 [bug#28399] [PATCH]: Fix mysql activation, and add a basic test Christopher Baines
2017-09-09 14:53 ` [bug#28399] [PATCH 1/2] services: mysql: Fix missing modules on activation Christopher Baines
2017-09-09 14:53   ` [bug#28399] [PATCH 2/2] tests: databases: Add a simple test for MySQL Christopher Baines
2017-09-11  7:50   ` [bug#28399] [PATCH 1/2] services: mysql: Fix missing modules on activation Ludovic Courtès
2017-09-12 18:48     ` Christopher Baines [this message]
2017-09-15 22:02       ` Ludovic Courtès
2017-09-16 10:38         ` Christopher Baines
2017-09-20  9:21           ` Ludovic Courtès
2017-10-08  9:06             ` Christopher Baines
2017-10-08 15:26               ` Ludovic Courtès
2017-10-08 16:34                 ` bug#28399: " Christopher Baines
2017-10-08 19:19                   ` [bug#28399] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170912194825.70eb4436@cbaines.net \
    --to=mail@cbaines.net \
    --cc=28399@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).