From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28272@debbugs.gnu.org
Subject: [bug#28272] [PATCH] Improve and upgrade signing-party.
Date: Sun, 10 Sep 2017 19:42:48 +0100 [thread overview]
Message-ID: <20170910194248.4be0d575@cbaines.net> (raw)
In-Reply-To: <87poay7l1l.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]
On Sun, 10 Sep 2017 15:14:30 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
> > On Fri, 08 Sep 2017 18:07:01 +0200
> > ludo@gnu.org (Ludovic Courtès) wrote:
> >
> >> Christopher Baines <mail@cbaines.net> skribis:
> >>
> >> > Add several missing dependencies, particularly for the caff
> >> > tool. It now runs, but I've been unable to get it working fully
> >> > yet, possibly due to problems with the actual sending of the
> >> > emails.
> >> >
> >> > Christopher Baines (12):
> >> > gnu: Add perl-moox.
> >> > gnu: Add perl-data-perl.
> >> > gnu: Add perl-moox-handlesvia.
> >> > gnu: Add perl-moox-late.
> >> > gnu: Add perl-convert-binhex.
> >> > gnu: Add perl-mailtools.
> >> > gnu: Add perl-mime-tools.
> >> > gnu: Add perl-net-idn-encode.
> >> > gnu: Add perl-text-template.
> >> > gnu: Add perl-gnupg-interface.
> >> > gnu: Add libmd.
> >> > gnu: Update signing-party.
> >>
> >> At first sight this looks good to me.
> >
> > Great, thanks for reviewing :)
> >
> >> Please use ‘license:perl-license’ instead of (package-license
> >> perl).
> >
> > Within (gnu packages perl), it doesn't use a prefix for the licenses
> > module. I could switch it to use the license: prefix, or use just
> > perl-license within that module. Do you have a preference?
>
> Either way is fine. My point is: use the ‘perl-license’ binding of
> (guix licenses), not (package-license perl).
>
> See the rationale in (guix licenses).
Ok, I'll switch these packages over to use perl-license, and the other
perl ones I've done recently.
Also, if this is a sensible thing to do, it's probably worth changing
the importer to match, I've sent a patch as #28410 [1].
1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28410
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-09-10 18:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 6:07 [bug#28272] [PATCH] Improve and upgrade signing-party Christopher Baines
2017-08-29 6:12 ` [bug#28272] [PATCH 01/12] gnu: Add perl-moox Christopher Baines
2017-08-29 6:12 ` [bug#28272] [PATCH 02/12] gnu: Add perl-data-perl Christopher Baines
2017-08-29 6:12 ` [bug#28272] [PATCH 03/12] gnu: Add perl-moox-handlesvia Christopher Baines
2017-08-29 6:12 ` [bug#28272] [PATCH 04/12] gnu: Add perl-moox-late Christopher Baines
2017-08-29 6:12 ` [bug#28272] [PATCH 05/12] gnu: Add perl-convert-binhex Christopher Baines
2017-08-29 6:12 ` [bug#28272] [PATCH 06/12] gnu: Add perl-mailtools Christopher Baines
2017-08-29 6:13 ` [bug#28272] [PATCH 07/12] gnu: Add perl-mime-tools Christopher Baines
2017-08-29 6:13 ` [bug#28272] [PATCH 08/12] gnu: Add perl-net-idn-encode Christopher Baines
2017-08-29 6:13 ` [bug#28272] [PATCH 09/12] gnu: Add perl-text-template Christopher Baines
2017-08-29 6:13 ` [bug#28272] [PATCH 10/12] gnu: Add perl-gnupg-interface Christopher Baines
2017-08-29 6:13 ` [bug#28272] [PATCH 11/12] gnu: Add libmd Christopher Baines
2017-08-29 6:13 ` [bug#28272] [PATCH 12/12] gnu: Update signing-party Christopher Baines
2017-09-08 16:07 ` [bug#28272] [PATCH] Improve and upgrade signing-party Ludovic Courtès
2017-09-10 11:03 ` Christopher Baines
2017-09-10 13:14 ` Ludovic Courtès
2017-09-10 18:42 ` Christopher Baines [this message]
2017-09-12 22:03 ` bug#28272: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170910194248.4be0d575@cbaines.net \
--to=mail@cbaines.net \
--cc=28272@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).