From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqzkb-00012N-1x for guix-patches@gnu.org; Sun, 10 Sep 2017 06:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqzkX-0003pe-Tw for guix-patches@gnu.org; Sun, 10 Sep 2017 06:46:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49754) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqzkX-0003pY-QZ for guix-patches@gnu.org; Sun, 10 Sep 2017 06:46:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dqzkX-0001iY-KF for guix-patches@gnu.org; Sun, 10 Sep 2017 06:46:01 -0400 Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image. Resent-Message-ID: Date: Sun, 10 Sep 2017 11:45:32 +0100 From: Christopher Baines Message-ID: <20170910114532.58628283@cbaines.net> In-Reply-To: <87wp5c0xqr.fsf@gnu.org> References: <20170830071714.75f88e47@cbaines.net> <20170903105041.2925-1-mail@cbaines.net> <877exds2s3.fsf@gnu.org> <20170906080515.4764be7b@cbaines.net> <87wp5c0xqr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/FhBGLbEj_ybSwWRQU=MXXi4"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28288@debbugs.gnu.org --Sig_/FhBGLbEj_ybSwWRQU=MXXi4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 06 Sep 2017 15:20:44 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > On Tue, 05 Sep 2017 15:17:32 +0200 > > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > =20 > >> Hi! > >>=20 > >> Christopher Baines skribis: > >> =20 > >> > This mimics the functionality in the root-partition-initializer > >> > used in creating the QEMU image. This helps when trying to run > >> > guix system init from the generated ISO image. > >> > > >> > * gnu/build/vm.scm (make-iso9660-image): Add support for > >> > registering closures. =20 > >>=20 > >> [...] > >> =20 > >> > + (when register-closures? > >> > + (display "registering closures...\n") > >> > + (for-each (lambda (closure) > >> > + (register-closure > >> > + "/tmp/root" > >> > + (string-append "/xchg/" closure) > >> > + #:deduplicate? #f)) > >> > + closures)) =20 > >>=20 > >> Was there any specific reason for #:deduplicate? #f here? =20 > > > > Yep, the image creation process fails if this is not specified. > > > > error: cannot link > > `/tmp/root/gnu/store/.links/1wj8bqv0ygz606a0day0gk7w37prsnbg5z2im2yf025= r0y6lqfs0' > > to > > `/tmp/root/gnu/store/00lgsgxvv1hfhl22yqmzsa3lrs5qa9my-firmware/lib/firm= ware/b43-open': > > Invalid cross-device link =20 >=20 > Hmm, OK. Looks like it=E2=80=99s trying to deduplicate between /tmp/root= and > some other store. (Or are we using a bind mount here?) I think there is a bind mount in use here, so maybe that has something to do with it. > > There is probably another way around this though. I'm not sure what > > impact skipping the deduplication has on the size of the image. =20 >=20 > It probably doesn=E2=80=99t matter much, so it=E2=80=99s not a blocker IM= O. >=20 > Maybe leave an XXX comment mentioning the cross-device link issue. Yep, I'll put in a comment :) --Sig_/FhBGLbEj_ybSwWRQU=MXXi4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlm1F8xfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XewhQ/+LlfUZtsQ0zvNhcjJ0DCCK7uHbL27VgBnJhYbbq37WEWOjXTx8y2/MtTG 6o0KBhoudHLjy375ktzSpu9zfI76qFsHUiPbosB4XlelJWrfNZpjVCM8Ro4nmeFj Md+lmDbpCmVKsG1obwwPLvOHRYeziKv50tq5sNbgikvHOepBNgk6WMXiJ9QeiSl9 zT/VzOLXgpo6eIWY6/UYUUJfOqBbq3WUQiq3vDD8dmUViTE/2SMPUXYozeTo4iTL m7bFTcsf1mBc2SVKEze36IEtctmXG4CSl3wqPtQADtN44/FeVuEf4Nr80Xb+6eYl jlh2mA0NIZR9Qn22cuAs5Ovil41alLf5Yhwn3s655QTEMbY5tVsVMAoN4w+YdihR 7M7QcSrPnTtndCWcmRfuqkX4FwPgDGZHhId1obf6zjSrNNZKEIGUmNFqPgDHb4Mb QkASak5pser3OSNtWTgyicF9l4uPey24U1/iehgIwLni4dKh7Tc5fOki8mfkS7Eh t8Aw8Oh8n+ihNmgkP4ysDoLdCKQnxrS4vnfQN5Disc/TITvyK1z6pp0S5f5m7IgD d03qpls9DjmPvvVcJVKE+OK/q2GrtjCzOPzn534JHAa+07Fha7qUQTUieUGGiuTv Ody6GYXbvGJ3yabDXq1uW9OqXTGMjEnQMnRs0xWUhsVD3p20FfQ= =9AZJ -----END PGP SIGNATURE----- --Sig_/FhBGLbEj_ybSwWRQU=MXXi4--