From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doA2l-0005Wg-Kh for guix-patches@gnu.org; Sat, 02 Sep 2017 11:09:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doA2g-0000nJ-NI for guix-patches@gnu.org; Sat, 02 Sep 2017 11:09:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1doA2g-0000mw-Fi for guix-patches@gnu.org; Sat, 02 Sep 2017 11:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1doA2g-0008QI-AV for guix-patches@gnu.org; Sat, 02 Sep 2017 11:09:02 -0400 Subject: bug#28321: [PATCH] gnu: net-tools: Build from a source archive instead of a Git checkout. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sat, 2 Sep 2017 11:08:40 -0400 From: Leo Famulari Message-ID: <20170902150840.GB31990@jasmine.lan> References: <86632647dc295f5277452ef0a87372ea77344af4.1504295367.git.leo@famulari.name> <87efrpl5yz.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Content-Disposition: inline In-Reply-To: <87efrpl5yz.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 28321-done@debbugs.gnu.org --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 02, 2017 at 01:01:24PM +0200, Marius Bakke wrote: > Leo Famulari writes: > > * gnu/packages/linux.scm (net-tools)[source]: Use url-fetch and adjust > > the source URL accordingly. > > [native-inputs]: Add UNZIP. > > (net-tools-for-tests)[native-inputs]: Add field so that we can exclude = UNZIP. > > + (native-inputs `(("gettext" ,gettext-minimal))) >=20 > Can you add a short comment mentioning why we override native-inputs here? > > Apart from that LGTM. I assume you know whether or not this has to go > through 'core-updates'. We override the native-inputs of net-tools-for-tests so that this change is suitable for the master branch. The net-tools-for-tests derivation is unchanged. Commented and pushed as 631c9f743fe45dfb1cc5d174b03e737a264b18e6. --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmqyXgACgkQJkb6MLrK fwgG/g//QO6MnI1Z70aHloSoAboafz+ob3HPaoV45qMbT3Q06dScJbf9x+3SxMMq fvT+Lh/jCXsXymCTaOGUkvDF0arnj64S5lSw20WwOzQ/VEEDIZ2Oj7ORfOpBxuRt jtmEpgujN/AG62Q3wfVwAnOD4vjl957/9eq3gnvJOOgnJCWeE/mm8hsFBEfKCAcF 59NVCkM1zqZFUTWmXpmHcEEC86riZc2vGySJBe5sefojlZ/trRmcXsWL199fEjBo +snbltCqVjqYX66gwWFf9XQ+IPJPQzeKd/lgk4KjHBevcxEs1lZUPkVaGEKo4idO z4F1xRrB2n0T8QzciDtUxlQ9znVufzFYj9YeolCwaUschbj1vo74VQp0JZiKOV4u 2jy1qt3o+776nNWWYvsRUVti6s4kT/1wzZkRKOP5+urmU54B3p8hTCTC/G6THxVW JYx0UfD1QnCucLD2LIc5zU5SPy7j0c2lnhfACR2BT7ZWTenO4/Jj/IT1m+p9RqTY W1xIvmdvljthrT8Kot4fVOgkWYxIBXKHjaB+fklXAZYtml7YdlqDtlz0Ae4HPflq 3+ZbsULHWh/mmE0aRdnf+oHtJuZwz1li1xGhAyQ/9lkqfv8g+4yg6SvKRZUM8pdE A+7ETYYRgJl7eS138meqLQk7xhSobSLbIxeabxGeeodNI+k8Mhk= =87MW -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7--