unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: 28330@debbugs.gnu.org
Subject: [bug#28330] [PATCH 1/2] lint: Check file names of origin patches.
Date: Sat,  2 Sep 2017 15:09:46 +0200	[thread overview]
Message-ID: <20170902130947.28372-1-mbakke@fastmail.com> (raw)
In-Reply-To: <20170902130550.28061-1-mbakke@fastmail.com>

* guix/scripts/lint.scm (check-patch-file-names): Add case for when PATCH is
an <origin>.
---
 guix/scripts/lint.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index aceafc674..855b6262f 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -561,7 +561,13 @@ patch could not be found."
                       (and=> (string-contains (basename patch)
                                               (package-name package))
                              zero?))
-                     (_  #f))     ;must be an <origin> or something like that.
+                     ((? origin? patch)
+                      (if (string? (origin-file-name patch))
+                          (and=> (string-contains (origin-file-name patch)
+                                                  (package-name package))
+                                 zero?)
+                          #f))
+                     (_  #f))
                    (or (and=> (package-source package) origin-patches)
                        '()))
       (emit-warning
-- 
2.14.1

  reply	other threads:[~2017-09-02 13:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02 13:05 [bug#28330] [PATCH 0/2] Boost 1.65.0 Marius Bakke
2017-09-02 13:09 ` Marius Bakke [this message]
2017-09-02 13:09   ` [bug#28330] [PATCH staging 2/2] gnu: boost: Update to 1.65.0 Marius Bakke
2017-09-05 13:12     ` Ludovic Courtès
2017-09-05 13:11   ` [bug#28330] [PATCH 1/2] lint: Check file names of origin patches Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170902130947.28372-1-mbakke@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=28330@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).