From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmwoC-0004xb-5T for guix-patches@gnu.org; Wed, 30 Aug 2017 02:49:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmwoB-00078L-6B for guix-patches@gnu.org; Wed, 30 Aug 2017 02:49:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52719) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmwoB-00078B-2S for guix-patches@gnu.org; Wed, 30 Aug 2017 02:49:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dmwoA-0001eF-SX for guix-patches@gnu.org; Wed, 30 Aug 2017 02:49:02 -0400 Subject: [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful. Resent-Message-ID: Date: Wed, 30 Aug 2017 07:48:51 +0100 From: Christopher Baines Message-ID: <20170830074851.3f2f20cf@cbaines.net> In-Reply-To: <87d17eqc87.fsf@gnu.org> References: <20170822171303.21754-1-mail@cbaines.net> <3c5556d2.ADkAAC0m-p4AAAAAAAAAAAPmDT4AAAACwQwAAAAAAAW9WABZpQjV@mailjet.com> <20170829075827.72c9a858@cbaines.net> <87d17eqc87.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/5y_iU3mxIT5EI0j2_a4Cs+D"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28185@debbugs.gnu.org --Sig_/5y_iU3mxIT5EI0j2_a4Cs+D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 29 Aug 2017 23:46:00 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello! >=20 > Christopher Baines skribis: >=20 > > On Tue, 29 Aug 2017 11:55:08 +0530 > > Arun Isaac wrote: > > =20 > >> Christopher Baines writes: > >> =20 > >> > Modify the install phase to detect when nothing has been > >> > installed, and error if this happens. This is preferable to > >> > continuing, and allowing the next phase to fail. > >> > > >> > Also, when nothing can be found to be installed, print out each > >> > file that was considered, along with the regular expressions that > >> > were used to include and exclude it. > >> > > >> > * gnu/build/emacs-build-system.scm (install-file?): Add > >> > additional error checking and logging. > >> > --- > >> > guix/build/emacs-build-system.scm | 45 > >> > ++++++++++++++++++++++++++++----------- 1 file changed, 32 > >> > insertions(+), 13 deletions(-) =20 > >>=20 > >> I feel that this adds a lot of complexity (lines of code) to the > >> emacs-build-system checking for an error that can be quite easily > >> identified and fixed otherwise. > >>=20 > >> WDYT? Maybe, others can comment on this as well. =20 > > > > In my personal experience, I didn't find this easy to identify and > > fix. For packaging emacs-minitest, I ended up writing this to pin > > down why the emacs-build-system wasn't installing the key file. > > > > I think validating that something has been installed is really > > important, as otherwise the later phases fail in a very unclear way. > > > > The extra functionality about explaining why each file hasn't been > > installed is useful for debugging, and I agree that it adds > > significant complexity. =20 >=20 > I agree. I=E2=80=99m guessing you wrote this after spending a while > debugging a build, despite being experienced with Guix, which to me > suggests that this is a welcome improvement, in spite of the extra > complexity. >=20 > > But, I'd like for packaging emacs things to be really easy in the > > general case, and I think making the build system more helpful when > > it fails is one way to improve this. I wouldn't like to expect that > > you'd need to read the implementation of the build system, or add > > in your own debugging code just to package a emacs module. =20 >=20 > Sounds reasonable. >=20 > To me this looks like a step in the right direction. Ok, thanks for your review Ludo :) --Sig_/5y_iU3mxIT5EI0j2_a4Cs+D Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmmX9NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfi/w//RrtK2RSQJ04vjN1ZOmJ+im9+822bKGMEVEZXOsF/ssPnGoMb71YJotTG h38c05BbYgH4npKuB6CnuWZ4QNV/ty3SgV/SEG/cr4JlQn9Au8xPuLbJ2Rb9w+xX Pongm/rRI9RgmcygJsfczIlSP+bdRc2Hwx+SrZqVt/w1y9er+KxpT7s5VyvwCKP5 bm/tPbIRC+4Enx+Q/mVkXp2G1E86H4O2N9rehyfA/bpjLb73zhqPgDXKJSlf0x0P lu8w9Djm2TS70HGnjQLLWB0HwBHp6ezxn4Lv7LYPZRrbXMODGNSNlo+ja+hIkiz0 d00X0d5eNic6fvcRxsXR3LaFC3xEqNa9rSfr6DWh1NYWKkqfwp2r5uM+cZOmzUBH gYbY8KldaMlC/SIELyaDWA4P78FLdxppOMh2SE77RYyk4sKiRWSTv+nlN/awMwaR 0M9jtonxA7FZ1Ghahi0efe2wnkkZd3WUoG815hX/z9q6XEnD4uavrymDvBqcqZDD ajJEZ44aKtN0WNNvZv3Jq/jVmppYIW2AJN5YsNl3lDAA9KBXGZiT27ZaA8/u+TdJ RuNR8fVLOoBDI16QrrN7UZNmWUnNPZxG40g2yfBYBqLWiPezStzoNvf4LbHucjM4 5FnB7ggdEqRlg+ykXtbDkklfSLdAG//5nJ/6xcuWmNSZUxzpwXU= =fXzu -----END PGP SIGNATURE----- --Sig_/5y_iU3mxIT5EI0j2_a4Cs+D--