From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28185@debbugs.gnu.org
Subject: [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful.
Date: Wed, 30 Aug 2017 07:48:51 +0100 [thread overview]
Message-ID: <20170830074851.3f2f20cf@cbaines.net> (raw)
In-Reply-To: <87d17eqc87.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2462 bytes --]
On Tue, 29 Aug 2017 23:46:00 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Hello!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
> > On Tue, 29 Aug 2017 11:55:08 +0530
> > Arun Isaac <arunisaac@systemreboot.net> wrote:
> >
> >> Christopher Baines writes:
> >>
> >> > Modify the install phase to detect when nothing has been
> >> > installed, and error if this happens. This is preferable to
> >> > continuing, and allowing the next phase to fail.
> >> >
> >> > Also, when nothing can be found to be installed, print out each
> >> > file that was considered, along with the regular expressions that
> >> > were used to include and exclude it.
> >> >
> >> > * gnu/build/emacs-build-system.scm (install-file?): Add
> >> > additional error checking and logging.
> >> > ---
> >> > guix/build/emacs-build-system.scm | 45
> >> > ++++++++++++++++++++++++++++----------- 1 file changed, 32
> >> > insertions(+), 13 deletions(-)
> >>
> >> I feel that this adds a lot of complexity (lines of code) to the
> >> emacs-build-system checking for an error that can be quite easily
> >> identified and fixed otherwise.
> >>
> >> WDYT? Maybe, others can comment on this as well.
> >
> > In my personal experience, I didn't find this easy to identify and
> > fix. For packaging emacs-minitest, I ended up writing this to pin
> > down why the emacs-build-system wasn't installing the key file.
> >
> > I think validating that something has been installed is really
> > important, as otherwise the later phases fail in a very unclear way.
> >
> > The extra functionality about explaining why each file hasn't been
> > installed is useful for debugging, and I agree that it adds
> > significant complexity.
>
> I agree. I’m guessing you wrote this after spending a while
> debugging a build, despite being experienced with Guix, which to me
> suggests that this is a welcome improvement, in spite of the extra
> complexity.
>
> > But, I'd like for packaging emacs things to be really easy in the
> > general case, and I think making the build system more helpful when
> > it fails is one way to improve this. I wouldn't like to expect that
> > you'd need to read the implementation of the build system, or add
> > in your own debugging code just to package a emacs module.
>
> Sounds reasonable.
>
> To me this looks like a step in the right direction.
Ok, thanks for your review Ludo :)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-08-30 6:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 17:13 [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful Christopher Baines
2017-08-29 6:25 ` Arun Isaac
2017-08-29 6:31 ` Jelle Licht
2017-08-29 7:46 ` Arun Isaac
[not found] ` <3c5556d2.ADkAAC0m-p4AAAAAAAAAAAPmDT4AAAACwQwAAAAAAAW9WABZpQjV@mailjet.com>
2017-08-29 6:58 ` Christopher Baines
2017-08-29 21:46 ` Ludovic Courtès
2017-08-30 6:48 ` Christopher Baines [this message]
2017-08-29 21:50 ` Ludovic Courtès
2017-08-30 7:28 ` Christopher Baines
2017-08-30 8:39 ` Ludovic Courtès
2017-08-30 6:48 ` Christopher Baines
2017-08-30 8:07 ` Arun Isaac
[not found] ` <6f595802.AEMAPOK4d0UAAAAAAAAAAAPmDT4AAAACwQwAAAAAAAW9WABZpnJ1@mailjet.com>
2017-08-31 21:41 ` Christopher Baines
2017-09-01 5:02 ` Arun Isaac
[not found] ` <d5168f7c.AEAAPQNLdNwAAAAAAAAAAAPmDT4AAAACwQwAAAAAAAW9WABZqOnq@mailjet.com>
2017-09-01 21:08 ` bug#28185: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830074851.3f2f20cf@cbaines.net \
--to=mail@cbaines.net \
--cc=28185@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).