[bug#28253] perl-www-opensearch: provide Test-Simple module

[bug#28253] perl-www-opensearch: provide Test-Simple module

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 328 bytes --]

This was supposed to fix the tests, but it doesn't
so someone has to fix the large number of failing tests.

Someone with perl test-simple knowledge or time to
read into it.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #1.2: 0001-gnu-perl-www-opensearch-Provide-Test-Simple.patch --]
[-- Type: text/plain, Size: 1180 bytes --]

From 8835552a2ade6f598570fdc412a38cca88a5d441 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sun, 27 Aug 2017 18:18:24 +0000
Subject: [PATCH] gnu: perl-www-opensearch: Provide Test-Simple.

* gnu/packages/web.scm (perl-www-opensearch)[native-inputs]: Add 'perl-test-simple'.
---
 gnu/packages/web.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 253fd8b01..14ccf67df 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -3381,9 +3381,10 @@ web browsing, used for automating interaction with websites.")
                 "1yxplx1q1qk2fvnzqrbk01lz26fy1lyhay51a3ky7q3jgh9p01rb"))))
     (build-system perl-build-system)
     (arguments
-     `(#:tests? #f)) ; Tests require further modules to be packaged
+     `(#:tests? #f)) ; A large number of tests is failing.
     (native-inputs
-     `(("perl-module-install" ,perl-module-install)))
+     `(("perl-module-install" ,perl-module-install)
+       ("perl-test-simple" ,perl-test-simple)))
     (inputs
      `(("perl-data-page" ,perl-data-page)
        ("perl-libwww" ,perl-libwww)
-- 
2.14.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#28253: perl-www-opensearch: provide Test-Simple module

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

ng0 <ng0@infotropique.org> writes:

> This was supposed to fix the tests, but it doesn't
> so someone has to fix the large number of failing tests.
>
> Someone with perl test-simple knowledge or time to
> read into it.

I'm closing this bug, since guix-patches already has a huge backlog and
it's not a good avenue to discuss one-line work-in-progress patches.

If you would like assistance tracking down the failing test cases, I
suggest taking it on help-guix@ and/or upstream.

PS: We could use some help reviewing! :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#28253] perl-www-opensearch: provide Test-Simple module

[ng0]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

Marius Bakke transcribed 1.1K bytes:
> ng0 <ng0@infotropique.org> writes:
> 
> > This was supposed to fix the tests, but it doesn't
> > so someone has to fix the large number of failing tests.
> >
> > Someone with perl test-simple knowledge or time to
> > read into it.
> 
> I'm closing this bug, since guix-patches already has a huge backlog and
> it's not a good avenue to discuss one-line work-in-progress patches.
> 
> If you would like assistance tracking down the failing test cases, I
> suggest taking it on help-guix@ and/or upstream.
> 
> PS: We could use some help reviewing! :-)

Uh. Why? I added a dependency and commented that tests are
failing. Previously it states that "some more perl packages
are required". This *is* an improvement over the current status.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#28253] perl-www-opensearch: provide Test-Simple module

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 501 bytes --]

Updated patch with a small comment grammar fix.

Purpose of this patch: to add a dependency which was
previously unknown and had to be figured out by the
person who would try to fix the tests. So to go from
"nothing, uh what do we need here?" to
"hey, we have the test dependency" is an improvement
and not just a "work in progress" one-liner.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #1.2: 0001-gnu-perl-www-opensearch-Provide-Test-Simple.patch --]
[-- Type: text/plain, Size: 1716 bytes --]

From 15fae8813f1620aede9205f15537e786fa2ef455 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sun, 27 Aug 2017 18:18:24 +0000
Subject: [PATCH] gnu: perl-www-opensearch: Provide Test-Simple.

* gnu/packages/web.scm (perl-www-opensearch)[native-inputs]: Add 'perl-test-simple'.
---
 gnu/packages/web.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 13a46a550..06622aef5 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 ;;; Copyright © 2016 Ben Woodcroft <donttrustben@gmail.com>
 ;;; Copyright © 2016 Clément Lassieur <clement@lassieur.org>
-;;; Copyright © 2016, 2017 ng0 <ng0@no-reply.pragmatique.xyz>
+;;; Copyright © 2016, 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2016, 2017 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2016 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2016 Bake Timmons <b3timmons@speedymail.org>
@@ -3381,9 +3381,10 @@ web browsing, used for automating interaction with websites.")
                 "1yxplx1q1qk2fvnzqrbk01lz26fy1lyhay51a3ky7q3jgh9p01rb"))))
     (build-system perl-build-system)
     (arguments
-     `(#:tests? #f)) ; Tests require further modules to be packaged
+     `(#:tests? #f)) ;FIXME: A large number of tests are failing.
     (native-inputs
-     `(("perl-module-install" ,perl-module-install)))
+     `(("perl-module-install" ,perl-module-install)
+       ("perl-test-simple" ,perl-test-simple)))
     (inputs
      `(("perl-data-page" ,perl-data-page)
        ("perl-libwww" ,perl-libwww)
-- 
2.14.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#28253: perl-www-opensearch: provide Test-Simple module

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

ng0 <ng0@infotropique.org> writes:

> Updated patch with a small comment grammar fix.
>
> Purpose of this patch: to add a dependency which was
> previously unknown and had to be figured out by the
> person who would try to fix the tests. So to go from
> "nothing, uh what do we need here?" to
> "hey, we have the test dependency" is an improvement
> and not just a "work in progress" one-liner.

Right.  I don't think adding dependencies that does not change anything
with the package is very useful.  A comment stating that this dependency
would be needed to enable tests would do the same purpose without
changing the derivation.  But, it would take any packager about 20
seconds to find that Test::Simple is needed, so it's kind of "stating
the obvious".

Anyway I tried building this package with tests enabled and just kept
adding the modules it could not find as native-inputs until it
succeeded.  So I pushed a superset of this patch as
3fe666aa29e72a9fbb1e267eebcd7d197ec802f3.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]