From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmII0-0001Te-NI for guix-patches@gnu.org; Mon, 28 Aug 2017 07:33:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmIHu-00076J-PB for guix-patches@gnu.org; Mon, 28 Aug 2017 07:33:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50219) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmIHu-000769-L5 for guix-patches@gnu.org; Mon, 28 Aug 2017 07:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dmIHu-0001vw-El for guix-patches@gnu.org; Mon, 28 Aug 2017 07:33:02 -0400 Subject: [bug#28116] mate partial review Resent-Message-ID: Date: Mon, 28 Aug 2017 14:32:20 +0300 From: Efraim Flashner Message-ID: <20170828113220.GA1618@macbook42.flashner.co.il> References: <20170816205650.7pfzuyul3wcdltbx@abyayala> <20170824204246.GL2484@macbook42.flashner.co.il> <20170825181125.dfsc4wiav4lkocb2@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: <20170825181125.dfsc4wiav4lkocb2@abyayala> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 28116@debbugs.gnu.org --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 25, 2017 at 06:11:25PM +0000, ng0 wrote: > Efraim Flashner transcribed 16K bytes: > > I did all the building on my aarch64 board and didn't test the graphical > > aspects of running the programs. I also didn't check the > > synopsis/description, but some of them do look like they need some work. >=20 > Thanks for this first review. > I'll apply this as far as I can guess, having it all in one > patch makes it hard to read but I'll figure it out. >=20 sorry about that, I applied all the patches and then just worked on them all in one go. > > patch 1: it turns out the home pages should also be https. > >=20 > > mate-icon-theme and mate-themes don't need gtk in the inputs to build. > >=20 > > libmateweather, mate-panel, mate-control-center: needs a configure flag > >=20 > > mate-applet: it built fine for me with upower as an input > >=20 > > mate-control-center: librsvg and gdk-pixbuf should be propagated > >=20 > > caja: I enabled the display server and the tests still failed on me > >=20 > > mate-metapackage: I copied the build from xfce, it seemed to build fine > > for me. >=20 > Why use it like this? I copied my version from "gnome". >=20 xfce was changed because there were problems with overlapping packages between xfce and gnome in the example os-config.scm >=20 > --=20 > ng0 > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 > GnuPG: https://n0is.noblogs.org/my-keys > https://www.infotropique.org https://krosos.org --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlmj/zwACgkQQarn3Mo9 g1G18A//ZNS7O3JIvKbYTqVrtrf2/qyZiuL6Nwrwq2FHKx3mqcOkkwIuWU3AsSlW MOFdqho/fujAruqsNiFYW5GNl3PRq6Z0DXcDesgwNrtiiP/21+XJ6LXkn5aoescM WDtY8tRKaeJfdQl0uP+adHhcI1v6v07GezcqVz/NtKEMK3FnsF/8qE7HCT9Z9IRo xNII1ydZ+WqIHrB9OF8vwy+ry2q9jw/zqECRkvSq43M34ENf5JuzQge1FRzhUPuY bWwcPR/QdDLspcD2JCk8NkmSWExbVuUnnvXL6b2LGWVNGQ8aIJeXBXnkPUA5Tsjz OC2aslEJqKXCsb6eQKzLUF4E8tPm5IL4m9g709VjBi8qAIBMZUo3JhRgurs+2Dyq HOiU2uhn5pS14/VcoinbVU1JuI/BqXeOAens5tJSc7GzEugPAX4SWqLw+g36HNuS W9Wtbhd9mB5kLvQHsD46iJowRYVbkQhwICqGdA35K3/AFtlL0qyLQbpHe/9yb/Oi tBxw+oy7lt6PN8u7c0QUw/qLKsZ2QQAjwMJAAe9v7A+po8Lr+gVk4V5Xix/ZMdad Ico3vxwJ9Yje3y8IOZ9l0eUSK7kB0B1zGWILcblt7XKIz2htHGVdjsG7uKzU2G7k AtzHv4m5s8KazcH2ssMFrZTMFpQeUi/bKidMh/ghWSLEia/jmTU= =u4XQ -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--