unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: ng0 <ng0@infotropique.org>
Cc: 27967@debbugs.gnu.org
Subject: [bug#27967] [PATCH] maint: Create an ISO9660 installation image in the 'release' target.
Date: Sat, 19 Aug 2017 12:48:20 +0200	[thread overview]
Message-ID: <20170819124820.2e7e98fc@scratchpost.org> (raw)
In-Reply-To: <20170819091309.evdroejighjwsyva@abyayala>

Hi ng0,

On Sat, 19 Aug 2017 09:13:09 +0000
ng0 <ng0@infotropique.org> wrote:

> Danny Milosavljevic transcribed 0.2K bytes:
> > Pushed to master as d79013f66a98dca24e11193c43e78364043d0c16 with minimal changes (to the generated filename to keep it the same as before).  This means that our releases can now also be booted from DVD.  
> 
> I think there's the need to mention .iso extensions of the files,
> pr .iso.xz in case we compress them.

Hmm... what would that improve?

> This hasn't happened in the commit.

Indeed it hasn't.  The file names are the same as in the original.  That's mainly because I don't know what other scripts (possibly not in the Guix git repo) use these names and expect them to be as they were.

Also, there are a lot of systems which will never boot from DVD and also don't use Grub but rather boot from some strange fixed-position sector.  For those we'd not use grub-mkrescue (and hence no iso but rather a whole-disk image of a hard drive).  But then these images' names would be different.

So in the end if we conditionally changed the name I think we'd increase our maintenance burden for no gain (that I can see).

I've submitted a patch adding ".iso" anyway just now - not applied.

      parent reply	other threads:[~2017-08-19 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-05 10:12 [bug#27967] [PATCH] maint: Create an ISO9660 installation image in the 'release' target Danny Milosavljevic
2017-08-19  2:42 ` bug#27967: " Danny Milosavljevic
2017-08-19  9:13   ` [bug#27967] " ng0
2017-08-19 10:30     ` [bug#27967] [PATCH] maint: Rename release disk-images to include ".iso" in the name Danny Milosavljevic
2017-08-19 10:48     ` Danny Milosavljevic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170819124820.2e7e98fc@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=27967@debbugs.gnu.org \
    --cc=ng0@infotropique.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).