From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhhvd-0001wH-9w for guix-patches@gnu.org; Tue, 15 Aug 2017 15:55:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhhva-0003vV-3I for guix-patches@gnu.org; Tue, 15 Aug 2017 15:55:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhhvZ-0003vJ-W0 for guix-patches@gnu.org; Tue, 15 Aug 2017 15:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhhvZ-0002rs-OF for guix-patches@gnu.org; Tue, 15 Aug 2017 15:55:01 -0400 Subject: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Resent-Message-ID: Date: Tue, 15 Aug 2017 20:54:32 +0100 From: Christopher Baines Message-ID: <20170815205432.534c28ac@cbaines.net> In-Reply-To: <20170815192136.GB9893@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> <20170815192136.GB9893@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/vMW=L6q2/HBF109Su8xnnMq"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 28093@debbugs.gnu.org --Sig_/vMW=L6q2/HBF109Su8xnnMq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 15 Aug 2017 15:21:36 -0400 Leo Famulari wrote: > On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote: > > On Mon, 14 Aug 2017 23:31:37 -0400 > > Leo Famulari wrote: > > =20 > > > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the > > > git@2.10 package with an origin reference of the source code. > > > (git@2.10): Remove variable. =20 > >=20 > > It would be useful if outside of the changelog, but in the commit > > message, you could put why you are making the change. As far as I > > can tell, this won't change the cgit package, so I'm guessing the > > intent is to neaten up the code? =20 >=20 > Recently we started running the test suite of the "main" git package. >=20 > That caused the build of this package to fail, which also made cgit > fail to build, and that was annoying. >=20 > But, we don't even need to build this source code as a package, since > it gets built within the cgit build process, and we don't run the > tests there. >=20 > So, I figured we might as well not provide this as a package at all, > since it's really just intended to provide source code to cgit. >=20 > Does that sound reasonable? Yep, makes sense, and the diff looks good to me. > If so, I'll summarize this in the commit message. Great :D --Sig_/vMW=L6q2/HBF109Su8xnnMq Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmTUXhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XflJBAAiGfQYvJNEuOYg2RwGlygNEQSuw0nIlhxUNDLnR6Kpm+zPgqeZ0LlV9Jx m1JBDC5wO7Y7j6aS3m8e2+f/hxW4gTHY/eyfmPcExMNbTLjij/sGHApVnx5qgGIg sYNY5cMgxq13T9tBaGPXQ2HDhnfx67GI0wAlR2wQJ6NH/3XEzmP2iD24qQewDhPv uG0rCeP644CTyU882F3SfzP3f58WJoQDQjYm4SPPJVQWqpl/kohiWdx2p7X9+vzT bmK0DE42W9rX9oRvZH5CAs9ppArIJoetb3UutqKqPq3NEnfy/Gv1Dwj1mDDGwZoZ /Tuqp1PLABHfziAnrGK4cx+z41bd8YabRtVpaFwZkQ+5r3fiynvfvyKEZMwUpVSE kPPJDgdLyy5XTR1TeZgQy1BezQQ1VWKwFPDHI1tie6NnnOAH/+Y+ywWvg4WpqvkE XJTAPN4PTiqtiPW6nck0PhY2uFkcC1VHjbBCqb6tTKoYBMIgaA2tBdBAu0d/dT9C DcKO4UhdQZhD8nuIbRCq7x1VYU3yxF/YO1M6O46b5ppn9CoP6MbGhtU/7NUAqTJe d5RRSdxhUBWEG9VLcZzABV/ZOp17KQlhUg/JLh5Dx3hVKmX3VigutZgKBxaQoBKq Fi6WYuJXkRubzMwztID6Wp86ucJEWfdaaAhsauFO31l0ZYyU9mw= =XA0Q -----END PGP SIGNATURE----- --Sig_/vMW=L6q2/HBF109Su8xnnMq--