unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Christopher Baines <mail@cbaines.net>
Cc: 28093@debbugs.gnu.org
Subject: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input.
Date: Tue, 15 Aug 2017 15:21:36 -0400	[thread overview]
Message-ID: <20170815192136.GB9893@jasmine.lan> (raw)
In-Reply-To: <20170815073531.4b72ab02@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote:
> On Mon, 14 Aug 2017 23:31:37 -0400
> Leo Famulari <leo@famulari.name> wrote:
> 
> > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the
> > git@2.10 package with an origin reference of the source code.
> > (git@2.10): Remove variable.
> 
> It would be useful if outside of the changelog, but in the commit
> message, you could put why you are making the change. As far as I can
> tell, this won't change the cgit package, so I'm guessing the intent is
> to neaten up the code?

Recently we started running the test suite of the "main" git package.

That caused the build of this package to fail, which also made cgit
fail to build, and that was annoying.

But, we don't even need to build this source code as a package, since it
gets built within the cgit build process, and we don't run the tests
there.

So, I figured we might as well not provide this as a package at all,
since it's really just intended to provide source code to cgit.

Does that sound reasonable?

If so, I'll summarize this in the commit message.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-08-15 19:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15  3:31 [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input Leo Famulari
2017-08-15  6:35 ` Christopher Baines
2017-08-15 19:21   ` Leo Famulari [this message]
2017-08-15 19:54     ` Christopher Baines
2017-08-15 20:15     ` Marius Bakke
2017-08-15 20:24       ` Leo Famulari
2017-08-15 21:44         ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815192136.GB9893@jasmine.lan \
    --to=leo@famulari.name \
    --cc=28093@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).