From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1df9kX-0003oh-Ho for guix-patches@gnu.org; Tue, 08 Aug 2017 15:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1df9kU-0007nQ-Dw for guix-patches@gnu.org; Tue, 08 Aug 2017 15:01:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1df9kU-0007nJ-9e for guix-patches@gnu.org; Tue, 08 Aug 2017 15:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1df9kT-00071B-Om for guix-patches@gnu.org; Tue, 08 Aug 2017 15:01:01 -0400 Subject: [bug#28004] Chromium Resent-Message-ID: Date: Tue, 8 Aug 2017 18:59:52 +0000 From: ng0 Message-ID: <20170808185952.3fduefzgmc4nmrjh@abyayala> References: <87y3qvb15k.fsf@fastmail.com> <20170807202341.5c54jx4mpudor47i@abyayala> <87shh3axjf.fsf@fastmail.com> <20170808131801.snryxiiehczhnibr@abyayala> <20170808142223.re52odap7y32eten@abyayala> <20170808154422.rfmrom3qkgscloyj@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ylkdz3epm3sfdhc" Content-Disposition: inline In-Reply-To: <20170808154422.rfmrom3qkgscloyj@abyayala> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , 28004@debbugs.gnu.org --5ylkdz3epm3sfdhc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable ng0 transcribed 5.5K bytes: > ng0 transcribed 3.7K bytes: > > ng0 transcribed 3.4K bytes: > > > Marius Bakke transcribed 2.4K bytes: > > > > ng0 writes: > > > >=20 > > > > > Hi Marius, > > > > > > > > > > Marius Bakke transcribed 43K bytes: > > > > >> Hello Guix! > > > > >>=20 > > > > >> Attached is a patch for Chromium, a popular web browser. > > > > > > > > > > Nice! I've been using this from your branch for a while now, > > > > > works just fine :) > > > > > Is this not affected by the chromium discussion which happened > > > > > a while back? Can we include this? I'm all for this, because I > > > > > mainly use it for websites where firefox/icecat doesn't work so > > > > > well, and building it locally takes a very long time. > > > >=20 > > > > I believe this is within the Free System Distribution Guidelines. D= RM > > > > ("Widevine") is disabled at build time, and the Web Store is > > > > non-functional without the end user explicitly enabling it. > > > >=20 > > > > There are some grey areas though. The browser may interact with cer= tain > > > > non-free APIs (apart from regular browser duties) such as translati= on or > > > > prediction services. These features are optional, but some are enab= led > > > > by default, and difficult to maintain patches for (I've tried). > > > >=20 > > > > However, I have verified that it does not send any unsolicited requ= ests > > > > with the current command-line options, apart from the very first la= unch > > > > which spawns a login prompt (help wanted!). Without either of those > > > > flags the browser "calls home" every time it starts. > > > >=20 > > > > >> Note that I cannot guarantee timely delivery of security updates= =2E Major > > > > >> version upgrades are hugely painful, and almost always contain m= any > > > > >> high-severity fixes. Should we mention that in the description? > > > > >>=20 > > > > >> Happy for any feedback. > > > > >>=20 > > > > > > > > > > Shouldn't you mention defines in addition to the define-public as= well, > > > > > or don't we do that? > > > >=20 > > > > Not for new files (modules), typically. I don't think Magit can fil= l out > > > > those variable names (by pressing C on the hunks) either ;-) But it > > > > should probably go in web-browsers.scm anyway. > > >=20 > > > Unless someone else is already building this, I'm giving it a spin. > > >=20 > > > I guess you changed some things since the version of yours I have in > > > here: https://gitlab.com/ng0_guix/packages/blob/master/ng0/packages/c= hromium.scm > > > so I have to rebuild it. > > > It might take a while because I'm offloading to something much slower > > > but which doesn't care about heat as much as a this one ;) > >=20 > > Patch itself LGTM, I'm now waiting on the build to finish in the > > next couple of hours. >=20 > x86_64 architecture, builds fails at this point: >=20 > [6247/27388] STAMP obj/mojo/common/common.stamp > [6248/27388] ACTION //net/http:generate_transport_security_state(//build/= toolchain/linux:x64) > FAILED: gen/net/http/transport_security_state_static.h > python ../../build/gn_run_binary.py transport_security_state_generator ..= /../net/http/transport_security_state_static.json ../../net/http/transport_= security_state_static.pins ../../net/http/transport_security_state_static.t= emplate gen/net/http/transport_security_state_static.h > ./transport_security_state_generator: error while loading shared librarie= s: libglib-2.0.so.0: cannot open shared object file: No such file or direct= ory > transport_security_state_generator failed with exit code 127 > [6249/27388] AR obj/sandbox/linux/libsandbox_services.a > ninja: build stopped: subcommand failed. > phase `build' failed after 1777.2 seconds > builder for `/gnu/store/2afpy542vywbmk093dd1kzlfx74s2460-chromium-60.0.31= 12.90.drv' failed with exit code 1 > @ build-failed /gnu/store/2afpy542vywbmk093dd1kzlfx74s2460-chromium-60.0.= 3112.90.drv - 1 builder for `/gnu/store/2afpy542vywbmk093dd1kzlfx74s2460-ch= romium-60.0.3112.90.drv' failed with exit code 1 > derivation '/gnu/store/2afpy542vywbmk093dd1kzlfx74s2460-chromium-60.0.311= 2.90.drv' offloaded to '192.168.1.179' failed: build of `/gnu/store/2afpy54= 2vywbmk093dd1kzlfx74s2460-chromium-60.0.3112.90.drv' failed > @ build-failed /gnu/store/2afpy542vywbmk093dd1kzlfx74s2460-chromium-60.0.= 3112.90.drv - 1 builder for `/gnu/store/2afpy542vywbmk093dd1kzlfx74s2460-ch= romium-60.0.3112.90.drv' failed with exit code 100 > guix build: error: build failed: build of `/gnu/store/2afpy542vywbmk093dd= 1kzlfx74s2460-chromium-60.0.3112.90.drv' failed >=20 > Have you experienced this before? As efraim pointed out I missed the part where you wrote that it is for core-updates. I just assumed it worked like it is on master because what I had locally (chromium 58) works on master). Someone else must test it then. --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --5ylkdz3epm3sfdhc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlmKCigACgkQ4i+bv+40 hYjM8RAAqfGzQRj7U7ZfN/e7hWROq4fN/VAs2hCdIIfviR9wQ+sURnxb+YMLG6+/ wjH8Mouy1A5NwHZIvCPlt2x2BkQ6jnqykgHVmjqKpeSdbSAm2wq8ticJXvs4V23P gogHuMShmnzG2zP3H6BARHfyZkYznMZhkWP/Viokbxmz5OZHdQPsyxEfgVcsbhDc YKNP3LJQ7Uy5ew5tHULvCMnnfV7lSdZv+odxM0hq3pcIenyiMG7U0mtF4T0DbK4j nliJcicyREzz14tmOv4oAdkFVn5XQL3aLz9UJl6Jlgp3JueLxyHKiH8JAS65dVvG hN7160Q1NWHVBCpzU4ges5vbOjcpIFEisGDBffKL100tEcn2+rk8gUdf+y5gWstZ h34hb+qnnvcm4j6UbfL2lfEet+9EQRT7zfal/wbl5l+yl0NKEc7YjOipVdaM2tQV LDimFP96ENFXqGD8RFRulTsxhsH+guUOwmNn+7Wpye68hAIQeXoooDZqYlcb9W6w mU8ShuP1LYDQCaWrLi88EeS0fitm7dUHRP7UDkMqfK6syOMz8amJyILbL/CFltw6 kRuUZ1Mu4IhdBBBqJE9AkOhCjh5pkYDCMA+8ITp1Gt4RsgFTbjBiTqRzAf9kJq+i 67kjvEjIvs7y+XrQE7V+dQ2wwDC62WFWoVR5xO853pqwygqMvV4= =0TyA -----END PGP SIGNATURE----- --5ylkdz3epm3sfdhc--